Skip to content

[Due for payment 2025-03-21] Automatically dismiss the migration modal in all open tabs #57630

Closed

Description

@trjExpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.1.7-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: None
Email or phone of affected tester (no customers): in thread.
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation (hyperlinked to channel name): #migrate

Action Performed:

Pre-requisite:

  • Be a customer with a timestamp value in nudgeMigration that has not used NewDot yet
  1. Sign-in to expensify.com
  2. Get redirected to new.expensify.com
  3. Open a second new.expensify.com
  4. Observe the migration modal appears
  5. Dismiss the migration modal in the second tab
  6. Switch to the first tab
  7. Observe the migration modal

Expected Result:

The migration modal should dismiss in all open tabs.

Actual Result:

The migration modal is popping up in each tab the user has opened.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Session screenies in thread.

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @trjExpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 28, 2025
  2. melvin-bot commented on Feb 28, 2025

    @melvin-bot

    Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

  3. added
    ReviewingHas a PR in review
    and removed on Mar 2, 2025
  4. trjExpensify commented on Mar 3, 2025

    @trjExpensify
    ContributorAuthor

    Assigning @shubham1206agra as you're assigned for C+ review.

  5. trjExpensify commented on Mar 3, 2025

    @trjExpensify
    ContributorAuthor

    @puneetlath you want to take the internal PR review?

  6. self-assigned this
    on Mar 3, 2025
  7. puneetlath commented on Mar 3, 2025

    @puneetlath
    Contributor

    Yep, I can review after @shubham1206agra does.

  8. moved this to Second Cohort - MEDIUM or LOW in [#whatsnext] #migrateon Mar 4, 2025
  9. 8 remaining items

  10. melvin-bot commented on Mar 14, 2025

    @melvin-bot

    @shubham1206agra / @ishpaul777 @trjExpensify @shubham1206agra / @ishpaul777 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  11. melvin-bot commented on Mar 21, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@trjExpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  12. trjExpensify commented on Mar 21, 2025

    @trjExpensify
    ContributorAuthor

    👋 Checklist time, @ishpaul777.

  13. ishpaul777 commented on Mar 23, 2025

    @ishpaul777
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
      Link to comment: https://github.com/Expensify/App/pull/53225/files#r2009214188

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
      Link to discussion: not critical, this was not part of original design doc, we never thought of the edge case

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. - Very edge, does not really block any functionality, not recomended

  14. trjExpensify commented on Mar 24, 2025

    @trjExpensify
    ContributorAuthor

    Thanks! Payment summary as follows:

    Go ahead and request. Closing - thanks!

  15. moved this from Second Cohort - MEDIUM or LOW to Done in [#whatsnext] #migrateon Mar 24, 2025
  16. garrettmknight commented on Apr 22, 2025

    @garrettmknight
    Contributor

    $250 approved for @shubham1206agra

  17. garrettmknight commented on May 2, 2025

    @garrettmknight
    Contributor

    $250 approved for @ishpaul777

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions