You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-03-21] Automatically dismiss the migration modal in all open tabs #57630
Version Number: v9.1.7-1 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: None Email or phone of affected tester (no customers): in thread. Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by:@trjExpensify Slack conversation (hyperlinked to channel name): #migrate
Action Performed:
Pre-requisite:
Be a customer with a timestamp value in nudgeMigration that has not used NewDot yet
Sign-in to expensify.com
Get redirected to new.expensify.com
Open a second new.expensify.com
Observe the migration modal appears
Dismiss the migration modal in the second tab
Switch to the first tab
Observe the migration modal
Expected Result:
The migration modal should dismiss in all open tabs.
Actual Result:
The migration modal is popping up in each tab the user has opened.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
@shubham1206agra / @ishpaul777@trjExpensify@shubham1206agra / @ishpaul777 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: not critical, this was not part of original design doc, we never thought of the edge case
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. - Very edge, does not really block any functionality, not recomended
Activity
melvin-bot commentedon Feb 28, 2025
Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.
trjExpensify commentedon Mar 3, 2025
Assigning @shubham1206agra as you're assigned for C+ review.
trjExpensify commentedon Mar 3, 2025
@puneetlath you want to take the internal PR review?
puneetlath commentedon Mar 3, 2025
Yep, I can review after @shubham1206agra does.
8 remaining items
melvin-bot commentedon Mar 14, 2025
@shubham1206agra / @ishpaul777 @trjExpensify @shubham1206agra / @ishpaul777 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Mar 21, 2025
Payment Summary
Upwork Job
BugZero Checklist (@trjExpensify)
trjExpensify commentedon Mar 21, 2025
👋 Checklist time, @ishpaul777.
ishpaul777 commentedon Mar 23, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/53225/files#r2009214188
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: not critical, this was not part of original design doc, we never thought of the edge case
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. - Very edge, does not really block any functionality, not recomended
trjExpensify commentedon Mar 24, 2025
Thanks! Payment summary as follows:
Go ahead and request. Closing - thanks!
garrettmknight commentedon Apr 22, 2025
$250 approved for @shubham1206agra
garrettmknight commentedon May 2, 2025
$250 approved for @ishpaul777