Skip to content

[$250] Workspace - Invite - App doesn't return to invite flow after navigating to Concierge #57834

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.1.9-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/2990396&group_by=cases:section_id&group_id=229065&group_order=asc
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: iPhone 12 / iOS 17.7.2
App Component: Workspace Settings

Action Performed:

  1. Log in to the app
  2. Create a new workspace
  3. Start the member invite flow
  4. Select a user from the list (or search)
  5. Tap on the Help button
  6. Tap the "Chat with Concierge" button
  7. Tap on the return button

Expected Result:

The app should return to the invite flow, allowing the admin to continue with the selected user.

Actual Result:

After tapping the return button from the Concierge chat, the app navigates back to the Home page, forcing the admin to restart the invite flow and reselect the user.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6761645_1741166897218.Invite_help_not_return.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021899185071498406890
  • Upwork Job ID: 1899185071498406890
  • Last Price Increase: 2025-03-10
  • Automatic offers:
    • nkdengineer | Contributor | 106484673
Issue OwnerCurrent Issue Owner: @abekkala

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 5, 2025
  2. melvin-bot commented on Mar 5, 2025

    @melvin-bot

    Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. nkdengineer commented on Mar 5, 2025

    @nkdengineer
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    After tapping the return button from the Concierge chat, the app navigates back to the Home page, forcing the admin to restart the invite flow and reselect the user.

    What is the root cause of that problem?

    We only navigate to Concierge here

    {
    title: translate('getAssistancePage.chatWithConcierge'),
    onPress: () => Report.navigateToConciergeChat(isLargeScreenWidth),
    icon: Expensicons.ChatBubble,
    shouldShowRightIcon: true,
    wrapperStyle: [styles.cardMenuItem],

    What changes do you think we should make in order to solve the problem?

    1. We should add backTo to route REPORT_WITH_ID

    2. And pass routes.prams?.backTo as backTo params here

    {
    title: translate('getAssistancePage.chatWithConcierge'),
    onPress: () => Report.navigateToConciergeChat(isLargeScreenWidth),
    icon: Expensicons.ChatBubble,
    shouldShowRightIcon: true,
    wrapperStyle: [styles.cardMenuItem],

    1. Pass backTo to this navigate

    Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(conciergeChatReportID), linkToOptions);

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None

    What alternative solutions did you explore? (Optional)

    NA

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. melvin-bot commented on Mar 10, 2025

    @melvin-bot

    @abekkala Eep! 4 days overdue now. Issues have feelings too...

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 10, 2025
  6. melvin-bot commented on Mar 10, 2025

    @melvin-bot
  7. changed the title [-]Workspace - Invite - App doesn't return to invite flow after navigating to Concierge[/-] [+][$250] Workspace - Invite - App doesn't return to invite flow after navigating to Concierge[/+] on Mar 10, 2025
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 10, 2025
  9. melvin-bot commented on Mar 10, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

  10. hungvu193 commented on Mar 11, 2025

    @hungvu193
    Contributor

    @nkdengineer 's proposal here looks good to me! 🎀 👀 🎀

  11. 17 remaining items

  12. abekkala commented on Mar 23, 2025

    @abekkala
    Contributor

    @hungvu193 yes, that is with the understanding that the PR was created and the review started.
    Closing a job with only an approved proposal and nothing else does not qualify

  13. hungvu193 commented on Mar 25, 2025

    @hungvu193
    Contributor

    cc @mallenexpensify for the comment above 😄

    @abekkala I think we already noted this in this docs section

    If a contributor has been hired for a job and we decide to close the job before it is successfully completed:
    - 50% payment to contributor and C+ if the contributor was 🎀👀🎀 by a C+ or hired/assigned. 
    
  14. melvin-bot commented on Mar 25, 2025

    @melvin-bot

    Current assignees @AndrewGable and @inimaga are eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

  15. abekkala commented on Mar 25, 2025

    @abekkala
    Contributor

    @mallenexpensify Can you clarify - I was under the impression that the partial payment is only given when a PR has been created and review started. Not necessarily partial payment if the issue is closed prior to that and only a selected proposal was done.

  16. mallenexpensify commented on Mar 25, 2025

    @mallenexpensify
    Contributor

    This is a tricky one. I think the source of truth, which we should stick with, and is aligned with @hungvu193 's reasoning is... we assigned a contributor here. This is an action only an employee can take and it denotes both the contributor and C+ were hired, and did work in order to get hired . We then decided later to close the issue which wasn't their fault.

    So payment should be 50% for both and the process docs should be accurate.

  17. abekkala commented on Mar 26, 2025

    @abekkala
    Contributor

    PAYMENT SUMMARY MAR 26 - 50%

  18. garrettmknight commented on Mar 31, 2025

    @garrettmknight
    Contributor

    $125 approved for @hungvu193

  19. melvin-bot commented on Apr 1, 2025

    @melvin-bot

    @abekkala Eep! 4 days overdue now. Issues have feelings too...

  20. abekkala commented on Apr 1, 2025

    @abekkala
    Contributor

    @nkdengineer you have still not accepted the offer in upwork. Can you do that so I can pay this out and close this issue?

  21. nkdengineer commented on Apr 2, 2025

    @nkdengineer
    Contributor

    @abekkala I accepted it, thanks 🙏

  22. abekkala commented on Apr 2, 2025

    @abekkala
    Contributor

    @nkdengineer payment sent and contract ended - thank you! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions