You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Workspace - Invite - App doesn't return to invite flow after navigating to Concierge #57834
Version Number: v9.1.9-2 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both If this was caught during regression testing, add the test name, ID and link from TestRail:https://expensify.testrail.io/index.php?/cases/view/2990396&group_by=cases:section_id&group_id=229065&group_order=asc Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Device used: iPhone 12 / iOS 17.7.2 App Component: Workspace Settings
Action Performed:
Log in to the app
Create a new workspace
Start the member invite flow
Select a user from the list (or search)
Tap on the Help button
Tap the "Chat with Concierge" button
Tap on the return button
Expected Result:
The app should return to the invite flow, allowing the admin to continue with the selected user.
Actual Result:
After tapping the return button from the Concierge chat, the app navigates back to the Home page, forcing the admin to restart the invite flow and reselect the user.
Please re-state the problem that we are trying to solve in this issue.
After tapping the return button from the Concierge chat, the app navigates back to the Home page, forcing the admin to restart the invite flow and reselect the user.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Workspace - Invite - App doesn't return to invite flow after navigating to Concierge[/-][+][$250] Workspace - Invite - App doesn't return to invite flow after navigating to Concierge[/+]on Mar 10, 2025
@hungvu193 yes, that is with the understanding that the PR was created and the review started.
Closing a job with only an approved proposal and nothing else does not qualify
If a contributor has been hired for a job and we decide to close the job before it is successfully completed:
- 50% payment to contributor and C+ if the contributor was 🎀👀🎀 by a C+ or hired/assigned.
@mallenexpensify Can you clarify - I was under the impression that the partial payment is only given when a PR has been created and review started. Not necessarily partial payment if the issue is closed prior to that and only a selected proposal was done.
This is a tricky one. I think the source of truth, which we should stick with, and is aligned with @hungvu193 's reasoning is... we assigned a contributor here. This is an action only an employee can take and it denotes both the contributor and C+ were hired, and did work in order to get hired . We then decided later to close the issue which wasn't their fault.
So payment should be 50% for both and the process docs should be accurate.
Activity
melvin-bot commentedon Mar 5, 2025
Triggered auto assignment to @abekkala (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nkdengineer commentedon Mar 5, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
After tapping the return button from the Concierge chat, the app navigates back to the Home page, forcing the admin to restart the invite flow and reselect the user.
What is the root cause of that problem?
We only navigate to Concierge here
App/src/pages/GetAssistancePage.tsx
Lines 40 to 45 in 0002c66
What changes do you think we should make in order to solve the problem?
We should add
backToto route REPORT_WITH_IDAnd pass
routes.prams?.backToasbackToparams hereApp/src/pages/GetAssistancePage.tsx
Lines 40 to 45 in 0002c66
backToto this navigateApp/src/libs/actions/Report.ts
Line 2394 in 0002c66
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
melvin-bot commentedon Mar 10, 2025
@abekkala Eep! 4 days overdue now. Issues have feelings too...
melvin-bot commentedon Mar 10, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021899185071498406890
[-]Workspace - Invite - App doesn't return to invite flow after navigating to Concierge[/-][+][$250] Workspace - Invite - App doesn't return to invite flow after navigating to Concierge[/+]melvin-bot commentedon Mar 10, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (
External)hungvu193 commentedon Mar 11, 2025
@nkdengineer 's proposal here looks good to me! 🎀 👀 🎀
17 remaining items
abekkala commentedon Mar 23, 2025
@hungvu193 yes, that is with the understanding that the PR was created and the review started.
Closing a job with only an approved proposal and nothing else does not qualify
hungvu193 commentedon Mar 25, 2025
cc @mallenexpensify for the comment above 😄
melvin-bot commentedon Mar 25, 2025
Current assignees @AndrewGable and @inimaga are eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.
abekkala commentedon Mar 25, 2025
@mallenexpensify Can you clarify - I was under the impression that the partial payment is only given when a PR has been created and review started. Not necessarily partial payment if the issue is closed prior to that and only a selected proposal was done.
mallenexpensify commentedon Mar 25, 2025
This is a tricky one. I think the source of truth, which we should stick with, and is aligned with @hungvu193 's reasoning is... we assigned a contributor here. This is an action only an employee can take and it denotes both the contributor and C+ were hired, and did work in order to get hired . We then decided later to close the issue which wasn't their fault.
So payment should be 50% for both and the process docs should be accurate.
abekkala commentedon Mar 26, 2025
PAYMENT SUMMARY MAR 26 - 50%
garrettmknight commentedon Mar 31, 2025
$125 approved for @hungvu193
melvin-bot commentedon Apr 1, 2025
@abekkala Eep! 4 days overdue now. Issues have feelings too...
abekkala commentedon Apr 1, 2025
@nkdengineer you have still not accepted the offer in upwork. Can you do that so I can pay this out and close this issue?
nkdengineer commentedon Apr 2, 2025
@abekkala I accepted it, thanks 🙏
abekkala commentedon Apr 2, 2025
@nkdengineer payment sent and contract ended - thank you! 🎉