Skip to content

[Hold for payment 2025-03-25][$125] Refactor buildOptimisticIOUReportAction to use a parameter object #57956

Closed

Description

@neil-marcellini

As part of the tracking issue, and as advised in its description, refactor buildOptimisticIOUReportAction to use a parameter object.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021897772318822598895
  • Upwork Job ID: 1897772318822598895
  • Last Price Increase: 2025-03-06
  • Automatic offers:
    • linhvovan29546 | Contributor | 106461974
Issue OwnerCurrent Issue Owner: @sonialiap

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 6, 2025
  2. melvin-bot commented on Mar 6, 2025

    @melvin-bot
  3. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 6, 2025
  4. melvin-bot commented on Mar 6, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

  5. melvin-bot commented on Mar 6, 2025

    @melvin-bot

    Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  6. linhvovan29546 commented on Mar 7, 2025

    @linhvovan29546
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Refactor buildOptimisticIOUReportAction to use a parameter object

    What is the root cause of that problem?

    Improment

    What changes do you think we should make in order to solve the problem?

    Refactor buildOptimisticIOUReportAction function to use a parameter object

    function buildOptimisticIOUReportAction(

    Image

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    Update the unit test to use a parameter object

    What alternative solutions did you explore? (Optional)

    N/A

  7. github-actions commented on Mar 7, 2025

    @github-actions
    Contributor

    ⚠️ @linhvovan29546 Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

  8. linhvovan29546 commented on Mar 7, 2025

    @linhvovan29546
  9. melvin-bot commented on Mar 10, 2025

    @melvin-bot

    @eVoloshchak Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  10. 11 remaining items

  11. removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 24, 2025
  12. sonialiap commented on Mar 24, 2025

    @sonialiap
    Contributor

    Deployed to prod on the 18. 18+7 =25, payment due on the 25th

  13. changed the title [-][$125] Refactor buildOptimisticIOUReportAction to use a parameter object[/-] [+][Hold for payment 2025-03-25][$125] Refactor buildOptimisticIOUReportAction to use a parameter object[/+] on Mar 24, 2025
  14. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Mar 24, 2025
  15. sonialiap commented on Mar 24, 2025

    @sonialiap
    Contributor

    Payment summary:

  16. melvin-bot commented on Mar 28, 2025

    @melvin-bot

    @sonialiap Whoops! This issue is 2 days overdue. Let's get this updated quick!

  17. sonialiap commented on Mar 28, 2025

    @sonialiap
    Contributor

    All paid, refactor issue so no regression test needed

  18. garrettmknight commented on Dec 18, 2025

    @garrettmknight
    Contributor

    $125 approved for @eVoloshchak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions