Skip to content

[Awaiting payment] [$125] Refactor buildOptimisticChatReport to use a parameter object #57958

Closed

Description

@neil-marcellini

As part of the tracking issue, and as advised in its description, refactor buildOptimisticChatReport to use a parameter object.

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021907134919822597563
  • Upwork Job ID: 1907134919822597563
  • Last Price Increase: 2025-04-01
Issue OwnerCurrent Issue Owner: @garrettmknight

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 6, 2025
  2. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 6, 2025
  3. melvin-bot commented on Mar 6, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

  4. melvin-bot commented on Mar 6, 2025

    @melvin-bot

    Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. Shahidullah-Muffakir commented on Mar 6, 2025

    @Shahidullah-Muffakir
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Refactor buildOptimisticChatReport to use parameter objec.

    What is the root cause of that problem?

    Improvement

    What changes do you think we should make in order to solve the problem?

    Update the buildOptimisticChatReport to accept parameter object, and pass parameter object in all the places the function is called.

    function buildOptimisticChatReport(

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    No tests needed, because It's just a refactor.

    What alternative solutions did you explore? (Optional)

  6. daledah commented on Mar 7, 2025

    @daledah
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Refactor buildOptimisticChatReport to use a parameter object

    What is the root cause of that problem?

    Refactor

    What changes do you think we should make in order to solve the problem?

    Update the buildOptimisticChatReport to accept parameter object, and pass parameter object in all the places the function is called.

    function buildOptimisticChatReport(

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    Refactor bug

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  7. github-actions commented on Mar 7, 2025

    @github-actions
    Contributor

    ⚠️ @daledah Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

  8. hoangzinh commented on Mar 7, 2025

    @hoangzinh
    Contributor

    Thanks for posting proposals, everyone. It's a straightforward issue, thus let's go with @Shahidullah-Muffakir's proposal

    Link to proposal #57958 (comment)

    🎀👀🎀 C+ reviewed

  9. melvin-bot commented on Mar 7, 2025

    @melvin-bot

    Current assignee @neil-marcellini is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

  10. 22 remaining items

  11. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 1, 2025
  12. melvin-bot commented on Apr 1, 2025

    @melvin-bot

    📣 @Shahidullah-Muffakir You have been assigned to this job!
    Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
    Keep in mind: Code of Conduct | Contributing 📖

  13. changed the title [-][$125] Refactor buildOptimisticChatReport to use a parameter object[/-] [+][Awaiting payment] [$125] Refactor buildOptimisticChatReport to use a parameter object[/+] on Apr 1, 2025
  14. Shahidullah-Muffakir commented on Apr 2, 2025

    @Shahidullah-Muffakir
    Contributor

    Thank you, I've applied!

  15. melvin-bot commented on Apr 7, 2025

    @melvin-bot

    @dylanexpensify Eep! 4 days overdue now. Issues have feelings too...

  16. garrettmknight commented on Apr 9, 2025

    @garrettmknight
    Contributor

    Taking over for BZ on the Upwork payment - @Shahidullah-Muffakir please accept the offer.

  17. Shahidullah-Muffakir commented on Apr 9, 2025

    @Shahidullah-Muffakir
    Contributor

    Taking over for BZ on the Upwork payment - @Shahidullah-Muffakir please accept the offer.

    Accepted, Thanks.

  18. garrettmknight commented on Apr 10, 2025

    @garrettmknight
    Contributor

    Paid, closign.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions