You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Awaiting payment] [$125] Refactor buildOptimisticChatReport to use a parameter object #57958
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
Refactor bug
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
⚠️@daledah Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).
📣 @Shahidullah-Muffakir You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖
changed the title [-][$125] Refactor buildOptimisticChatReport to use a parameter object[/-][+][Awaiting payment] [$125] Refactor buildOptimisticChatReport to use a parameter object[/+]on Apr 1, 2025
Activity
melvin-bot commentedon Mar 6, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (
External)melvin-bot commentedon Mar 6, 2025
Triggered auto assignment to @dylanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.Shahidullah-Muffakir commentedon Mar 6, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Refactor
buildOptimisticChatReportto use parameter objec.What is the root cause of that problem?
Improvement
What changes do you think we should make in order to solve the problem?
Update the
buildOptimisticChatReportto accept parameter object, and pass parameter object in all the places the function is called.App/src/libs/ReportUtils.ts
Line 6027 in 4fabee6
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
No tests needed, because It's just a refactor.
What alternative solutions did you explore? (Optional)
daledah commentedon Mar 7, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Refactor buildOptimisticChatReport to use a parameter object
What is the root cause of that problem?
Refactor
What changes do you think we should make in order to solve the problem?
Update the buildOptimisticChatReport to accept parameter object, and pass parameter object in all the places the function is called.
App/src/libs/ReportUtils.ts
Line 6027 in 4fabee6
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
Refactor bug
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
github-actions commentedon Mar 7, 2025
hoangzinh commentedon Mar 7, 2025
Thanks for posting proposals, everyone. It's a straightforward issue, thus let's go with @Shahidullah-Muffakir's proposal
Link to proposal #57958 (comment)
🎀👀🎀 C+ reviewed
melvin-bot commentedon Mar 7, 2025
Current assignee @neil-marcellini is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.
22 remaining items
melvin-bot commentedon Apr 1, 2025
📣 @Shahidullah-Muffakir You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖
[-][$125] Refactor buildOptimisticChatReport to use a parameter object[/-][+][Awaiting payment] [$125] Refactor buildOptimisticChatReport to use a parameter object[/+]Shahidullah-Muffakir commentedon Apr 2, 2025
Thank you, I've applied!
melvin-bot commentedon Apr 7, 2025
@dylanexpensify Eep! 4 days overdue now. Issues have feelings too...
garrettmknight commentedon Apr 9, 2025
Taking over for BZ on the Upwork payment - @Shahidullah-Muffakir please accept the offer.
Shahidullah-Muffakir commentedon Apr 9, 2025
Accepted, Thanks.
garrettmknight commentedon Apr 10, 2025
Paid, closign.