You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Awaiting checklist] [$250] Thread - Thread header shows skeleton, message is empty when parent message is deleted #58134
Version Number: 9.1.11-1 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):applausetester+3408349@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.3 / Chrome App Component: Chat Report View
Action Performed:
Go to staging.new.expensify.com
Go to any chat.
Send a message.
Right click on the message > Reply in thread.
Right click on the parent message > Delete comment.
Delete the comment.
Expected Result:
Thread header in chat report view and LHN will show "Deleted comment".
Please re-state the problem that we are trying to solve in this issue.
Thread header in chat report view shows skeleton.
Thread title in LHN shows Hidden.
The deleted comment is empty with (edited) label.
What is the root cause of that problem?
After deleting the parent message, the chat is empty and we don't have the logic to go back to the previous chat, so we can see the skeleton in the header (the report is deleted and never loaded)
What changes do you think we should make in order to solve the problem?
We also can use ROUTES.REPORT_WITH_ID.getRoute(reportID) as fallback url or use navigateToMostRecentReport
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
We can write the test to mimic this case in tests/ui, simulate this case then verify the parent chat is shown at the end
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Thread - Thread header shows skeleton, message is empty when parent message is deleted[/-][+][$250] Thread - Thread header shows skeleton, message is empty when parent message is deleted[/+]on Mar 15, 2025
What changes do you think we should make in order to solve the problem?
To address this issue, we updated the logic to handle both the parent and child routes. The conditions to check whether either the parent or the child route is active before navigating back to the parent report.
changed the title [-][$250] Thread - Thread header shows skeleton, message is empty when parent message is deleted[/-][+][Due for payment 2025-04-02] [$250] Thread - Thread header shows skeleton, message is empty when parent message is deleted[/+]on Mar 26, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.18-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@mananjadhav@twisterdotcom@mananjadhav The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
changed the title [-][Due for payment 2025-04-02] [$250] Thread - Thread header shows skeleton, message is empty when parent message is deleted[/-][+][Awaiting checklist] [$250] Thread - Thread header shows skeleton, message is empty when parent message is deleted[/+]on Apr 2, 2025
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: I couldn't pinpoint a specific PR where this could've been handled.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Go to any chat.
Send a message.
Right click on the message > Reply in thread.
Right click on the parent message > Delete comment.
Delete the comment.
Verify that: user should go back to the previous chat
Activity
melvin-bot commentedon Mar 11, 2025
Triggered auto assignment to @twisterdotcom (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nkdengineer commentedon Mar 11, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Thread header in chat report view shows skeleton.
Thread title in LHN shows Hidden.
The deleted comment is empty with (edited) label.
What is the root cause of that problem?
After deleting the parent message, the chat is empty and we don't have the logic to go back to the previous chat, so we can see the skeleton in the header (the report is deleted and never loaded)
What changes do you think we should make in order to solve the problem?
We should add the logic to handle this case in
App/src/libs/actions/Report.ts
Line 1727 in ef00a61
We also can use
ROUTES.REPORT_WITH_ID.getRoute(reportID)as fallback url or usenavigateToMostRecentReportWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
We can write the test to mimic this case in
tests/ui, simulate this case then verify the parent chat is shown at the endWhat alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
melvin-bot commentedon Mar 14, 2025
@twisterdotcom Whoops! This issue is 2 days overdue. Let's get this updated quick!
[-]Thread - Thread header shows skeleton, message is empty when parent message is deleted[/-][+][$250] Thread - Thread header shows skeleton, message is empty when parent message is deleted[/+]melvin-bot commentedon Mar 15, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021900900424719200581
melvin-bot commentedon Mar 15, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (
External)kaushiktd commentedon Mar 18, 2025
Please re-state the problem that we are trying to solve in this issue.
Thread header shows skeleton, message is empty when parent message is deleted
What is the root cause of that problem?
The root cause of the issue lies in the navigation logic that handles the transition after deleting a parent message.
The original implementation only checks if the parent route is active and navigates back to the parent report
App/src/libs/actions/Report.ts
Line 1725 in ef00a61
What changes do you think we should make in order to solve the problem?
To address this issue, we updated the logic to handle both the parent and child routes. The conditions to check whether either the parent or the child route is active before navigating back to the parent report.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
N/A
video:-
screen-capture.webm
16 remaining items
[-][$250] Thread - Thread header shows skeleton, message is empty when parent message is deleted[/-][+][Due for payment 2025-04-02] [$250] Thread - Thread header shows skeleton, message is empty when parent message is deleted[/+]melvin-bot commentedon Mar 26, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 26, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.18-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-04-02. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 26, 2025
@mananjadhav @twisterdotcom @mananjadhav The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
twisterdotcom commentedon Mar 26, 2025
@mananjadhav must complete the checklist.
twisterdotcom commentedon Apr 2, 2025
Payment Summary:
[-][Due for payment 2025-04-02] [$250] Thread - Thread header shows skeleton, message is empty when parent message is deleted[/-][+][Awaiting checklist] [$250] Thread - Thread header shows skeleton, message is empty when parent message is deleted[/+]mananjadhav commentedon Apr 2, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: I couldn't pinpoint a specific PR where this could've been handled.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
@twisterdotcom Do we agree 👍 or 👎
garrettmknight commentedon Apr 10, 2025
$250 approved for @mananjadhav