Skip to content

[Due for payment 2025-04-07] Web - Task - Hyperlink underline is blocked by inline code in the task report #58181

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.11-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp #54165
Email or phone of affected tester (no customers): applausetester+ps309@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Other

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to chat.
  3. Click + > Assign task.
  4. Click Title.
  5. Enter the following multiline content with markdown:

long link name
inline code

  1. Save the title and create the task.
  2. Click on the task preview.

Expected Result:

Hyperlink underline will not be blocked by inline code in the task report.

Actual Result:

Hyperlink underline is blocked by inline code in the task report.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Image
Bug6767065_1741679172654.20250311_154243.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @MitchExpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    DeployBlockerCashThis issue or pull request should block deployment
    on Mar 11, 2025
  2. melvin-bot commented on Mar 11, 2025

    @melvin-bot

    Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Mar 11, 2025

    @melvin-bot

    Triggered auto assignment to @mountiny (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Mar 11, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Mar 11, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. drminh2807 commented on Mar 11, 2025

    @drminh2807
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Web - Task - Hyperlink underline is blocked by inline code in the task report

    What is the root cause of that problem?

    Line height is not high enough

    App/src/styles/index.ts

    Lines 4267 to 4274 in 5558382

    taskTitleMenuItem: {
    ...writingDirection.ltr,
    ...headlineFont,
    fontSize: variables.fontSizeXLarge,
    lineHeight: variables.lineHeightSizeh2,
    maxWidth: '100%',
    ...wordBreak.breakWord,
    },

    What changes do you think we should make in order to solve the problem?

    Increase the line height

    lineHeight: variables.lineHeightXXLarge

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N/A

    What alternative solutions did you explore? (Optional)

    N/A

  7. daledah commented on Mar 11, 2025

    @daledah
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Hyperlink underline is blocked by inline code in the task report.

    What is the root cause of that problem?

    We're using lineHeight: 23px

    App/src/styles/index.ts

    Lines 4267 to 4274 in 5558382

    taskTitleMenuItem: {
    ...writingDirection.ltr,
    ...headlineFont,
    fontSize: variables.fontSizeXLarge,
    lineHeight: variables.lineHeightSizeh2,
    maxWidth: '100%',
    ...wordBreak.breakWord,
    },

    but the height of each child is 27px so they're overlapped

    What changes do you think we should make in order to solve the problem?

    We shouldn't use lineHeight, then it'll apply the lineHeight from parent, in this case it's 28px. We also can remove lineHeight in taskTitleMenuItemItalic

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    UI issue

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  8. 14 remaining items

  9. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Mar 31, 2025
  10. changed the title [-]Web - Task - Hyperlink underline is blocked by inline code in the task report[/-] [+][Due for payment 2025-04-07] Web - Task - Hyperlink underline is blocked by inline code in the task report[/+] on Mar 31, 2025
  11. melvin-bot commented on Mar 31, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Mar 31, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.20-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-04-07. 🎊

    For reference, here are some details about the assignees on this issue:

    • @mananjadhav requires payment through NewDot Manual Requests
    • @Krishna2323 requires payment (Needs manual offer from BZ)
  13. melvin-bot commented on Mar 31, 2025

    @melvin-bot

    @mananjadhav @MitchExpensify @mananjadhav The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. mananjadhav commented on Mar 31, 2025

    @mananjadhav
    Collaborator

    Linked PR was deployed to production. Payout should be handled in the original issue. #53175

  15. MitchExpensify commented on Apr 2, 2025

    @MitchExpensify
    Contributor

    @mananjadhav, and even if payment is handled there, there are no new BZ steps needed here, right? I think we can close if "yes"

  16. mananjadhav commented on Apr 2, 2025

    @mananjadhav
    Collaborator

    Yes we can close this one.

  17. melvin-bot commented on Apr 7, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@MitchExpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions