You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-04-07] Web - Task - Hyperlink underline is blocked by inline code in the task report #58181
Version Number: 9.1.11-1 Reproducible in staging?: Yes Reproducible in production?: No If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: Exp #54165 Email or phone of affected tester (no customers):applausetester+ps309@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.3 / Chrome App Component: Other
Action Performed:
Go to staging.new.expensify.com
Go to chat.
Click + > Assign task.
Click Title.
Enter the following multiline content with markdown:
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
but the height of each child is 27px so they're overlapped
What changes do you think we should make in order to solve the problem?
We shouldn't use lineHeight, then it'll apply the lineHeight from parent, in this case it's 28px. We also can remove lineHeight in taskTitleMenuItemItalic
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
UI issue
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Web - Task - Hyperlink underline is blocked by inline code in the task report[/-][+][Due for payment 2025-04-07] Web - Task - Hyperlink underline is blocked by inline code in the task report[/+]on Mar 31, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.20-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@mananjadhav@MitchExpensify@mananjadhav The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Mar 11, 2025
Triggered auto assignment to @MitchExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Mar 11, 2025
Triggered auto assignment to @mountiny (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Mar 11, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Mar 11, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
drminh2807 commentedon Mar 11, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Web - Task - Hyperlink underline is blocked by inline code in the task report
What is the root cause of that problem?
Line height is not high enough
App/src/styles/index.ts
Lines 4267 to 4274 in 5558382
What changes do you think we should make in order to solve the problem?
Increase the line height
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
N/A
daledah commentedon Mar 11, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Hyperlink underline is blocked by inline code in the task report.
What is the root cause of that problem?
We're using
lineHeight: 23pxApp/src/styles/index.ts
Lines 4267 to 4274 in 5558382
but the height of each child is 27px so they're overlapped
What changes do you think we should make in order to solve the problem?
We shouldn't use lineHeight, then it'll apply the
lineHeightfrom parent, in this case it's 28px. We also can removelineHeightintaskTitleMenuItemItalicWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
UI issue
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
14 remaining items
[-]Web - Task - Hyperlink underline is blocked by inline code in the task report[/-][+][Due for payment 2025-04-07] Web - Task - Hyperlink underline is blocked by inline code in the task report[/+]melvin-bot commentedon Mar 31, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 31, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.20-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-04-07. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 31, 2025
@mananjadhav @MitchExpensify @mananjadhav The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
mananjadhav commentedon Mar 31, 2025
Linked PR was deployed to production. Payout should be handled in the original issue. #53175
MitchExpensify commentedon Apr 2, 2025
@mananjadhav, and even if payment is handled there, there are no new BZ steps needed here, right? I think we can close if "yes"
mananjadhav commentedon Apr 2, 2025
Yes we can close this one.
melvin-bot commentedon Apr 7, 2025
Payment Summary
Upwork Job
BugZero Checklist (@MitchExpensify)