You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-04-08] [$250] Book travel - No green button to dismiss the RHP after upgrading workspace #58182
Version Number: 9.1.11-1 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):applausetester+ps309@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.3 / Chrome App Component: Other
What changes do you think we should make in order to solve the problem?
We should wrap the ConfirmationPage in a ScrollView or add styles to View to be able to scroll down
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Book travel - No green button to dismiss the RHP after upgrading workspace[/-][+][$250] Book travel - No green button to dismiss the RHP after upgrading workspace[/+]on Mar 14, 2025
changed the title [-][$250] Book travel - No green button to dismiss the RHP after upgrading workspace[/-][+][Due for payment 2025-04-08] [$250] Book travel - No green button to dismiss the RHP after upgrading workspace[/+]on Apr 1, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.21-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@rushatgabhane@sonialiap@rushatgabhane The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not critical
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Mar 11, 2025
Triggered auto assignment to @sonialiap (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nkdengineer commentedon Mar 11, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
There is no green button to dismiss the RHP.
What is the root cause of that problem?
shouldShowButtonhere istruewhich means we are still rendering the confirm button but we cannot scroll downApp/src/components/ConfirmationPage.tsx
Lines 83 to 94 in 76140d4
What changes do you think we should make in order to solve the problem?
We should wrap the
ConfirmationPagein aScrollViewor add styles toViewto be able to scroll downWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Shahidullah-Muffakir commentedon Mar 11, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-03-19 00:54:24 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Got it, thanks, button is not showing in the confirmation page of workspace upgrade
What is the root cause of that problem?
The
UpgradeConfirmationis not wrapped in the :preventing the content from expanding properly.
like the way it is done, here and here
What changes do you think we should make in order to solve the problem?
Wrap the
UpgradeConfirmationwith :here:
App/src/pages/Travel/TravelUpgrade.tsx
Line 68 in 0463d6d
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
we can use
ScreenWrapperwithshouldEnableMaxHeighthere instead of view:App/src/components/ConfirmationPage.tsx
Lines 63 to 64 in 76140d4
Screen.Recording.2025-03-11.at.2.10.13.PM.mov
melvin-bot commentedon Mar 14, 2025
@sonialiap Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
[-]Book travel - No green button to dismiss the RHP after upgrading workspace[/-][+][$250] Book travel - No green button to dismiss the RHP after upgrading workspace[/+]melvin-bot commentedon Mar 14, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021900519768679969093
melvin-bot commentedon Mar 14, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (
External)29 remaining items
[-][$250] Book travel - No green button to dismiss the RHP after upgrading workspace[/-][+][Due for payment 2025-04-08] [$250] Book travel - No green button to dismiss the RHP after upgrading workspace[/+]melvin-bot commentedon Apr 1, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 1, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.21-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-04-08. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 1, 2025
@rushatgabhane @sonialiap @rushatgabhane The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
rushatgabhane commentedon Apr 2, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/53753/files#r2025768425
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not critical
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/488691
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
melvin-bot commentedon Apr 8, 2025
Payment Summary
Upwork Job
BugZero Checklist (@sonialiap)
sonialiap commentedon Apr 8, 2025
Payment summary:
garrettmknight commentedon Apr 10, 2025
$250 approved for @rushatgabhane