Skip to content

[Due for payment 2025-04-08] [$250] Book travel - No green button to dismiss the RHP after upgrading workspace #58182

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.11-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+ps309@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Other

Action Performed:

Precondition:

  • Account has no workspace.
  1. Go to staging.new.expensify.com
  2. Log in with Expensifail account.
  3. Click FAB > Book travel.
  4. Click Book travel.
  5. Click Upgrade.

Expected Result:

There will be a green button to dismiss the RHP.

Actual Result:

There is no green button to dismiss the RHP.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6766883_1741660434074.20250311_103046.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021900519768679969093
  • Upwork Job ID: 1900519768679969093
  • Last Price Increase: 2025-03-14
Issue OwnerCurrent Issue Owner: @sonialiap

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 11, 2025
  2. melvin-bot commented on Mar 11, 2025

    @melvin-bot

    Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. nkdengineer commented on Mar 11, 2025

    @nkdengineer
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    There is no green button to dismiss the RHP.

    What is the root cause of that problem?

    shouldShowButton here is true which means we are still rendering the confirm button but we cannot scroll down

    {shouldShowButton && (
    <FixedFooter>
    <Button
    success
    large
    text={buttonText}
    testID="confirmation-button"
    style={styles.mt6}
    pressOnEnter
    onPress={onButtonPress}
    />
    </FixedFooter>

    What changes do you think we should make in order to solve the problem?

    We should wrap the ConfirmationPage in a ScrollView or add styles to View to be able to scroll down

    Image

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. Shahidullah-Muffakir commented on Mar 11, 2025

    @Shahidullah-Muffakir
    Contributor

    🚨 Edited by proposal-police: This proposal was edited at 2025-03-19 00:54:24 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Got it, thanks, button is not showing in the confirmation page of workspace upgrade

    What is the root cause of that problem?

    The UpgradeConfirmation is not wrapped in the :

                <ScrollView contentContainerStyle={styles.flexGrow1}>

    preventing the content from expanding properly.
    like the way it is done, here and here

    What changes do you think we should make in order to solve the problem?

    Wrap the UpgradeConfirmation with :

                <ScrollView contentContainerStyle={styles.flexGrow1}>

    here:

    <UpgradeConfirmation

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    NA

    What alternative solutions did you explore? (Optional)

    we can use ScreenWrapper with shouldEnableMaxHeight here instead of view:

    <View style={containerStyle}>
    <View style={[styles.screenCenteredContainer, styles.alignItemsCenter]}>

    Screen.Recording.2025-03-11.at.2.10.13.PM.mov
  5. melvin-bot commented on Mar 14, 2025

    @melvin-bot

    @sonialiap Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 14, 2025
  7. changed the title [-]Book travel - No green button to dismiss the RHP after upgrading workspace[/-] [+][$250] Book travel - No green button to dismiss the RHP after upgrading workspace[/+] on Mar 14, 2025
  8. melvin-bot commented on Mar 14, 2025

    @melvin-bot
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 14, 2025
  10. melvin-bot commented on Mar 14, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

  11. 29 remaining items

  12. changed the title [-][$250] Book travel - No green button to dismiss the RHP after upgrading workspace[/-] [+][Due for payment 2025-04-08] [$250] Book travel - No green button to dismiss the RHP after upgrading workspace[/+] on Apr 1, 2025
  13. melvin-bot commented on Apr 1, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Apr 1, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.21-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-04-08. 🎊

    For reference, here are some details about the assignees on this issue:

  15. melvin-bot commented on Apr 1, 2025

    @melvin-bot

    @rushatgabhane @sonialiap @rushatgabhane The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  16. rushatgabhane commented on Apr 2, 2025

    @rushatgabhane
    Member

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/53753/files#r2025768425

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: Not critical

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template

    Regression Test Proposal

    Precondition:

    Test:

    1. Log in with a new account.
    2. Click FAB > Book Travel.
    3. Click Book Travel.
    4. Click Upgrade.
    5. Click Confirm.
    6. Verify the "Got it, Thanks" Green button is visible.

    Do we agree 👍 or 👎

  17. melvin-bot commented on Apr 8, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@sonialiap)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1900519768679969093/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  18. sonialiap commented on Apr 8, 2025

    @sonialiap
    Contributor

    Payment summary:

  19. garrettmknight commented on Apr 10, 2025

    @garrettmknight
    Contributor

    $250 approved for @rushatgabhane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions