Skip to content

[$250] LHN-LHN message previews include WS name after creating the second workspace #58186

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.1.11-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #57911
Email or phone of affected tester (no customers): testpayment935+5dgs@gmail.com
Issue reported by: Applause Internal Team
Device used: Windows 10 / Chrome, Samsung s10/ Chrome, Samsung s10/ Android 12
App Component: Left Hand Navigation (LHN)

Action Performed:

  1. Navigate to https://staging.new.expensify.com
  2. Log in with new Account and create 1 WS (Important step)
  3. Navigate to admin room of a workspace
  4. Send a message (Eg. HI)
  5. Observe the LHN
  6. Notice their is only "you: HI" in preview(LHN)
  7. Create another WS
  8. Navigate back to the LHN and notice step 7 Preview now add WS name

Expected Result:

LHN preview should contain the WS name in the admin room without expecting other WS addition.

Actual Result:

LHN preview contain the WS name in the admin room only when other WS created.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6766886_1741660998032.Screen_Recording_20250311_052143_Chrome.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021899731094514102598
  • Upwork Job ID: 1899731094514102598
  • Last Price Increase: 2025-04-02
Issue OwnerCurrent Issue Owner: @ZhenjaHorbach

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 11, 2025
  2. melvin-bot commented on Mar 11, 2025

    @melvin-bot

    Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. daledah commented on Mar 11, 2025

    @daledah
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    LHN preview contain the WS name in the admin room only when other WS created.

    What is the root cause of that problem?

    we are checking if there are less than 2 workspaces we'll return prefix as ''

    App/src/libs/ReportUtils.ts

    Lines 4600 to 4603 in 76140d4

    const filteredPolicies = Object.values(allPolicies ?? {}).filter((policy) => shouldShowPolicy(policy, false, currentUserEmail));
    if (filteredPolicies.length < 2) {
    return '';
    }

    What changes do you think we should make in order to solve the problem?

    We should remove this condition

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    Add tests for the function getReportSubtitlePrefix to confirm that if we have one workspace we need to return prefix

    What alternative solutions did you explore? (Optional)

    NA

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 12, 2025
  5. melvin-bot commented on Mar 12, 2025

    @melvin-bot
  6. changed the title [-]LHN-LHN message previews include WS name after creating the second workspace[/-] [+][$250] LHN-LHN message previews include WS name after creating the second workspace[/+] on Mar 12, 2025
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 12, 2025
  8. melvin-bot commented on Mar 12, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

  9. ZhenjaHorbach commented on Mar 12, 2025

    @ZhenjaHorbach
    Contributor

    @daledah
    Thanks for your proposal !

    Your proposal makes sense to me !
    🎀👀🎀 C+ reviewed

  10. melvin-bot commented on Mar 12, 2025

    @melvin-bot

    Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  11. FitseTLT commented on Mar 13, 2025

    @FitseTLT
    Contributor

    This is intentional

  12. 3 remaining items

  13. melvin-bot commented on Mar 19, 2025

    @melvin-bot

    @ZhenjaHorbach 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  14. melvin-bot commented on Mar 19, 2025

    @melvin-bot

    📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

  15. thienlnam commented on Mar 20, 2025

    @thienlnam
    Contributor
  16. melvin-bot commented on Mar 21, 2025

    @melvin-bot

    @ZhenjaHorbach Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

  17. melvin-bot commented on Mar 25, 2025

    @melvin-bot

    @thienlnam @dylanexpensify @ZhenjaHorbach this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  18. melvin-bot commented on Mar 25, 2025

    @melvin-bot

    @ZhenjaHorbach 12 days overdue. Walking. Toward. The. Light...

  19. dylanexpensify commented on Mar 25, 2025

    @dylanexpensify
    Contributor
  20. melvin-bot commented on Mar 26, 2025

    @melvin-bot

    📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

  21. melvin-bot commented on Mar 28, 2025

    @melvin-bot

    This issue has not been updated in over 14 days. @thienlnam, @dylanexpensify, @ZhenjaHorbach eroding to Weekly issue.

  22. melvin-bot commented on Apr 2, 2025

    @melvin-bot

    📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

  23. thienlnam commented on Apr 3, 2025

    @thienlnam
    Contributor

    Let's just close this for now - if it's needed in another migration we can re-create it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions