Skip to content

[Due for payment 2025-04-14] Android - 2FA - After enabling 2FA Inbox becomes empty #58232

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.11-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #50251
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy A12 / Android 13
App Component: User Settings

Action Performed:

  1. [User A] Connect Xero to a WS
  2. [User A] Invite User B to WS as an admin
  3. [User B] Sign in into the app
  4. [User B] Verify a prompt to enable 2FA is shown
  5. [User B] Press on Enable two-factor authentication
  6. [User B] Verify you are not promoted to validate the account

Expected Result:

At step 4, a half screen prompt with "Please enable two-factor authentication" is shown
After step 5, user can access the account

Actual Result:

At step 4, Two Factor Authentication page is shown
After step 5, the inbox is empty, WS is not shown, and the user avatar has a skeleton loader

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6767310_1741691685558.1741689731757_74b68cc2-1d8d-42fe-9ed1-dd240fe78994.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @MitchExpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 11, 2025
  2. melvin-bot commented on Mar 11, 2025

    @melvin-bot

    Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. MitchExpensify commented on Mar 14, 2025

    @MitchExpensify
    Contributor

    @francoisl do you know what is expected behavior here?

  4. francoisl commented on Mar 14, 2025

    @francoisl
    Contributor

    Sounds similar to what's being discussed and worked on here? https://expensify.slack.com/archives/C01GTK53T8Q/p1740136190872499

  5. melvin-bot commented on Mar 17, 2025

    @melvin-bot

    @MitchExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  6. MitchExpensify commented on Mar 18, 2025

    @MitchExpensify
    Contributor

    @trjExpensify should I close this in favor of #48208?

  7. trjExpensify commented on Mar 18, 2025

    @trjExpensify
    Contributor

    I'm confused. Why is this user in the OP in the OldApp experience Inbox and then put into NewDot right after? 🤔 What was their tryNewDot NVP status? Were they invited to the workspace via OldDot or NewDot? It would be good if you could repro this and get more info on the account/invite conditions.

    CC: @bernhardoj @dukenv0307 @Beamanator for vis too. For our NewDot improvements, the PR here is merged awaiting a deploy.

  8. bernhardoj commented on Mar 18, 2025

    @bernhardoj
    Contributor

    I don't have access to the HybridApp. It could possibly happen because of the BE bug.

  9. trjExpensify commented on Mar 19, 2025

    @trjExpensify
    Contributor

    What BE bug?

  10. bernhardoj commented on Mar 19, 2025

    @bernhardoj
    Contributor

    The BE bug that we previously experienced in #48208. Not sure though, we need to see the network calls and the console log whether the API result is being ignored or not.

  11. trjExpensify commented on Mar 19, 2025

    @trjExpensify
    Contributor

    @IuliiaHerets can you get the answers to these questions please, and ask for a retest supplied with the email address? Thanks!

  12. 37 remaining items

  13. melvin-bot commented on Apr 7, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.23-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-04-14. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on Apr 7, 2025

    @melvin-bot

    @lakchote @MitchExpensify @mateuuszzzzz The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. removed their assignment
    on Apr 8, 2025
  16. added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 8, 2025
  17. melvin-bot commented on Apr 8, 2025

    @melvin-bot

    Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  18. MitchExpensify commented on Apr 8, 2025

    @MitchExpensify
    Contributor

    It looks like there are no remaining steps here - Do we need to add new QA tests @lakchote ?

  19. lakchote commented on Apr 9, 2025

    @lakchote
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    Do we agree 👍 or 👎

  20. lakchote commented on Apr 9, 2025

    @lakchote
    Contributor

    It looks like there are no remaining steps here - Do we need to add new QA tests @lakchote ?

    I think so yes @MitchExpensify as the impact is substantial. I've created an issue here.

    @mateuuszzzzz could you please complete the BugZero checklist?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions