You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-04-23] Onboarding - Completed task does not show strikethrough style #58265
Version Number: 9.1.11-4 Reproducible in staging?: Yes Reproducible in production?: No If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):sjodismosdjosdj@gmail.com Issue reported by: Applause Internal Team Device used: Mac 15.3 / Chrome App Component: Other
Action Performed:
Go to staging.new.expensify.com
Sign up with a new Gmail account.
Select "Manage my team's expenses" (important).
Select 1-10 employees.
Select any accounting software > Complete the onboarding.
Go to #admins.
Mark any task complete.
Expected Result:
The completed task will show strikethrough style (production behavior).
Actual Result:
The completed task does not show strikethrough style.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
🚨 Heads up! I'll be offline until Monday, April 7, 2025, and won’t be actively monitoring this GitHub during that time.
If this GitHub requires an urgent update, please reapply the bug label or reach out in the #expensify-open-source Slack room for help. Otherwise, I'll pick things up when I'm back online. Thanks!
changed the title [-]Onboarding - Completed task does not show strikethrough style[/-][+][Due for payment 2025-04-23] Onboarding - Completed task does not show strikethrough style[/+]on Apr 16, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.28-15-staging and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@mananjadhav@alexpensify@mananjadhav The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Mar 12, 2025
Triggered auto assignment to @MariaHCD (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Mar 12, 2025
Triggered auto assignment to @alexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Mar 12, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Mar 12, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Kalydosos commentedon Mar 12, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-03-12 10:27:00 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Onboarding - Completed task does not show strikethrough style
What is the root cause of that problem?
Some changes occured in PR #54165 have removed the completed task style from the code
What changes do you think we should make in order to solve the problem?
We should consider the completion status of the task when rendering its style here from
App/src/components/ReportActionItem/TaskPreview.tsx
Line 130 in 7fdcb2c
to
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
jjcoffee commentedon Mar 12, 2025
cc @Krishna2323 @mananjadhav
Krishna2323 commentedon Mar 12, 2025
Thanks @jjcoffee, @MariaHCD please assign us. It's a regression from our PR.
13 remaining items
alexpensify commentedon Mar 28, 2025
@mananjadhav - we are almost there! It looks like #58555 is in Staging.
🚨 Heads up! I'll be offline until Monday, April 7, 2025, and won’t be actively monitoring this GitHub during that time.
If this GitHub requires an urgent update, please reapply the
buglabel or reach out in the#expensify-open-sourceSlack room for help. Otherwise, I'll pick things up when I'm back online. Thanks!mananjadhav commentedon Apr 15, 2025
@alexpensify I think we are good to close this one. The payout will be handled in the original issue.
alexpensify commentedon Apr 15, 2025
Thanks for the update!
[-]Onboarding - Completed task does not show strikethrough style[/-][+][Due for payment 2025-04-23] Onboarding - Completed task does not show strikethrough style[/+]melvin-bot commentedon Apr 16, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 16, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.28-15-staging and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-04-23. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 16, 2025
@mananjadhav @alexpensify @mananjadhav The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]