Skip to content

[Due for payment 2025-04-23] Onboarding - Completed task does not show strikethrough style #58265

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.11-4
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): sjodismosdjosdj@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Other

Action Performed:

  1. Go to staging.new.expensify.com
  2. Sign up with a new Gmail account.
  3. Select "Manage my team's expenses" (important).
  4. Select 1-10 employees.
  5. Select any accounting software > Complete the onboarding.
  6. Go to #admins.
  7. Mark any task complete.

Expected Result:

The completed task will show strikethrough style (production behavior).

Actual Result:

The completed task does not show strikethrough style.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Bug6768319_1741763533449.onboarding_task.mp4
Issue OwnerCurrent Issue Owner: @alexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerCashThis issue or pull request should block deployment
    on Mar 12, 2025
  2. melvin-bot commented on Mar 12, 2025

    @melvin-bot

    Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Mar 12, 2025

    @melvin-bot

    Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Mar 12, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Mar 12, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. Kalydosos commented on Mar 12, 2025

    @Kalydosos
    Contributor

    🚨 Edited by proposal-police: This proposal was edited at 2025-03-12 10:27:00 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Onboarding - Completed task does not show strikethrough style

    What is the root cause of that problem?

    Some changes occured in PR #54165 have removed the completed task style from the code

    const titleStyle = StyleUtils.getTaskPreviewTitleStyle(iconWrapperStyle.height, isTaskCompleted);

    What changes do you think we should make in order to solve the problem?

    We should consider the completion status of the task when rendering its style here from

    <RenderHTML html={`<comment>${taskReport?.reportName ?? action?.childReportName ?? ''}</comment>`} />

    to

    <View style={[styles.alignSelfCenter, styles.flex1]}>
    {isTaskCompleted && <RenderHTML html={<comment><s>${taskReport?.reportName ?? action?.childReportName ?? ''}</s></comment>} />}
    {!isTaskCompleted && <RenderHTML html={<comment>${taskReport?.reportName ?? action?.childReportName ?? ''}</comment>} />}

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None

  7. jjcoffee commented on Mar 12, 2025

    @jjcoffee
    Contributor
  8. Krishna2323 commented on Mar 12, 2025

    @Krishna2323
    Contributor

    Thanks @jjcoffee, @MariaHCD please assign us. It's a regression from our PR.

  9. 13 remaining items

  10. alexpensify commented on Mar 28, 2025

    @alexpensify
    Contributor

    @mananjadhav - we are almost there! It looks like #58555 is in Staging.


    🚨 Heads up! I'll be offline until Monday, April 7, 2025, and won’t be actively monitoring this GitHub during that time.

    If this GitHub requires an urgent update, please reapply the bug label or reach out in the #expensify-open-source Slack room for help. Otherwise, I'll pick things up when I'm back online. Thanks!

  11. mananjadhav commented on Apr 15, 2025

    @mananjadhav
    Collaborator

    @alexpensify I think we are good to close this one. The payout will be handled in the original issue.

  12. alexpensify commented on Apr 15, 2025

    @alexpensify
    Contributor

    Thanks for the update!

  13. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Apr 16, 2025
  14. changed the title [-]Onboarding - Completed task does not show strikethrough style[/-] [+][Due for payment 2025-04-23] Onboarding - Completed task does not show strikethrough style[/+] on Apr 16, 2025
  15. melvin-bot commented on Apr 16, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  16. melvin-bot commented on Apr 16, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.28-15-staging and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-04-23. 🎊

    For reference, here are some details about the assignees on this issue:

    • @mananjadhav requires payment through NewDot Manual Requests
    • @Krishna2323 requires payment (Needs manual offer from BZ)
  17. melvin-bot commented on Apr 16, 2025

    @melvin-bot

    @mananjadhav @alexpensify @mananjadhav The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions