Skip to content

[Due for payment 2025-04-07] Android - Onboarding - Task name briefly changes to "Chat Report" in Concierge chat #58269

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: V9.1.11-4
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N
Email or phone of affected tester (no customers): Slottwo1+nejeuej@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13
App Component: Other

Action Performed:

  1. Go to https://staging.new.expensify.com/home
  2. Log in using a new Gmail account
  3. Select the following options during onboarding:
    “Manage my team’s expenses”
    “1-10 employees”
    “None”
  4. Complete the onboarding flow & validate the account (login again using magic code in mweb)
  5. Login in with same account in android app
  6. Open the Concierge chat
  7. Tap on any task in the chat
  8. Observe the task name change briefly

Expected Result:

The task name should remain unchanged when tapped.

Actual Result:

The task name briefly changes to "Chat Report" before reverting.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6768323_1741764501575.Screenrecorder-2025-03-12-12-53-57-120.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @jliexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 12, 2025
  2. melvin-bot commented on Mar 12, 2025

    @melvin-bot

    Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. added
    DeployBlockerCashThis issue or pull request should block deployment
    and removed on Mar 12, 2025
  4. melvin-bot commented on Mar 12, 2025

    @melvin-bot

    Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  5. melvin-bot commented on Mar 12, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. github-actions commented on Mar 12, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  7. linhvovan29546 commented on Mar 12, 2025

    @linhvovan29546
    Contributor

    @Krishna2323 This is a regression caused by your PR

  8. Krishna2323 commented on Mar 12, 2025

    @Krishna2323
    Contributor

    @linhvovan29546 thanks. @nkuoch please assign me.

  9. daledah commented on Mar 12, 2025

    @daledah
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The task name briefly changes to "Chat Report" before reverting.

    What is the root cause of that problem?

    This is not a regression from #54165, but actually a bug that only got caught after #54165 is merged.

    In task preview, we set the task name as:

    <RenderHTML html={`<comment>${taskReport?.reportName ?? action?.childReportName ?? ''}</comment>`} />

    With taskReport?.reportName being first, then fallback to action?.childReportName.

    Initially taskReport is not yet on Onyx, so action?.childReportName is shown.

    When clicking on a task report that is not yet on Onyx, we start calling OpenReport. One of the optimistic data is:

    reportName: allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${reportID}`]?.reportName ?? CONST.REPORT.DEFAULT_REPORT_NAME,

    This makes taskReport?.reportName exists as Chat report, so the task name appears as Chat report very shortly.

    What changes do you think we should make in order to solve the problem?

    We should prioritize action?.childReportName first in this case.

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  10. 17 remaining items

  11. melvin-bot commented on Mar 31, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Mar 31, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.20-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-04-07. 🎊

    For reference, here are some details about the assignees on this issue:

    • @mananjadhav requires payment through NewDot Manual Requests
    • @Krishna2323 requires payment (Needs manual offer from BZ)
  13. melvin-bot commented on Mar 31, 2025

    @melvin-bot

    @mananjadhav @jliexpensify @mananjadhav The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. mananjadhav commented on Mar 31, 2025

    @mananjadhav
    Collaborator

    Linked PR was deployed to production few hours ago.

  15. jliexpensify commented on Apr 7, 2025

    @jliexpensify
    Contributor

    Bumping @mananjadhav for a checklist

  16. jliexpensify commented on Apr 7, 2025

    @jliexpensify
    Contributor

    Payment Summary

  17. melvin-bot commented on Apr 7, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@jliexpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  18. jliexpensify commented on Apr 8, 2025

    @jliexpensify
    Contributor
  19. Krishna2323 commented on Apr 8, 2025

    @Krishna2323
    Contributor

    @jliexpensify, I think @mananjadhav also doesn't require any payment for this task, as he was the author of the regression-causing PR. Please correct me if there's a different rule for C+.

  20. jliexpensify commented on Apr 8, 2025

    @jliexpensify
    Contributor

    Oh right - that makes sense! Apologies - I thought he was assigned to review separately, I didn't realise he was the initial C+ for the regression.

  21. jliexpensify commented on Apr 8, 2025

    @jliexpensify
    Contributor

    I'll close this out then - I don't believe we need a checklist as it's a regression, but please correct me if I'm wrong!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions