You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-04-07] Android - Onboarding - Task name briefly changes to "Chat Report" in Concierge chat #58269
Version Number: V9.1.11-4 Reproducible in staging?: Yes Reproducible in production?: No If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both If this was caught during regression testing, add the test name, ID and link from TestRail: N Email or phone of affected tester (no customers):Slottwo1+nejeuej@gmail.com Issue reported by: Applause Internal Team Device used: Redminote 10s android 13 App Component: Other
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
This makes taskReport?.reportName exists as Chat report, so the task name appears as Chat report very shortly.
What changes do you think we should make in order to solve the problem?
We should prioritize action?.childReportName first in this case.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.20-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@mananjadhav@jliexpensify@mananjadhav The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
@jliexpensify, I think @mananjadhav also doesn't require any payment for this task, as he was the author of the regression-causing PR. Please correct me if there's a different rule for C+.
Activity
melvin-bot commentedon Mar 12, 2025
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Mar 12, 2025
Triggered auto assignment to @nkuoch (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Mar 12, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Mar 12, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
linhvovan29546 commentedon Mar 12, 2025
@Krishna2323 This is a regression caused by your PR
Krishna2323 commentedon Mar 12, 2025
@linhvovan29546 thanks. @nkuoch please assign me.
daledah commentedon Mar 12, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
The task name briefly changes to "Chat Report" before reverting.
What is the root cause of that problem?
This is not a regression from #54165, but actually a bug that only got caught after #54165 is merged.
In task preview, we set the task name as:
App/src/components/ReportActionItem/TaskPreview.tsx
Line 130 in 16d64f1
With
taskReport?.reportNamebeing first, then fallback toaction?.childReportName.Initially
taskReportis not yet on Onyx, soaction?.childReportNameis shown.When clicking on a task report that is not yet on Onyx, we start calling
OpenReport. One of the optimistic data is:App/src/libs/actions/Report.ts
Line 868 in 16d64f1
This makes
taskReport?.reportNameexists asChat report, so the task name appears asChat reportvery shortly.What changes do you think we should make in order to solve the problem?
We should prioritize
action?.childReportNamefirst in this case.What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
17 remaining items
melvin-bot commentedon Mar 31, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 31, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.20-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-04-07. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 31, 2025
@mananjadhav @jliexpensify @mananjadhav The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
mananjadhav commentedon Mar 31, 2025
Linked PR was deployed to production few hours ago.
jliexpensify commentedon Apr 7, 2025
Bumping @mananjadhav for a checklist
jliexpensify commentedon Apr 7, 2025
Payment Summary
melvin-bot commentedon Apr 7, 2025
Payment Summary
Upwork Job
BugZero Checklist (@jliexpensify)
jliexpensify commentedon Apr 8, 2025
Bump @mananjadhav for the checklist!
@Krishna2323 is this summary correct?
Krishna2323 commentedon Apr 8, 2025
@jliexpensify, I think @mananjadhav also doesn't require any payment for this task, as he was the author of the regression-causing PR. Please correct me if there's a different rule for C+.
jliexpensify commentedon Apr 8, 2025
Oh right - that makes sense! Apologies - I thought he was assigned to review separately, I didn't realise he was the initial C+ for the regression.
jliexpensify commentedon Apr 8, 2025
I'll close this out then - I don't believe we need a checklist as it's a regression, but please correct me if I'm wrong!