You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-03-31] [$500][HIGH] Hybrid - Green/red dot on 'Inbox' disappear after close and open the app again. #58322
Version Number: v9.1.12-2 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):testexpensify9+00008@gmail.com Issue reported by: Applause Internal Team Device used: Samsung A15, Android 14 | iPhone SE 3rd generation (2022), iOS 18.3.1 App Component: Other
Action Performed:
Open Hybrid app
Loggin
Close the app & open it again
Tap on 'Reports' (the green/red dot is shown on 'Inbox' button)
Tap on 'Settings'
Expected Result:
The green/red button should be displayed
Actual Result:
The green/red button is not shown (Until the user opens any expense that has a pending action).
However, the policyReports contains undefined collection. orderedReportIDs contains valid reportID values, but when retrieving it from reportsCollection, we get undefined. It's because the reportsCollection isn't available yet.
changed the title [-]Hybrid - Green/red dot on 'Inbox' disappear after close and open the app again.[/-][+][$250] Hybrid - Green/red dot on 'Inbox' disappear after close and open the app again.[/+]on Mar 13, 2025
changed the title [-][$250] Hybrid - Green/red dot on 'Inbox' disappear after close and open the app again.[/-][+][$250][HIGH] Hybrid - Green/red dot on 'Inbox' disappear after close and open the app again.[/+]on Mar 13, 2025
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Have an outstanding action on a report (money request, task, errors, etc.). As an example, this can be an error asking for receipt upload.
Activity
melvin-bot commentedon Mar 12, 2025
Triggered auto assignment to @NicMendonca (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.bernhardoj commentedon Mar 13, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
The GBR doesn'st show on Home tab bottom tab icon.
What is the root cause of that problem?
The GBR will show if
getChatTabBrickRoadreturnsinfo.App/src/components/Navigation/BottomTabBar/index.tsx
Lines 60 to 61 in 2496dfa
But in our case, it's undefined. It gets the value by iterating over all report that is shown in LHN and check if a report has GBR or not.
App/src/libs/WorkspacesSettingsUtils.ts
Lines 143 to 166 in 2496dfa
However, the
policyReportscontains undefined collection.orderedReportIDscontains valid reportID values, but when retrieving it fromreportsCollection, we get undefined. It's because thereportsCollectionisn't available yet.App/src/libs/WorkspacesSettingsUtils.ts
Lines 41 to 48 in 2496dfa
It has the same root cause as #56158 (comment).
What changes do you think we should make in order to solve the problem?
I will propose the same main solution as #56158 (comment).
Instead of passing the list of reportIDs, we can directly pass the list of reports.
We won't need the
allReportsanymore because we will use the report collection from the param.App/src/libs/WorkspacesSettingsUtils.ts
Lines 138 to 145 in 2496dfa
For the alternative solution, it's the same as the other issue I linked above.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
[-]Hybrid - Green/red dot on 'Inbox' disappear after close and open the app again.[/-][+][$250] Hybrid - Green/red dot on 'Inbox' disappear after close and open the app again.[/+]melvin-bot commentedon Mar 13, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021900188126174179653
melvin-bot commentedon Mar 13, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (
External)[-][$250] Hybrid - Green/red dot on 'Inbox' disappear after close and open the app again.[/-][+][$250][HIGH] Hybrid - Green/red dot on 'Inbox' disappear after close and open the app again.[/+]mallenexpensify commentedon Mar 13, 2025
Added status of HIGH cuz I suspect this affects most-all users (even though I never look at the dots at the bottom of the app)
27 remaining items
melvin-bot commentedon Mar 31, 2025
Payment Summary
Upwork Job
BugZero Checklist (@NicMendonca)
bernhardoj commentedon Mar 31, 2025
Requested in ND.
NicMendonca commentedon Mar 31, 2025
@allroundexperts bump on the checklist please!
NicMendonca commentedon Mar 31, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
melvin-bot commentedon Apr 3, 2025
@allroundexperts Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
allroundexperts commentedon Apr 3, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/53852/files#r2026553073
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Verify there is a GBR/RBR on the inbox bottom tab
Do we agree 👍 or 👎
NicMendonca commentedon Apr 4, 2025
Payment Summary
JmillsExpensify commentedon Apr 9, 2025
$250 approved for @bernhardoj
JmillsExpensify commentedon Jun 13, 2025
$250 approved for @allroundexperts