You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-04-07] [$250] Update the Billing toggle in Tags to display the billable setting on Collect workspaces #58587
changed the title [-]Update the Billing toggle in Tags to display the billable setting on Collect workspaces[/-][+][$250] Update the Billing toggle in Tags to display the billable setting on Collect workspaces[/+]on Mar 18, 2025
changed the title [-][$250] Update the Billing toggle in Tags to display the billable setting on Collect workspaces[/-][+][Due for payment 2025-04-07] [$250] Update the Billing toggle in Tags to display the billable setting on Collect workspaces[/+]on Mar 31, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.20-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@dominictb] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
[@flaviadefaria] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other: Feature update
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other: Feature update
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: NA - Feature update
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
FitseTLT commentedon Mar 17, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Update the Billing toggle in Tags to display the billable setting on Collect workspaces
What is the root cause of that problem?
We only show billable if rules are enabled here
App/src/pages/workspace/tags/WorkspaceTagsSettingsPage.tsx
Line 107 in 61a1941
What changes do you think we should make in order to solve the problem?
Remove the condition
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N / A -
What alternative solutions did you explore? (Optional)
melvin-bot commentedon Mar 18, 2025
Current assignee @flaviadefaria is eligible for the NewFeature assigner, not assigning anyone new.
[-]Update the Billing toggle in Tags to display the billable setting on Collect workspaces[/-][+][$250] Update the Billing toggle in Tags to display the billable setting on Collect workspaces[/+]melvin-bot commentedon Mar 18, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021902032041220745988
melvin-bot commentedon Mar 18, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @dominictb (
External)17 remaining items
[-][$250] Update the Billing toggle in Tags to display the billable setting on Collect workspaces[/-][+][Due for payment 2025-04-07] [$250] Update the Billing toggle in Tags to display the billable setting on Collect workspaces[/+]melvin-bot commentedon Mar 31, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 31, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.20-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-04-07. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Mar 31, 2025
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
dominictb commentedon Apr 4, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: NA - Feature update
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/488363
Regression Test Proposal
Test:
Do we agree 👍 or 👎
flaviadefaria commentedon Apr 4, 2025
I like it, I'd just add a small tweak to the final step:
dominictb commentedon Apr 4, 2025
Great suggestions! I updated.
flaviadefaria commentedon Apr 7, 2025
Everyone's been paid, so I am closing this.