Skip to content

[Due for payment 2025-04-07] [$250] Update the Billing toggle in Tags to display the billable setting on Collect workspaces #58587

Closed

Description

@flaviadefaria

Coming from this Slack discussion:

Update the Billing toggle in Tags:

  • Don’t require Rules to be enabled to show the billable setting in Tags (since Rules is only available in Control)
  • Show the billable setting on Collect workspaces as well now
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021902032041220745988
  • Upwork Job ID: 1902032041220745988
  • Last Price Increase: 2025-03-18
  • Automatic offers:
    • dominictb | Reviewer | 106583289
    • FitseTLT | Contributor | 106583290
Issue OwnerCurrent Issue Owner: @flaviadefaria

Activity

  1. FitseTLT commented on Mar 17, 2025

    @FitseTLT
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Update the Billing toggle in Tags to display the billable setting on Collect workspaces

    What is the root cause of that problem?

    We only show billable if rules are enabled here

    {!!policy?.areRulesEnabled && (

    What changes do you think we should make in order to solve the problem?

    Remove the condition

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    N / A -

    What alternative solutions did you explore? (Optional)

  2. melvin-bot commented on Mar 18, 2025

    @melvin-bot

    Current assignee @flaviadefaria is eligible for the NewFeature assigner, not assigning anyone new.

  3. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 18, 2025
  4. changed the title [-]Update the Billing toggle in Tags to display the billable setting on Collect workspaces[/-] [+][$250] Update the Billing toggle in Tags to display the billable setting on Collect workspaces[/+] on Mar 18, 2025
  5. melvin-bot commented on Mar 18, 2025

    @melvin-bot
  6. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 18, 2025
  7. melvin-bot commented on Mar 18, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @dominictb (External)

  8. 17 remaining items

  9. changed the title [-][$250] Update the Billing toggle in Tags to display the billable setting on Collect workspaces[/-] [+][Due for payment 2025-04-07] [$250] Update the Billing toggle in Tags to display the billable setting on Collect workspaces[/+] on Mar 31, 2025
  10. melvin-bot commented on Mar 31, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Mar 31, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.20-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-04-07. 🎊

    For reference, here are some details about the assignees on this issue:

  12. melvin-bot commented on Mar 31, 2025

    @melvin-bot

    BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@dominictb] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
    • [@flaviadefaria] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
  13. dominictb commented on Apr 4, 2025

    @dominictb
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other: Feature update

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other: Feature update

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: NA - Feature update

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: NA

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue: https://github.com/Expensify/Expensify/issues/488363

    Regression Test Proposal

    Test:

    1. Create a new collect workspace
    2. Enable tags
    3. Open tags > settings
    4. Switch on track billable expenses
    5. Go to the workspace chat FAB > Create Expense
    6. Verify that the billable toggle is present and disabled by default

    Do we agree 👍 or 👎

  14. flaviadefaria commented on Apr 4, 2025

    @flaviadefaria
    ContributorAuthor

    I like it, I'd just add a small tweak to the final step:

    1. Verify that the billable toggle is present and disabled by default
  15. dominictb commented on Apr 4, 2025

    @dominictb
    Contributor

    Great suggestions! I updated.

  16. flaviadefaria commented on Apr 7, 2025

    @flaviadefaria
    ContributorAuthor

    Everyone's been paid, so I am closing this.

  17. moved this from Second Cohort - HIGH to Done in [#whatsnext] #migrateon Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions