Skip to content

[Due for payment 2025-04-28] [Due for payment 2025-04-17] [Manager McTest] Tooltip Centered Incorrectly #58657

Closed

Description

@grgia

On Web the tooltip is not centered to the RHN and overlaps text:

Image

Image

Issue OwnerCurrent Issue Owner: @OfstadC

Activity

  1. melvin-bot commented on Mar 18, 2025

    @melvin-bot

    Triggered auto assignment to @OfstadC (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

  2. melvin-bot commented on Mar 18, 2025

    @melvin-bot

    ⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

  3. melvin-bot commented on Mar 18, 2025

    @melvin-bot

    Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

  4. shawnborton commented on Mar 18, 2025

    @shawnborton
    Contributor

    Does this happen all the time or just when you resize?

  5. JKobrynski commented on Mar 20, 2025

    @JKobrynski
    Contributor

    Hi, I'm Julian from Callstack - expert agency - and I'd like to work on this issue!

  6. JKobrynski commented on Mar 24, 2025

    @JKobrynski
    Contributor

    Update:

    FYI I'm on sick leave, so I'm out of office today, I will most likely be back on Thursday, but it's possible I will come back sooner, I will keep you posted.

  7. 30 remaining items

  8. melvin-bot commented on Apr 17, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @JKobrynski is from an agency-contributor and not due payment
    • Reviewer: @DylanDylann owed $250 via NewDot

    BugZero Checklist (@OfstadC)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  9. OfstadC commented on Apr 17, 2025

    @OfstadC
    Contributor

    @DylanDylann please complete the BZ checklist so we can issue payment here. Thanks 😃

  10. DylanDylann commented on Apr 17, 2025

    @DylanDylann
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: No need, the author already fixed it

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue: https://github.com/Expensify/Expensify/issues/491952

    Regression Test Proposal

    Test:

    1. Log into the app using a fresh account (to see the onboarding tooltips)
    2. Click on the FAB and select 'Create expense'
    3. You should see a tooltip saying "Want to see how Scan works? Try a test Receipt!"
    4. Resize the browser window
    5. Verify the tooltip disappears as soon as you start resizing and reappears in a right place when you finish resizing the window
    6. Resize to a narrow window, so the small screen wariant renders and make sure the tooltip position is right and it doesn't overlap the text

    Do we agree 👍 or 👎

  11. OfstadC commented on Apr 17, 2025

    @OfstadC
    Contributor

    Thanks!

    Payment Summary is accurate

  12. changed the title [-][Due for payment 2025-04-17] [Manager McTest] Tooltip Centered Incorrectly[/-] [+][Due for payment 2025-04-28] [Due for payment 2025-04-17] [Manager McTest] Tooltip Centered Incorrectly[/+] on Apr 21, 2025
  13. melvin-bot commented on Apr 21, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Apr 21, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.30-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-04-28. 🎊

    For reference, here are some details about the assignees on this issue:

  15. melvin-bot commented on Apr 21, 2025

    @melvin-bot

    BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@DylanDylann] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
    • [@OfstadC] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
  16. DylanDylann commented on May 30, 2025

    @DylanDylann
    Contributor

    Reviewer: @DylanDylann owed $250 via NewDot

    @OfstadC I was assigned to this issue before being eligible for NewDot payment. So I should be paid via Upwork.

  17. OfstadC commented on Jul 8, 2025

    @OfstadC
    Contributor

    Chatting in Slack with @DylanDylann

  18. OfstadC commented on Jul 10, 2025

    @OfstadC
    Contributor

    Updated Payment Summary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionNewFeatureSomething to build that is a new item.WeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions