Skip to content

Help Panel - Help panel opens when screen is changed to wide #58823

Closed

Description

@vincdargento

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue was found while executing QA for PR #58576

Version Number: v9.1.16-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #58576
Email or phone of affected tester (no customers): applausetester+ds@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 14.5/ Chrome
App Component: Other

Action Performed:

Precondition:

  • Run Onyx.set('nvp_sidePanel', {}) in console.
  1. Go to staging.new.expensify.com > Login
  2. On an narrow screen open Help panel and close it
  3. Make the screen wide

Expected Result:

Help panel is not shown when Making the screen wide

Actual Result:

Help panel is shown when Making the screen wide

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerCashThis issue or pull request should block deployment
    on Mar 20, 2025
  2. melvin-bot commented on Mar 20, 2025

    @melvin-bot

    Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Mar 20, 2025

    @melvin-bot

    Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Mar 20, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Mar 20, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. vincdargento commented on Mar 20, 2025

    @vincdargento
    Author

    @sonialiap FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  7. brunovjk commented on Mar 20, 2025

    @brunovjk
    Contributor

    This issue seems to me to be a regression of our PR. Please assign me as C+. Thanks.

  8. luacmartins commented on Mar 20, 2025

    @luacmartins
    Contributor

    @brunovjk is this view behind a beta? or asked another way, can regular users access this view?

  9. brunovjk commented on Mar 21, 2025

    @brunovjk
    Contributor

    @brunovjk is this view behind a beta? or asked another way, can regular users access this view?

    Not yet, we are still working on this PR, it should be merged soon, when merged for sure regular users can not access

  10. blazejkustra commented on Mar 21, 2025

    @blazejkustra
    Contributor

    This is the expected behavior, the issue can be closed 😄

    TLDR; Side pane has two states on whether it is open/closed. One for wide screen the other for smaller screens.

  11. brunovjk commented on Mar 27, 2025

    @brunovjk
    Contributor

    I can't reproduce this anymore after implementing this PR. Tested on 27 Mar v9.1.20-2 Develop. We can close payment and BZ checklist will be handled here. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions