You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-05-13] [$250] Admin - "Schedule demo" text is misaligned when language set as Spanish. #58974
Version Number: 58928 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): Slottwo1 q@gmail.com Issue reported by: Applause Internal Team Device used: Redminote 10s android 13 App Component: Chat Report View
changed the title [-]Admin - "Schedule demo" text is misaligned when language set as Spanish.[/-][+][$250] Admin - "Schedule demo" text is misaligned when language set as Spanish.[/+]on Mar 25, 2025
changed the title [-][$250] Admin - "Schedule demo" text is misaligned when language set as Spanish.[/-][+][$125] Admin - "Schedule demo" text is misaligned when language set as Spanish.[/+]on Mar 25, 2025
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not Required
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Login with a gmail account without (+)
Complete onboarding selecting manage my team expense > nothing
Activity
melvin-bot commentedon Mar 24, 2025
Triggered auto assignment to @joekaufmanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nyomanjyotisa commentedon Mar 24, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Admin - "Schedule demo" text is misaligned when language set as Spanish
What is the root cause of that problem?
The current button styling does not accommodate longer text strings
App/src/pages/home/HeaderView.tsx
Line 220 in 4750e38
What changes do you think we should make in order to solve the problem?
We can adjust the button style by applying styles.flexWrap to ensure the text wraps correctly
style={shouldUseNarrowLayout && shouldShowGuideBookingButtonInEarlyDiscountBanner && [styles.flexWrap]}Additionally, we can do the same for "Claim Offer" button here
style={shouldUseNarrowLayout ? styles.flexWrap : styles.mr2}What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
[-]Admin - "Schedule demo" text is misaligned when language set as Spanish.[/-][+][$250] Admin - "Schedule demo" text is misaligned when language set as Spanish.[/+]melvin-bot commentedon Mar 25, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021904593839381412515
melvin-bot commentedon Mar 25, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (
External)joekaufmanexpensify commentedon Mar 25, 2025
Pretty minor issue, but we should fix it.
[-][$250] Admin - "Schedule demo" text is misaligned when language set as Spanish.[/-][+][$125] Admin - "Schedule demo" text is misaligned when language set as Spanish.[/+]65 remaining items
joekaufmanexpensify commentedon May 9, 2025
@shubham1206agra could you handle checklist so we can prep to pay next week?
joekaufmanexpensify commentedon May 12, 2025
Bumped in slack
shubham1206agra commentedon May 12, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/57092/files#r2084838471
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not Required
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Do we agree 👍 or 👎
hoangzinh commentedon May 12, 2025
I think it's just a UI issue, we don't need a regression test for it. Moreover, we're unable to show "schedule demo" atm https://expensify.slack.com/archives/C01GTK53T8Q/p1746184755120719
melvin-bot commentedon May 13, 2025
Payment Summary
Upwork Job
BugZero Checklist (@joekaufmanexpensify)
hoangzinh commentedon May 13, 2025
Requested in ND
joekaufmanexpensify commentedon May 13, 2025
I agree with no regression test being needed here.
joekaufmanexpensify commentedon May 13, 2025
All set to pay! We need to pay:
joekaufmanexpensify commentedon May 13, 2025
Please request at your earliest convenience. Closing as this is otherwise all set!
garrettmknight commentedon May 19, 2025
$250 approved for @hoangzinh
garrettmknight commentedon Jun 19, 2025
$250 approved for @shubham1206agra