Skip to content

[Due for payment 2025-04-25] [Native Share] iOS - Share file - No error modal when sharing large file directly from device #59020

Closed

Description

@nlemma

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.18-0
Reproducible in staging?: Yes
Reproducible in production?: N/A
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: #58834
Email or phone of affected tester (no customers): applausetester+830493@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.3
App Component: Other

Action Performed:

  1. Open a file which is larger than 24MB in device file app.
  2. Tap Share.
  3. Select Expensify.
  4. Go to Share.
  5. Select a destination.
  6. Tap Share.

Expected Result:

App will show "Attachment is too large" error when sharing large file.

Actual Result:

App does not show "Attachment is too large" error when sharing large file.
The file is uploaded and shows a different error (Unexpected error posting the comment) when uploading file.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6780966_1742854525514.ScreenRecording_03-25-2025_05-59-43_1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @miljakljajic

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerCashThis issue or pull request should block deployment
    on Mar 25, 2025
  2. melvin-bot commented on Mar 25, 2025

    @melvin-bot

    Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Mar 25, 2025

    @melvin-bot

    Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Mar 25, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Mar 25, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. nlemma commented on Mar 25, 2025

    @nlemma
    Author

    @miljakljajic FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  7. 19 remaining items

  8. changed the title [-][Native Share] iOS - Share file - No error modal when sharing large file directly from device[/-] [+][Due for payment 2025-04-25] [Native Share] iOS - Share file - No error modal when sharing large file directly from device[/+] on Apr 18, 2025
  9. melvin-bot commented on Apr 18, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  10. melvin-bot commented on Apr 18, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.29-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-04-25. 🎊

    For reference, here are some details about the assignees on this issue:

  11. melvin-bot commented on Apr 18, 2025

    @melvin-bot

    @shubham1206agra @miljakljajic @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  12. miljakljajic commented on Apr 28, 2025

    @miljakljajic
    Contributor

    Payment summary:

    @shubham1206agra is owed 250 USD for their work on this issue.

  13. shubham1206agra commented on Apr 28, 2025

    @shubham1206agra
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/55748/files#r2063966431

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: Not Required

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Test:

    1. Open a file which is larger than 24MB in device file app.
    2. Tap Share.
    3. Select Expensify.
    4. Go to Share.
    5. Select a destination.
    6. Verify that the error modal appears.

    Do we agree 👍 or 👎

  14. garrettmknight commented on May 13, 2025

    @garrettmknight
    Contributor

    $250 approved for @shubham1206agra

  15. garrettmknight commented on May 13, 2025

    @garrettmknight
    Contributor

    Reopening for QA @miljakljajic

  16. miljakljajic commented on May 15, 2025

    @miljakljajic
    Contributor

    Added!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions