You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-04-25] [Native Share] iOS - Share file - No error modal when sharing large file directly from device #59020
Version Number: 9.1.18-0 Reproducible in staging?: Yes Reproducible in production?: N/A If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both If this was caught during regression testing, add the test name, ID and link from TestRail:#58834 Email or phone of affected tester (no customers):applausetester+830493@applause.expensifail.com Issue reported by: Applause Internal Team Device used: iPhone 15 Pro Max / iOS 18.3 App Component: Other
Action Performed:
Open a file which is larger than 24MB in device file app.
Tap Share.
Select Expensify.
Go to Share.
Select a destination.
Tap Share.
Expected Result:
App will show "Attachment is too large" error when sharing large file.
Actual Result:
App does not show "Attachment is too large" error when sharing large file.
The file is uploaded and shows a different error (Unexpected error posting the comment) when uploading file.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@miljakljajic FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
changed the title [-][Native Share] iOS - Share file - No error modal when sharing large file directly from device[/-][+][Due for payment 2025-04-25] [Native Share] iOS - Share file - No error modal when sharing large file directly from device[/+]on Apr 18, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.29-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@shubham1206agra@miljakljajic@shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not Required
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Open a file which is larger than 24MB in device file app.
Activity
melvin-bot commentedon Mar 25, 2025
Triggered auto assignment to @miljakljajic (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Mar 25, 2025
Triggered auto assignment to @robertjchen (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Mar 25, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Mar 25, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
nlemma commentedon Mar 25, 2025
@miljakljajic FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
19 remaining items
[-][Native Share] iOS - Share file - No error modal when sharing large file directly from device[/-][+][Due for payment 2025-04-25] [Native Share] iOS - Share file - No error modal when sharing large file directly from device[/+]melvin-bot commentedon Apr 18, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 18, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.29-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-04-25. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 18, 2025
@shubham1206agra @miljakljajic @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
miljakljajic commentedon Apr 28, 2025
Payment summary:
@shubham1206agra is owed 250 USD for their work on this issue.
shubham1206agra commentedon Apr 28, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/55748/files#r2063966431
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not Required
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Do we agree 👍 or 👎
garrettmknight commentedon May 13, 2025
$250 approved for @shubham1206agra
garrettmknight commentedon May 13, 2025
Reopening for QA @miljakljajic
miljakljajic commentedon May 15, 2025
Added!