You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-04-08] [$250] Help Panel - the cursor is shown on unfocused composer box #59054
Version Number: v9.1.18-2 Reproducible in staging?: Yes Reproducible in production?: Unable to check If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail:#58847 Email or phone of affected tester (no customers):applausetester+ds@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 14.5/ Chrome App Component: Other
changed the title [-]Help Panel - the cursor is shown on unfocused composer box[/-][+][$250] Help Panel - the cursor is shown on unfocused composer box[/+]on Mar 26, 2025
if (!isPaneHidden && prevIsModalVisible) {
return;
}
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-][$250] Help Panel - the cursor is shown on unfocused composer box[/-][+][Due for payment 2025-04-08] [$250] Help Panel - the cursor is shown on unfocused composer box[/+]on Apr 1, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.21-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@brunovjk@RachCHopkins@brunovjk The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Mar 25, 2025
Triggered auto assignment to @RachCHopkins (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.jponikarchuk commentedon Mar 25, 2025
We can’t check Prod and I’m not sure if this issue is a DB
brunovjk commentedon Mar 25, 2025
The 'Help Panel' feat is not available on Prod, I don't think it's a blocker.
Im the C+ for the PR. Can we assign me here? Thanks.
brunovjk commentedon Mar 25, 2025
Can you take a look @blazejkustra? Thanks.
melvin-bot commentedon Mar 26, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021904714082516166842
[-]Help Panel - the cursor is shown on unfocused composer box[/-][+][$250] Help Panel - the cursor is shown on unfocused composer box[/+]melvin-bot commentedon Mar 26, 2025
Current assignee @brunovjk is eligible for the External assigner, not assigning anyone new.
huult commentedon Mar 26, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Help Panel - the cursor is shown on unfocused composer box
What is the root cause of that problem?
We don't return early in the case where both the Help Panel and a previous modal are open, which causes the composer to be focused.
App/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx
Line 674 in e382d1b
What changes do you think we should make in order to solve the problem?
To resolve this issue, we should return early when the Help Panel is open and a previous modal is still active
import:
const {isPaneHidden} = useSidePane();ttps://github.com/Expensify/App/blob/e382d1b310e95fca8b0c6ce2504da1df9f432a83/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx#L674
add:
if (!isPaneHidden && prevIsModalVisible) { return; }What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
1 remaining item
blazejkustra commentedon Mar 26, 2025
Update: I just raised a PR, @brunovjk will review it as a C+ 🥇
melvin-bot commentedon Mar 31, 2025
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
[-][$250] Help Panel - the cursor is shown on unfocused composer box[/-][+][Due for payment 2025-04-08] [$250] Help Panel - the cursor is shown on unfocused composer box[/+]melvin-bot commentedon Apr 1, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 1, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.21-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-04-08. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 1, 2025
@brunovjk @RachCHopkins @brunovjk The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Apr 2, 2025
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
brunovjk commentedon Apr 4, 2025
After the regression period I believe we can close this issue, payment and BZ checklist will be handled here. Thanks!
RachCHopkins commentedon Apr 7, 2025
No payment needed here!