Skip to content

[Due for payment 2025-04-08] [$250] Help Panel - the cursor is shown on unfocused composer box #59054

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.1.18-2
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #58847
Email or phone of affected tester (no customers): applausetester+ds@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 14.5/ Chrome
App Component: Other

Action Performed:

Precondition:

Run Onyx.set('nvp_sidePanel', {}) in console

  1. Go to staging.new.expensify.com
  2. Go to chat
  3. Open Help Panel
  4. clicking on CMD(ctrl) + D
  5. Close the testing preferences dialog

Expected Result:

Cursor is not shown on unfocused compose box

Actual Result:

The cursor is shown on unfocused composer box.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021904714082516166842
  • Upwork Job ID: 1904714082516166842
  • Last Price Increase: 2025-04-02
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @RachCHopkins

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 25, 2025
  2. melvin-bot commented on Mar 25, 2025

    @melvin-bot

    Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. jponikarchuk commented on Mar 25, 2025

    @jponikarchuk
    Author

    We can’t check Prod and I’m not sure if this issue is a DB

  4. brunovjk commented on Mar 25, 2025

    @brunovjk
    Contributor

    The 'Help Panel' feat is not available on Prod, I don't think it's a blocker.
    Im the C+ for the PR. Can we assign me here? Thanks.

  5. brunovjk commented on Mar 25, 2025

    @brunovjk
    Contributor

    Can you take a look @blazejkustra? Thanks.

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 26, 2025
  7. melvin-bot commented on Mar 26, 2025

    @melvin-bot
  8. changed the title [-]Help Panel - the cursor is shown on unfocused composer box[/-] [+][$250] Help Panel - the cursor is shown on unfocused composer box[/+] on Mar 26, 2025
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 26, 2025
  10. melvin-bot commented on Mar 26, 2025

    @melvin-bot

    Current assignee @brunovjk is eligible for the External assigner, not assigning anyone new.

  11. huult commented on Mar 26, 2025

    @huult
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Help Panel - the cursor is shown on unfocused composer box

    What is the root cause of that problem?

    We don't return early in the case where both the Help Panel and a previous modal are open, which causes the composer to be focused.

    What changes do you think we should make in order to solve the problem?

    To resolve this issue, we should return early when the Help Panel is open and a previous modal is still active

    import:

        const {isPaneHidden} = useSidePane();

    ttps://github.com/Expensify/App/blob/e382d1b310e95fca8b0c6ce2504da1df9f432a83/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/ComposerWithSuggestions.tsx#L674

    add:

        if (!isPaneHidden && prevIsModalVisible) {
            return;
        }

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  12. 1 remaining item

  13. blazejkustra commented on Mar 26, 2025

    @blazejkustra
    Contributor

    Update: I just raised a PR, @brunovjk will review it as a C+ 🥇

  14. melvin-bot commented on Mar 31, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  15. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Apr 1, 2025
  16. changed the title [-][$250] Help Panel - the cursor is shown on unfocused composer box[/-] [+][Due for payment 2025-04-08] [$250] Help Panel - the cursor is shown on unfocused composer box[/+] on Apr 1, 2025
  17. melvin-bot commented on Apr 1, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  18. melvin-bot commented on Apr 1, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.21-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-04-08. 🎊

    For reference, here are some details about the assignees on this issue:

    • @brunovjk requires payment (Needs manual offer from BZ)
  19. melvin-bot commented on Apr 1, 2025

    @melvin-bot

    @brunovjk @RachCHopkins @brunovjk The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  20. melvin-bot commented on Apr 2, 2025

    @melvin-bot

    📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

  21. brunovjk commented on Apr 4, 2025

    @brunovjk
    Contributor

    After the regression period I believe we can close this issue, payment and BZ checklist will be handled here. Thanks!

  22. RachCHopkins commented on Apr 7, 2025

    @RachCHopkins
    Contributor

    No payment needed here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions