You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Version Number: 9.1.18-2 Reproducible in staging?: Yes Reproducible in production?: No If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both If this was caught during regression testing, add the test name, ID and link from TestRail:#58834 Email or phone of affected tester (no customers):applausetester+250302kh@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Samsung Galaxy Z Fold 4 / Android 14 App Component: Other
Action Performed:
Precondition:
App location access is "Allow only while using the app".
App is killed.
Open an image in the device gallery app.
Tap Share.
Select Expensify app.
Tap app back button.
Go to app settings.
Open location permission settings.
Select Don't allow.
Go back to Expensify app.
Expected Result:
App will not reopen Share modal.
Actual Result:
App reopens Share modal after changing app location permission settings.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@grgia This one is not fixed. I didn't really have a chance to take this one. I've talked to @mateuuszzzzz and he will probably find some time next week work on this issue.
When we change permissions, Android restarts the activity. However, for some reason, it also sends the previously used intent again, which causes us to navigate back to the share screen. I'll be looking into potential solutions to fix this.
I suspect that the same issue might occur with other permissions and different types of intents, such as deeplinks. If this is confirmed, should we address all such issues?
I suspect that the same issue might occur with other permissions and different types of intents, such as deeplinks. If this is confirmed, should we address all such issues?
@mateuuszzzzz Do you have an update on this path? I'd be curious to hear if you think it's worth it.
I was trying to find any place in the codebase that could lead to this behaviour, but it really seems like Android is re-sending those intents, and we don’t have much control over it. Tricks like storing the previous intent and comparing it with the new one could break other things.
I think it might not be worth investing more time into this task since it's the intended behaviour.
Activity
melvin-bot commentedon Mar 25, 2025
Triggered auto assignment to @kadiealexander (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Mar 25, 2025
Triggered auto assignment to @blimpich (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Mar 25, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Mar 25, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
[-]Android - Share file - Share modal reopens after changing app location permission settings[/-][+][Native Share] Android - Share file - Share modal reopens after changing app location permission settings[/+]26 remaining items
289Adam289 commentedon Apr 25, 2025
@grgia This one is not fixed. I didn't really have a chance to take this one. I've talked to @mateuuszzzzz and he will probably find some time next week work on this issue.
grgia commentedon Apr 25, 2025
Thank you for the update @289Adam289
mateuuszzzzz commentedon Apr 30, 2025
When we change permissions, Android restarts the activity. However, for some reason, it also sends the previously used intent again, which causes us to navigate back to the share screen. I'll be looking into potential solutions to fix this.
mateuuszzzzz commentedon Apr 30, 2025
I suspect that the same issue might occur with other permissions and different types of intents, such as deeplinks. If this is confirmed, should we address all such issues?
grgia commentedon May 12, 2025
@mateuuszzzzz Do you have an update on this path? I'd be curious to hear if you think it's worth it.
mateuuszzzzz commentedon May 13, 2025
I was trying to find any place in the codebase that could lead to this behaviour, but it really seems like Android is re-sending those intents, and we don’t have much control over it. Tricks like storing the previous intent and comparing it with the new one could break other things.
I think it might not be worth investing more time into this task since it's the intended behaviour.
grgia commentedon May 29, 2025
Thank you @mateuuszzzzz. Gonna close out.