Skip to content

[Native Share] Android - Share file - Share modal reopens after changing app location permission settings #59072

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.18-2
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: #58834
Email or phone of affected tester (no customers): applausetester+250302kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy Z Fold 4 / Android 14
App Component: Other

Action Performed:

Precondition:

  • App location access is "Allow only while using the app".
  • App is killed.
  1. Open an image in the device gallery app.
  2. Tap Share.
  3. Select Expensify app.
  4. Tap app back button.
  5. Go to app settings.
  6. Open location permission settings.
  7. Select Don't allow.
  8. Go back to Expensify app.

Expected Result:

App will not reopen Share modal.

Actual Result:

App reopens Share modal after changing app location permission settings.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerCashThis issue or pull request should block deployment
    on Mar 25, 2025
  2. melvin-bot commented on Mar 25, 2025

    @melvin-bot

    Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Mar 25, 2025

    @melvin-bot

    Triggered auto assignment to @blimpich (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Mar 25, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Mar 25, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. changed the title [-]Android - Share file - Share modal reopens after changing app location permission settings[/-] [+][Native Share] Android - Share file - Share modal reopens after changing app location permission settings[/+] on Mar 25, 2025
  7. 26 remaining items

  8. 289Adam289 commented on Apr 25, 2025

    @289Adam289
    Contributor

    @grgia This one is not fixed. I didn't really have a chance to take this one. I've talked to @mateuuszzzzz and he will probably find some time next week work on this issue.

  9. grgia commented on Apr 25, 2025

    @grgia
    Contributor

    Thank you for the update @289Adam289

  10. mateuuszzzzz commented on Apr 30, 2025

    @mateuuszzzzz
    Contributor

    When we change permissions, Android restarts the activity. However, for some reason, it also sends the previously used intent again, which causes us to navigate back to the share screen. I'll be looking into potential solutions to fix this.

  11. mateuuszzzzz commented on Apr 30, 2025

    @mateuuszzzzz
    Contributor

    I suspect that the same issue might occur with other permissions and different types of intents, such as deeplinks. If this is confirmed, should we address all such issues?

  12. grgia commented on May 12, 2025

    @grgia
    Contributor

    I suspect that the same issue might occur with other permissions and different types of intents, such as deeplinks. If this is confirmed, should we address all such issues?

    @mateuuszzzzz Do you have an update on this path? I'd be curious to hear if you think it's worth it.

  13. mateuuszzzzz commented on May 13, 2025

    @mateuuszzzzz
    Contributor

    I was trying to find any place in the codebase that could lead to this behaviour, but it really seems like Android is re-sending those intents, and we don’t have much control over it. Tricks like storing the previous intent and comparing it with the new one could break other things.

    I think it might not be worth investing more time into this task since it's the intended behaviour.

  14. grgia commented on May 29, 2025

    @grgia
    Contributor

    I think it might not be worth investing more time into this task since it's the intended behaviour.

    Thank you @mateuuszzzzz. Gonna close out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions