You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Improve the performance of uploading image from gallery on native device with clear feedback to the user #59347
Coming from here, we can notice long delay when choosing an image from the the gallery on iOS device to be used for the smartscan. There is no feedback for the user when that happens either, leaving user with bad UX.
Solution
Add a loading indicator on the camera view, when the app is processing an uploaded image. Additionally investigate if this can be sped up
changed the title [-]Improve the performance of uploading image from gallery on native device with clear feedback to the user[/-][+][$250] Improve the performance of uploading image from gallery on native device with clear feedback to the user[/+]on Mar 31, 2025
Using ChatGPT to summarize the Slack discussion, here's where we are so far:
HEIC Image Format Upload Error on iOS Staging
Problem
Users are unable to upload HEIC images as receipts from the iOS gallery on the latest staging. When selecting an HEIC image, the Web API returns an error indicating that the file type is unsupported, with an error message related to unsupported PDF format. This issue prevents receipt creation on iOS.
Why is this important?
This issue affects users attempting to submit receipts using the latest staging version of the app, especially those using the iOS platform. The problem impacts the user experience and blocks receipt submission for those using the HEIC image format.
Solution
The issue was traced back to a change introduced by a recent PR (#59330), which was reverted in a later update. Testing indicated that after reverting the changes in the PR, the issue was resolved. A thorough investigation and testing of the image manipulator on iOS are required to ensure compatibility with HEIC files. The problem was identified as a compatibility issue with the backend processors when using the manipulator on images.
Action items:
Ensure that the backend processors handle HEIC file types properly.
Test the gallery image selection functionality thoroughly after any code adjustments.
Verify that iOS users can upload HEIC images without encountering errors.
Review and update the associated TestRail cases to cover this issue.
changed the title [-][Due for payment 2025-04-16] [$250] Improve the performance of uploading image from gallery on native device with clear feedback to the user[/-][+][$250] Improve the performance of uploading image from gallery on native device with clear feedback to the user[/+]on Apr 24, 2025
[Contributor] Classify the bug: Not a bug, this seems like a new improvement
Bug classification
Source of bug:
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Not a bug, this seems like a new improvement
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Test only on iOS and Android
Open DM
Press + -> Create expense
In "Scan" tab open attachment picker in left bottom corner
Select "Choose from gallery"
Verify the full screen loader is displayed when opening the image picker
Pick a picture
Verify the full screen loader disappears once the image picker is closed
Activity
[-]Improve the performance of uploading image from gallery on native device with clear feedback to the user[/-][+][$250] Improve the performance of uploading image from gallery on native device with clear feedback to the user[/+]melvin-bot commentedon Mar 31, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021906688655033303465
melvin-bot commentedon Mar 31, 2025
Current assignee @mountiny is eligible for the AutoAssignerNewDotQuality assigner, not assigning anyone new.
melvin-bot commentedon Mar 31, 2025
Triggered auto assignment to @johncschuster (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Mar 31, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (
External)26 remaining items
melvin-bot commentedon Apr 22, 2025
@johncschuster Eep! 4 days overdue now. Issues have feelings too...
johncschuster commentedon Apr 22, 2025
Thanks for the heads up, @DylanDylann! I'll wait to issue payment until I've gotten the green light 👍
johncschuster commentedon Apr 24, 2025
Using ChatGPT to summarize the Slack discussion, here's where we are so far:
HEIC Image Format Upload Error on iOS Staging
Problem
Users are unable to upload HEIC images as receipts from the iOS gallery on the latest staging. When selecting an HEIC image, the Web API returns an error indicating that the file type is unsupported, with an error message related to unsupported PDF format. This issue prevents receipt creation on iOS.
Why is this important?
This issue affects users attempting to submit receipts using the latest staging version of the app, especially those using the iOS platform. The problem impacts the user experience and blocks receipt submission for those using the HEIC image format.
Solution
The issue was traced back to a change introduced by a recent PR (#59330), which was reverted in a later update. Testing indicated that after reverting the changes in the PR, the issue was resolved. A thorough investigation and testing of the image manipulator on iOS are required to ensure compatibility with HEIC files. The problem was identified as a compatibility issue with the backend processors when using the manipulator on images.
Action items:
Does that sound about right, @mountiny, @DylanDylann, @TMisiukiewicz?
[-][Due for payment 2025-04-16] [$250] Improve the performance of uploading image from gallery on native device with clear feedback to the user[/-][+][$250] Improve the performance of uploading image from gallery on native device with clear feedback to the user[/+]mountiny commentedon Apr 24, 2025
This was resolved by this PR #59363 all good, we can pay this one out and close
DylanDylann commentedon Apr 25, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Not a bug, this seems like a new improvement
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Test only on iOS and Android
Do we agree 👍 or 👎
johncschuster commentedon Apr 25, 2025
Payment Summary
Contributor: @TMisiukiewicz does not require payment (Contractor) ✅
Contributor+: @DylanDylann owed $250 via NewDot
DylanDylann commentedon Apr 25, 2025
@johncschuster I receive payment via NewDot, so we can close out this issue now.
JmillsExpensify commentedon Jul 9, 2025
$250 approved for @DylanDylann