Skip to content

[$250] Improve the performance of uploading image from gallery on native device with clear feedback to the user #59347

Closed

Description

@mountiny

Problem

Coming from here, we can notice long delay when choosing an image from the the gallery on iOS device to be used for the smartscan. There is no feedback for the user when that happens either, leaving user with bad UX.

Solution

Add a loading indicator on the camera view, when the app is processing an uploaded image. Additionally investigate if this can be sped up

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021906688655033303465
  • Upwork Job ID: 1906688655033303465
  • Last Price Increase: 2025-03-31
Issue OwnerCurrent Issue Owner: @johncschuster
Issue OwnerCurrent Issue Owner: @TMisiukiewicz

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 31, 2025
  2. changed the title [-]Improve the performance of uploading image from gallery on native device with clear feedback to the user[/-] [+][$250] Improve the performance of uploading image from gallery on native device with clear feedback to the user[/+] on Mar 31, 2025
  3. melvin-bot commented on Mar 31, 2025

    @melvin-bot
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 31, 2025
  5. melvin-bot commented on Mar 31, 2025

    @melvin-bot

    Current assignee @mountiny is eligible for the AutoAssignerNewDotQuality assigner, not assigning anyone new.

  6. melvin-bot commented on Mar 31, 2025

    @melvin-bot

    Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  7. melvin-bot commented on Mar 31, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

  8. 26 remaining items

  9. melvin-bot commented on Apr 22, 2025

    @melvin-bot

    @johncschuster Eep! 4 days overdue now. Issues have feelings too...

  10. johncschuster commented on Apr 22, 2025

    @johncschuster
    Contributor

    Thanks for the heads up, @DylanDylann! I'll wait to issue payment until I've gotten the green light 👍

  11. johncschuster commented on Apr 24, 2025

    @johncschuster
    Contributor

    Using ChatGPT to summarize the Slack discussion, here's where we are so far:

    HEIC Image Format Upload Error on iOS Staging

    Problem

    Users are unable to upload HEIC images as receipts from the iOS gallery on the latest staging. When selecting an HEIC image, the Web API returns an error indicating that the file type is unsupported, with an error message related to unsupported PDF format. This issue prevents receipt creation on iOS.

    Why is this important?

    This issue affects users attempting to submit receipts using the latest staging version of the app, especially those using the iOS platform. The problem impacts the user experience and blocks receipt submission for those using the HEIC image format.

    Solution

    The issue was traced back to a change introduced by a recent PR (#59330), which was reverted in a later update. Testing indicated that after reverting the changes in the PR, the issue was resolved. A thorough investigation and testing of the image manipulator on iOS are required to ensure compatibility with HEIC files. The problem was identified as a compatibility issue with the backend processors when using the manipulator on images.

    Action items:

    • Ensure that the backend processors handle HEIC file types properly.
    • Test the gallery image selection functionality thoroughly after any code adjustments.
    • Verify that iOS users can upload HEIC images without encountering errors.
    • Review and update the associated TestRail cases to cover this issue.

    Does that sound about right, @mountiny, @DylanDylann, @TMisiukiewicz?

  12. changed the title [-][Due for payment 2025-04-16] [$250] Improve the performance of uploading image from gallery on native device with clear feedback to the user[/-] [+][$250] Improve the performance of uploading image from gallery on native device with clear feedback to the user[/+] on Apr 24, 2025
  13. mountiny commented on Apr 24, 2025

    @mountiny
    ContributorAuthor

    This was resolved by this PR #59363 all good, we can pay this one out and close

  14. DylanDylann commented on Apr 25, 2025

    @DylanDylann
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug: Not a bug, this seems like a new improvement
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: Not a bug, this seems like a new improvement

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    Test only on iOS and Android

    1. Open DM
    2. Press + -> Create expense
    3. In "Scan" tab open attachment picker in left bottom corner
    4. Select "Choose from gallery"
    5. Verify the full screen loader is displayed when opening the image picker
    6. Pick a picture
    7. Verify the full screen loader disappears once the image picker is closed

    Do we agree 👍 or 👎

  15. johncschuster commented on Apr 25, 2025

    @johncschuster
    Contributor

    Payment Summary

    Contributor: @TMisiukiewicz does not require payment (Contractor) ✅
    Contributor+: @DylanDylann owed $250 via NewDot

  16. DylanDylann commented on Apr 25, 2025

    @DylanDylann
    Contributor

    @johncschuster I receive payment via NewDot, so we can close out this issue now.

  17. JmillsExpensify commented on Jul 9, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @DylanDylann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

AutoAssignerNewDotQualityUsed to assign quality issues to engineersAwaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions