You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-05-14] [Due for payment 2025-04-17] [Desktop Navigation] Add a dedicated Workspace filter to the Reports tab #59366
Do we want to add a save button at the bottom of this screen like in other filter screens?
Yes I think we should. @Expensify/design @JmillsExpensify for a gut check, but my thinking is that even though this is single select (for now), we should go ahead and include the save button because with the work we're going to do with suggested searches and filter updates, we'll have one. So we might as well just include it now to make that smoother.
On designs we don’t have an input for a search term, should it be displayed on this page?
The typical rule we follow is if there are 8 list items or more, we include the search input. Can we implement that same logic here?
but my thinking is that even though this is single select (for now), we should go ahead and include the save button because with the work we're going to do with suggested searches and filter updates, we'll have one. So we might as well just include it now to make that smoother.
I can see that point... at the same time, we don't really have any Save buttons on single select push pages, so if we want to be consistent in the meantime, I think what is being shown is technically the most correct.
@mountiny@WojtekBoman wasn't sure where the right place to post this was, but on the LHB beta, I just discovered that if I filter to a workspace on the Reports page, it ALSO filters my Inbox 😱 and it's very hard to get it to go back to normal.
CleanShot.2025-04-18.at.08.14.59.mp4
The only way I've been able to for real clear the filter is by resetting filters and immediately going to Troubleshoot > Clear cache and restart. I think we need to fix this ASAP because it is a Large Bummer™.
@dannymcclain You're right, but I think the best solution to fix this issue is to remove the new beta version and finally remove all code related to Workspace Switcher. We're removing the beta in this PR. Once it's merged I'll start working on erasing the Workspace Switcher
Yeah we got this one reported before, its only if you are on the beta. @sumo-slonik@WojtekBoman Can we please fix this before the beta is removed? The Reports Workspace filter should not use the WorkspaceSwitcher context and I feel like this can be separated before we remove the beta
to track this a bit more clearly I have created this issue with reproduction steps #60534
changed the title [-][Due for payment 2025-04-17] [Desktop Navigation] Add a dedicated Workspace filter to the Reports tab[/-][+][Due for payment 2025-05-14] [Due for payment 2025-04-17] [Desktop Navigation] Add a dedicated Workspace filter to the Reports tab[/+]on May 7, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.40-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@dukenv0307] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
[@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Mar 31, 2025
Triggered auto assignment to @adelekennedy (
NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.WojtekBoman commentedon Mar 31, 2025
Hey, I'm going to work on it
WojtekBoman commentedon Apr 1, 2025
Hey @dannymcclain
I’m working on a new workspace filter screen and I have 2 questions about this feature:
Screen.Recording.2025-04-01.at.11.43.22.mov
dannymcclain commentedon Apr 1, 2025
Yes I think we should. @Expensify/design @JmillsExpensify for a gut check, but my thinking is that even though this is single select (for now), we should go ahead and include the save button because with the work we're going to do with suggested searches and filter updates, we'll have one. So we might as well just include it now to make that smoother.
The typical rule we follow is if there are 8 list items or more, we include the search input. Can we implement that same logic here?
shawnborton commentedon Apr 1, 2025
I can see that point... at the same time, we don't really have any Save buttons on single select push pages, so if we want to be consistent in the meantime, I think what is being shown is technically the most correct.
35 remaining items
dannymcclain commentedon Apr 18, 2025
@mountiny @WojtekBoman wasn't sure where the right place to post this was, but on the LHB beta, I just discovered that if I filter to a workspace on the Reports page, it ALSO filters my Inbox 😱 and it's very hard to get it to go back to normal.
CleanShot.2025-04-18.at.08.14.59.mp4
The only way I've been able to for real clear the filter is by resetting filters and immediately going to Troubleshoot > Clear cache and restart. I think we need to fix this ASAP because it is a Large Bummer™.
cc @Expensify/design
WojtekBoman commentedon Apr 18, 2025
@dannymcclain You're right, but I think the best solution to fix this issue is to remove the new beta version and finally remove all code related to Workspace Switcher. We're removing the beta in this PR. Once it's merged I'll start working on erasing the Workspace Switcher
dannymcclain commentedon Apr 18, 2025
Gotcha - thanks!
shawnborton commentedon Apr 18, 2025
Good catch Danny!
mountiny commentedon Apr 19, 2025
Yeah we got this one reported before, its only if you are on the beta. @sumo-slonik @WojtekBoman Can we please fix this before the beta is removed? The Reports Workspace filter should not use the WorkspaceSwitcher context and I feel like this can be separated before we remove the beta
to track this a bit more clearly I have created this issue with reproduction steps #60534
Thank y'all
[-][Due for payment 2025-04-17] [Desktop Navigation] Add a dedicated Workspace filter to the Reports tab[/-][+][Due for payment 2025-05-14] [Due for payment 2025-04-17] [Desktop Navigation] Add a dedicated Workspace filter to the Reports tab[/+]melvin-bot commentedon May 7, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.40-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-05-14. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 7, 2025
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: