Skip to content

[Due for payment 2025-05-14] [Due for payment 2025-04-17] [Desktop Navigation] Add a dedicated Workspace filter to the Reports tab #59366

Closed

Description

@mountiny

Part of https://github.com/Expensify/Expensify/issues/468845

Implement this section of the Design doc (linking to the tasks section as this project is being handled by SWM).

Issue OwnerCurrent Issue Owner: @adelekennedy

Activity

  1. melvin-bot commented on Mar 31, 2025

    @melvin-bot

    Triggered auto assignment to @adelekennedy (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

  2. WojtekBoman commented on Mar 31, 2025

    @WojtekBoman
    Contributor

    Hey, I'm going to work on it

  3. WojtekBoman commented on Apr 1, 2025

    @WojtekBoman
    Contributor

    Hey @dannymcclain

    I’m working on a new workspace filter screen and I have 2 questions about this feature:

    1. Do we want to add a save button at the bottom of this screen like in other filter screens?
    2. On designs we don’t have an input for a search term, should it be displayed on this page?
    Screen.Recording.2025-04-01.at.11.43.22.mov
  4. dannymcclain commented on Apr 1, 2025

    @dannymcclain
    Contributor

    Do we want to add a save button at the bottom of this screen like in other filter screens?

    Yes I think we should. @Expensify/design @JmillsExpensify for a gut check, but my thinking is that even though this is single select (for now), we should go ahead and include the save button because with the work we're going to do with suggested searches and filter updates, we'll have one. So we might as well just include it now to make that smoother.

    On designs we don’t have an input for a search term, should it be displayed on this page?

    The typical rule we follow is if there are 8 list items or more, we include the search input. Can we implement that same logic here?

  5. shawnborton commented on Apr 1, 2025

    @shawnborton
    Contributor

    but my thinking is that even though this is single select (for now), we should go ahead and include the save button because with the work we're going to do with suggested searches and filter updates, we'll have one. So we might as well just include it now to make that smoother.

    I can see that point... at the same time, we don't really have any Save buttons on single select push pages, so if we want to be consistent in the meantime, I think what is being shown is technically the most correct.

  6. 35 remaining items

  7. dannymcclain commented on Apr 18, 2025

    @dannymcclain
    Contributor

    @mountiny @WojtekBoman wasn't sure where the right place to post this was, but on the LHB beta, I just discovered that if I filter to a workspace on the Reports page, it ALSO filters my Inbox 😱 and it's very hard to get it to go back to normal.

    CleanShot.2025-04-18.at.08.14.59.mp4

    The only way I've been able to for real clear the filter is by resetting filters and immediately going to Troubleshoot > Clear cache and restart. I think we need to fix this ASAP because it is a Large Bummer™.

    cc @Expensify/design

  8. WojtekBoman commented on Apr 18, 2025

    @WojtekBoman
    Contributor

    @dannymcclain You're right, but I think the best solution to fix this issue is to remove the new beta version and finally remove all code related to Workspace Switcher. We're removing the beta in this PR. Once it's merged I'll start working on erasing the Workspace Switcher

  9. dannymcclain commented on Apr 18, 2025

    @dannymcclain
    Contributor

    Gotcha - thanks!

  10. shawnborton commented on Apr 18, 2025

    @shawnborton
    Contributor

    Good catch Danny!

  11. mountiny commented on Apr 19, 2025

    @mountiny
    ContributorAuthor

    Yeah we got this one reported before, its only if you are on the beta. @sumo-slonik @WojtekBoman Can we please fix this before the beta is removed? The Reports Workspace filter should not use the WorkspaceSwitcher context and I feel like this can be separated before we remove the beta

    to track this a bit more clearly I have created this issue with reproduction steps #60534

    Thank y'all

  12. changed the title [-][Due for payment 2025-04-17] [Desktop Navigation] Add a dedicated Workspace filter to the Reports tab[/-] [+][Due for payment 2025-05-14] [Due for payment 2025-04-17] [Desktop Navigation] Add a dedicated Workspace filter to the Reports tab[/+] on May 7, 2025
  13. melvin-bot commented on May 7, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.40-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-05-14. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on May 7, 2025

    @melvin-bot

    BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@dukenv0307] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
    • [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionNewFeatureSomething to build that is a new item.ReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions