Skip to content

[$250] Chat - Green line appears when send message in custom room #59393

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.1.21-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers): gocemate+b20336@gmail.com
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy A02s/12
App Component: Chat Report View

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create workspace
  3. Go to FAB? Start chat> Room> Complete the creation process
  4. Send a few messages into room

Expected Result:

There should be no green line above the sent message

Actual Result:

New message green line appears when send message in room

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6784750_1743110346795.Dvnb8264_1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021906791675214589726
  • Upwork Job ID: 1906791675214589726
  • Last Price Increase: 2025-03-31
Issue OwnerCurrent Issue Owner: @ZhenjaHorbach

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 31, 2025
  2. melvin-bot commented on Mar 31, 2025

    @melvin-bot

    Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. added
    DeployBlockerCashThis issue or pull request should block deployment
    and removed on Mar 31, 2025
  4. melvin-bot commented on Mar 31, 2025

    @melvin-bot

    Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  5. melvin-bot commented on Mar 31, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. github-actions commented on Mar 31, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  7. Julesssss commented on Mar 31, 2025

    @Julesssss
    Contributor

    I assume this is occuring on all platforms, here's web:

    Image
  8. Julesssss commented on Mar 31, 2025

    @Julesssss
    Contributor

    I'm unable to reproduce locally on an recent build, no matter if I use staging or prod front-end/backend branches 😕

  9. melvin-bot commented on Mar 31, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  10. 4 remaining items

  11. melvin-bot commented on Mar 31, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

  12. Julesssss commented on Mar 31, 2025

    @Julesssss
    Contributor

    I can reproduce now against all backend envs, I had an unrelated vm/onyxData error.

  13. Julesssss commented on Mar 31, 2025

    @Julesssss
    Contributor

    Working through the commits it seems that this is the most recent commit on the checklist where the issues doesn't occur:

    Image

    And on the next commit the issue begins:

    Image Image

    However, reverting the PR here does not resolve the issue 😕

  14. Julesssss commented on Mar 31, 2025

    @Julesssss
    Contributor

    I think we're failing to pass the shouldHideThreadDividerLine prop to UnreadActionIndicator

    Image
  15. Julesssss commented on Mar 31, 2025

    @Julesssss
    Contributor

    Caused by refactor that doesn't pass shouldDisplayNewMarker to PureReportActionItem?

  16. rohit9625 commented on Apr 1, 2025

    @rohit9625
    Contributor

    Does passing the prop solved the issue?

  17. grgia commented on Apr 1, 2025

    @grgia
    Contributor

    PR reverted linked this issue, @jponikarchuk could we retest?

  18. melvin-bot commented on Apr 1, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  19. jponikarchuk commented on Apr 1, 2025

    @jponikarchuk
    Author

    @grgia The issue is not reproducible, build v9.1.21-3

    Recording.5313.mp4
  20. rohit9625 commented on Apr 1, 2025

    @rohit9625
  21. Julesssss commented on Apr 1, 2025

    @Julesssss
    Contributor

    Confirmed fixed after revert 🎉

    Receiving
    Image

    Sending
    Image

  22. Sandeep2042001 commented on Apr 6, 2025

    @Sandeep2042001

    Contributor details
    My Expensify account email: sandeepkumawat246@gmail.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~011e8ba6ed9a13b279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsHourlyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions