Skip to content

[HOLD for payment 2021-12-06] Request a call modal - Update phone number requirements and instructions.  #5945

Closed

Description

@isagoico

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Navigate to the Concierge conversation
  2. Click on the phone icon on top right

Expected Result:

There should be clear instructions on how to enter a phone number. (Country code, format, etc). Also, the phone number displayed should be the Expensify number (the one user to call customers). Please check @mallenexpensify proposed improvements on notes section.

Actual Result:

Instructions are focused on phone numbers which country code and the phone number displayed is not from Expensify.

Workaround:

None Needed.

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.8-0
Reproducible in staging?: Yes
Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Improvements from @mallenexpensify:

  • The example phone number that's misaligned shows you should enter +1 at the beginning but it's not necessary for US numbers. We should update number in the box to remove +1 .
  • The number that should be shown in the box should be updated to 2109400803 , a number we actually call from.
  • The red error text also states you need to include a country code which you don't if you're in the US (which I'm guessing is ~90% of our calls). Can we update it to "Please enter a phone number. If you're outside the US please include your country code, eg. +44 7782 339811" (which is an actual number we call from in the UK)

image

Expensify/Expensify Issue URL:

Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1634498711397400

View all open jobs on GitHub

Activity

  1. MelvinBot commented on Oct 19, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @chiragsalian (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  2. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 19, 2021
  3. MelvinBot commented on Oct 19, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @Christinadobrzyn (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  4. chiragsalian commented on Oct 19, 2021

    @chiragsalian
    Contributor

    Issue LGTM, should be an easy fix for our external contributors.

  5. Christinadobrzyn commented on Oct 20, 2021

    @Christinadobrzyn
    Contributor
  6. Santhosh-Sellavel commented on Oct 20, 2021

    @Santhosh-Sellavel
    Collaborator

    Proposal

    We need to update the placeholder 2109400803 here,

    placeholder="+14158675309"

    We need to update the message here & in es.js also for the same key,

    noPhoneNumber: 'Please enter a phone number including the country code e.g +447814266907.',

    But one question @chiragsalian,

    1. The same message is used for other phone number input error messages too, should it be the same on other pages or let alone this page.

    2. Should we change here also anything?

      errorMessageInvalidPhone: 'That doesn’t look like a valid phone number. Try again with the country code. e.g. +15005550006',

    Need Spanish copy for the new message.

  7. chiragsalian commented on Oct 20, 2021

    @chiragsalian
    Contributor

    Proposal LGTM i think you forgot to account to correct the misalignment so can you update your proposal to account for this.
    Edit: The misalignment of inputs is handled here.

    The same message is used for other phone number input error messages too, should it be the same on other pages or let alone this page.

    Yup, it should be the same on all other pages i.e., you can just update noPhoneNumber so that its reflected everywhere. One note though, once you make the changes please test some of the other places where the copy has been updated so that styles are not broken since the updated text is longer.

    Should we change here also anything?

    Sure yes. I think That doesn’t look like a valid phone number. Please enter a valid phone number. If you're outside the US please include your country code, eg. +44 7782 339811. Not sure if that's too long. I'll let @mallenexpensify chime in. Matt once decided can you ask #espanol for Spanish copies of this and "Please enter a phone number. If you're outside the US please include your country code, eg. +44 7782 339811". Asking you since I'll be OOO for a few days.

  8. Christinadobrzyn commented on Oct 25, 2021

    @Christinadobrzyn
    Contributor

    Hired @Santhosh-Sellavel for this job 🎉

  9. 9 remaining items

  10. chiragsalian commented on Nov 2, 2021

    @chiragsalian
    Contributor

    English copy,

    Please enter a valid phone number without brackets or dashes. If you're outside the US please include your country code, eg. +447782339811

    Spanish copy,

    Por favor, introduce un número de teléfono válido sin paréntesis o guiones. Si reside fuera de Estados Unidos, por favor incluye el prefijo internacional. P. ej. +447782339811

    So you should be all set to create the PR right @Santhosh-Sellavel or is there any pending question on your end?

  11. chiragsalian commented on Nov 2, 2021

    @chiragsalian
    Contributor

    Ah true, I forget we have just one box. Well maybe someday we'll split it like oldDot,
    image

    and then perhaps we could implement that logic.

  12. Santhosh-Sellavel commented on Nov 2, 2021

    @Santhosh-Sellavel
    Collaborator

    @chiragsalian

    The following changes needed to be done in PR right?

    1. We need to update the placeholder 2109400803 here,

      placeholder="+14158675309"

    2. Update following error messages to new messages given here

    • noPhoneNumber: 'Please enter a phone number including the country code e.g +447814266907.',
    • errorMessageInvalidPhone: 'That doesn’t look like a valid phone number. Try again with the country code. e.g. +15005550006',
    1. Additionally, as you mentioned in comment.

    You can modify the created PR to allow spaces in phone numbers as well. Should be a very easy fix to trim them out when needed via code.

    For the Request call page box alone or for what other fields?
    Do we really need this change? Why would we need a space here?

  13. chiragsalian commented on Nov 2, 2021

    @chiragsalian
    Contributor

    1 and 2 are correct. 3 is not needed. I meant that for the follow-up issue MattAllen created and it looks like he updated the follow-up issue title to reflect the same.

    You just need to address your points 1 and 2 for this issue 🙂

  14. Christinadobrzyn commented on Nov 22, 2021

    @Christinadobrzyn
    Contributor

    Looks like the PR is under review - moving forward with this fix!

  15. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Nov 29, 2021
  16. botify commented on Nov 29, 2021

    @botify

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.16-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2021-12-06. 🎊

  17. changed the title [-]Request a call modal - Update phone number requirements and instructions. [/-] [+][HOLD for payment 2021-12-06] Request a call modal - Update phone number requirements and instructions. [/+] on Nov 29, 2021
  18. Christinadobrzyn commented on Dec 7, 2021

    @Christinadobrzyn
    Contributor

    Paid @Santhosh-Sellavel in Upwork - closing this job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionEngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions