You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2021-12-06] Request a call modal - Update phone number requirements and instructions. #5945
There should be clear instructions on how to enter a phone number. (Country code, format, etc). Also, the phone number displayed should be the Expensify number (the one user to call customers). Please check @mallenexpensify proposed improvements on notes section.
Actual Result:
Instructions are focused on phone numbers which country code and the phone number displayed is not from Expensify.
Workaround:
None Needed.
Platform:
Where is this issue occurring?
Web
iOS
Android
Desktop App
Mobile Web
Version Number: 1.1.8-0 Reproducible in staging?: Yes Reproducible in production?: Yes
The example phone number that's misaligned shows you should enter +1 at the beginning but it's not necessary for US numbers. We should update number in the box to remove +1 .
The number that should be shown in the box should be updated to 2109400803 , a number we actually call from.
The red error text also states you need to include a country code which you don't if you're in the US (which I'm guessing is ~90% of our calls). Can we update it to "Please enter a phone number. If you're outside the US please include your country code, eg. +44 7782 339811" (which is an actual number we call from in the UK)
Proposal LGTM i think you forgot to account to correct the misalignment so can you update your proposal to account for this. Edit: The misalignment of inputs is handled here.
The same message is used for other phone number input error messages too, should it be the same on other pages or let alone this page.
Yup, it should be the same on all other pages i.e., you can just update noPhoneNumber so that its reflected everywhere. One note though, once you make the changes please test some of the other places where the copy has been updated so that styles are not broken since the updated text is longer.
Should we change here also anything?
Sure yes. I think That doesn’t look like a valid phone number. Please enter a valid phone number. If you're outside the US please include your country code, eg. +44 7782 339811. Not sure if that's too long. I'll let @mallenexpensify chime in. Matt once decided can you ask #espanol for Spanish copies of this and "Please enter a phone number. If you're outside the US please include your country code, eg. +44 7782 339811". Asking you since I'll be OOO for a few days.
Please enter a valid phone number without brackets or dashes. If you're outside the US please include your country code, eg. +447782339811
Spanish copy,
Por favor, introduce un número de teléfono válido sin paréntesis o guiones. Si reside fuera de Estados Unidos, por favor incluye el prefijo internacional. P. ej. +447782339811
So you should be all set to create the PR right @Santhosh-Sellavel or is there any pending question on your end?
1 and 2 are correct. 3 is not needed. I meant that for the follow-up issue MattAllen created and it looks like he updated the follow-up issue title to reflect the same.
You just need to address your points 1 and 2 for this issue 🙂
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.16-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
changed the title [-]Request a call modal - Update phone number requirements and instructions. [/-][+][HOLD for payment 2021-12-06] Request a call modal - Update phone number requirements and instructions. [/+]on Nov 29, 2021
Activity
MelvinBot commentedon Oct 19, 2021
Triggered auto assignment to @chiragsalian (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.MelvinBot commentedon Oct 19, 2021
Triggered auto assignment to @Christinadobrzyn (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.chiragsalian commentedon Oct 19, 2021
Issue LGTM, should be an easy fix for our external contributors.
Christinadobrzyn commentedon Oct 20, 2021
Posted job in Upwork
Internal post - https://www.upwork.com/ab/applicants/1450704542045765632/job-details
External post - https://www.upwork.com/jobs/~01e8e6ed06b97f3234
Santhosh-Sellavel commentedon Oct 20, 2021
Proposal
We need to update the placeholder
2109400803here,App/src/pages/RequestCallPage.js
Line 208 in 7f3153a
We need to update the message here & in es.js also for the same key,
App/src/languages/en.js
Line 471 in 7f3153a
But one question @chiragsalian,
The same message is used for other phone number input error messages too, should it be the same on other pages or let alone this page.
Should we change here also anything?
App/src/languages/en.js
Line 472 in 7f3153a
Need Spanish copy for the new message.
chiragsalian commentedon Oct 20, 2021
Proposal LGTM
i think you forgot to account to correct the misalignment so can you update your proposal to account for this.Edit: The misalignment of inputs is handled here.
Yup, it should be the same on all other pages i.e., you can just update
noPhoneNumberso that its reflected everywhere. One note though, once you make the changes please test some of the other places where the copy has been updated so that styles are not broken since the updated text is longer.Sure yes. I think
That doesn’t look like a valid phone number. Please enter a valid phone number. If you're outside the US please include your country code, eg. +44 7782 339811. Not sure if that's too long. I'll let @mallenexpensify chime in. Matt once decided can you ask #espanol for Spanish copies of this and "Please enter a phone number. If you're outside the US please include your country code, eg. +44 7782 339811". Asking you since I'll be OOO for a few days.Christinadobrzyn commentedon Oct 25, 2021
Hired @Santhosh-Sellavel for this job 🎉
9 remaining items
chiragsalian commentedon Nov 2, 2021
English copy,
Spanish copy,
So you should be all set to create the PR right @Santhosh-Sellavel or is there any pending question on your end?
chiragsalian commentedon Nov 2, 2021
Ah true, I forget we have just one box. Well maybe someday we'll split it like oldDot,

and then perhaps we could implement that logic.
Santhosh-Sellavel commentedon Nov 2, 2021
@chiragsalian
The following changes needed to be done in PR right?
We need to update the placeholder
2109400803here,App/src/pages/RequestCallPage.js
Line 208 in 7f3153a
Update following error messages to new messages given here
App/src/languages/en.js
Line 471 in 7f3153a
App/src/languages/en.js
Line 472 in 7f3153a
For the Request call page box alone or for what other fields?
Do we really need this change? Why would we need a space here?
chiragsalian commentedon Nov 2, 2021
1 and 2 are correct. 3 is not needed. I meant that for the follow-up issue MattAllen created and it looks like he updated the follow-up issue title to reflect the same.
You just need to address your points 1 and 2 for this issue 🙂
Christinadobrzyn commentedon Nov 22, 2021
Looks like the PR is under review - moving forward with this fix!
botify commentedon Nov 29, 2021
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.16-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2021-12-06. 🎊
[-]Request a call modal - Update phone number requirements and instructions. [/-][+][HOLD for payment 2021-12-06] Request a call modal - Update phone number requirements and instructions. [/+]Christinadobrzyn commentedon Dec 7, 2021
Paid @Santhosh-Sellavel in Upwork - closing this job