You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-04-14] [Due for payment 2025-04-10] [Better Expense Report View] } symbol after the amount in Review button #59456
Version Number: 9.1.22-0 Reproducible in staging?: Yes Reproducible in production?: Unable to check, new feature If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail:#58479 Email or phone of affected tester (no customers):applausetester+sdsoidsj@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.3 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Log in with Expensifail account.
Go to staging.new.expensify.com
Go to workspace chat.
Submit two expenses with same amount and merchant.
Click Submit.
Expected Result:
There will be no } symbol after the amount in Review button.
Actual Result:
There is a } symbol after the amount in Review button.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
What changes do you think we should make in order to solve the problem?
Remove the redundant }
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-] [Better Expense Report View] } symbol after the amount in Review button[/-][+][Due for payment 2025-04-10] [Better Expense Report View] } symbol after the amount in Review button[/+]on Apr 3, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.22-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@allgandalf@strepanier03@allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
changed the title [-][Due for payment 2025-04-10] [Better Expense Report View] } symbol after the amount in Review button[/-][+][Due for payment 2025-04-14] [Due for payment 2025-04-10] [Better Expense Report View] } symbol after the amount in Review button[/+]on Apr 7, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.23-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@allgandalf@strepanier03@allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Apr 1, 2025
Triggered auto assignment to @jasperhuangg (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Apr 1, 2025
Triggered auto assignment to @strepanier03 (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Apr 1, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 1, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
mkzie2 commentedon Apr 1, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
There is a } symbol after the amount in Review button.
What is the root cause of that problem?
Redundant } after the copy here:
App/src/languages/en.ts
Line 293 in 90e76b4
What changes do you think we should make in order to solve the problem?
Remove the redundant }
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
15 remaining items
[-] [Better Expense Report View] } symbol after the amount in Review button[/-][+][Due for payment 2025-04-10] [Better Expense Report View] } symbol after the amount in Review button[/+]melvin-bot commentedon Apr 3, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 3, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.22-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-04-10. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 3, 2025
@allgandalf @strepanier03 @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
mountiny commentedon Apr 3, 2025
Payment will be handled on the other issue linked to this PR #59482
[-][Due for payment 2025-04-10] [Better Expense Report View] } symbol after the amount in Review button[/-][+][Due for payment 2025-04-14] [Due for payment 2025-04-10] [Better Expense Report View] } symbol after the amount in Review button[/+]melvin-bot commentedon Apr 7, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.23-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-04-14. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 7, 2025
@allgandalf @strepanier03 @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]