Skip to content

[Due for payment 2025-04-16] [Better Expense Report View] Reply count is not removed together with expense preview after deleting expense #59465

Closed

Description

@vincdargento

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue was found while executing QA for PR #58479

Version Number: 9.1.22-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: #58479
Email or phone of affected tester (no customers): applausetester+sdsoidsj@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Log in with Expensifail account.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Submit a manual expense.
  4. Right click on the expense preview > Reply in thread.
  5. Send a message to the expense report.
  6. Go back to main workspace chat.
  7. Right click on the expense preview > Delete expense.
  8. Delete the expense.

Expected Result:

The reply count will be removed together with the expense preview.

Actual Result:

The reply count is not removed together with the expense preview. The expense preview disappears first, then the reply count disappears.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @garrettmknight

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 1, 2025
  2. melvin-bot commented on Apr 1, 2025

    @melvin-bot

    Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Apr 1, 2025

    @melvin-bot

    Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Apr 1, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Apr 1, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. vincdargento commented on Apr 1, 2025

    @vincdargento
    Author

    @garrettmknight FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  7. removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 1, 2025
  8. grgia commented on Apr 1, 2025

    @grgia
    Contributor

    Demoting, not a blocker

  9. 18 remaining items

  10. allgandalf commented on Apr 6, 2025

    @allgandalf
    Contributor

    PR was merged, good to close after deployment

  11. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Apr 9, 2025
  12. changed the title [-] [Better Expense Report View] Reply count is not removed together with expense preview after deleting expense[/-] [+][Due for payment 2025-04-16] [Better Expense Report View] Reply count is not removed together with expense preview after deleting expense[/+] on Apr 9, 2025
  13. melvin-bot commented on Apr 9, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Apr 9, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.24-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-04-16. 🎊

    For reference, here are some details about the assignees on this issue:

  15. melvin-bot commented on Apr 9, 2025

    @melvin-bot

    @allgandalf @garrettmknight @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  16. mountiny commented on Apr 14, 2025

    @mountiny
    Contributor

    this can be closed as regression tests and payments are handled as whole in the project

  17. moved this from Second Cohort - CRITICAL to Done in [#whatsnext] #migrateon Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions