Skip to content

[Due for payment 2025-04-16] [Due for payment 2025-04-14] [Due for payment 2025-04-10] iOS - Accounting- No fields to enter Netsuite credentials #59476

Closed

Description

@vincdargento

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue was found while executing QA for PR #58537

Version Number: 9.1.22-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: #58537
Email or phone of affected tester (no customers): andreylazutkinutest@gmail.com
Issue reported by: Applause Internal Team
Device used: IPhone 14 Pro Max/ios17
App Component: Other

Action Performed:

  1. Go to Settings > Workspaces > any workspace > Accounting
  2. Connect workspace to NetSuite
  3. Verify you were able to connect with success

Expected Result:

All credentials input fields should be displayed.

Actual Result:

No fields to enter NetSuite credentials: Token Id and Token secret

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @JmillsExpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 1, 2025
  2. melvin-bot commented on Apr 1, 2025

    @melvin-bot

    Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Apr 1, 2025

    @melvin-bot

    Triggered auto assignment to @danieldoglas (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Apr 1, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. vincdargento commented on Apr 1, 2025

    @vincdargento
    Author

    @JmillsExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  6. github-actions commented on Apr 1, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  7. gijoe0295 commented on Apr 1, 2025

    @gijoe0295
    Contributor

    Offending PR: #58645

  8. gijoe0295 commented on Apr 1, 2025

    @gijoe0295
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    No fields to enter Netsuite credentials

    What is the root cause of that problem?

    Offending PR: #58645

    We're using <comment> tag HTML to display each step instruction & field description:

    <RenderHTML html={`<comment><muted-text>${Parser.replace(translate(description))}</muted-text></comment>`} />

    <RenderHTML
    html={`<comment><muted-text>${Parser.replace(
    translate(`workspace.netsuite.tokenInput.formSteps.enterCredentials.${formInput}Description`),
    )}</muted-text></comment>`}
    />

    But <comment> has flex: 1, justifyContent: 'center':

    return {whiteSpace: 'pre', flex: 1, justifyContent: 'center'};

    making it spanning the remaining bottom space and middle align.

    What changes do you think we should make in order to solve the problem?

    Do not use <comment> tag. Just <muted-text> is enough.

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None

    What alternative solutions did you explore? (Optional)

    None

  9. 26 remaining items

  10. melvin-bot commented on Apr 7, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Apr 7, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.23-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-04-14. 🎊

  12. melvin-bot commented on Apr 7, 2025

    @melvin-bot

    @danieldoglas @JmillsExpensify @danieldoglas The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  13. changed the title [-][Due for payment 2025-04-14] [Due for payment 2025-04-10] iOS - Accounting- No fields to enter Netsuite credentials[/-] [+][Due for payment 2025-04-16] [Due for payment 2025-04-14] [Due for payment 2025-04-10] iOS - Accounting- No fields to enter Netsuite credentials[/+] on Apr 9, 2025
  14. melvin-bot commented on Apr 9, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Apr 9, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.24-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-04-16. 🎊

  16. melvin-bot commented on Apr 9, 2025

    @melvin-bot

    @danieldoglas @JmillsExpensify @danieldoglas The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions