Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue was found while executing QA for PR #58537
Version Number: 9.1.22-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: #58537
Email or phone of affected tester (no customers): andreylazutkinutest@gmail.com
Issue reported by: Applause Internal Team
Device used: IPhone 14 Pro Max/ios17
App Component: Other
Action Performed:
- Go to Settings > Workspaces > any workspace > Accounting
- Connect workspace to NetSuite
- Verify you were able to connect with success
Expected Result:
All credentials input fields should be displayed.
Actual Result:
No fields to enter NetSuite credentials: Token Id and Token secret
Workaround:
Unknown
Platforms:
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Activity
melvin-bot commentedon Apr 1, 2025
Triggered auto assignment to @JmillsExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Apr 1, 2025
Triggered auto assignment to @danieldoglas (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Apr 1, 2025
💬 A slack conversation has been started in #expensify-open-source
vincdargento commentedon Apr 1, 2025
@JmillsExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
github-actions commentedon Apr 1, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
gijoe0295 commentedon Apr 1, 2025
Offending PR: #58645
gijoe0295 commentedon Apr 1, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
No fields to enter Netsuite credentials
What is the root cause of that problem?
Offending PR: #58645
We're using
<comment>tag HTML to display each step instruction & field description:App/src/pages/workspace/accounting/netsuite/NetSuiteTokenInput/substeps/NetSuiteTokenSetupContent.tsx
Line 28 in 2e7547b
App/src/pages/workspace/accounting/netsuite/NetSuiteTokenInput/substeps/NetSuiteTokenInputForm.tsx
Lines 83 to 87 in 16465d1
But
<comment>hasflex: 1, justifyContent: 'center':App/src/components/HTMLEngineProvider/BaseHTMLEngineProvider.tsx
Line 65 in c9387ae
making it spanning the remaining bottom space and middle align.
What changes do you think we should make in order to solve the problem?
Do not use
<comment>tag. Just<muted-text>is enough.What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
None
26 remaining items
melvin-bot commentedon Apr 7, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 7, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.23-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-04-14. 🎊
melvin-bot commentedon Apr 7, 2025
@danieldoglas @JmillsExpensify @danieldoglas The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[-][Due for payment 2025-04-14] [Due for payment 2025-04-10] iOS - Accounting- No fields to enter Netsuite credentials[/-][+][Due for payment 2025-04-16] [Due for payment 2025-04-14] [Due for payment 2025-04-10] iOS - Accounting- No fields to enter Netsuite credentials[/+]melvin-bot commentedon Apr 9, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 9, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.24-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-04-16. 🎊
melvin-bot commentedon Apr 9, 2025
@danieldoglas @JmillsExpensify @danieldoglas The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]