Skip to content

[Due for payment 2025-04-18] Expense - Missing label on green button after approving track expense #59878

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.25-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): yonghongkok2+080402kh@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Create a workspace with "Delay submissions" and "Add approvals" enabled.
  • Account has self DM.
  1. Go to staging.new.expensify.com
  2. Go to 1:1 DM.
  3. Track an expense.
  4. Click Share it with my accountant.
  5. Select the workspace from the precondition.
  6. Enter merchant and submit it.
  7. Go to workspace chat.
  8. Click Submit.
  9. Click Approve.

Expected Result:

Green button on the expense preview will have label after approving the track expense.

Actual Result:

Green button on the expense preview is missing label after approving the track expense.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6796821_1744180119350.20250409_130630.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @miljakljajic

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 9, 2025
  2. melvin-bot commented on Apr 9, 2025

    @melvin-bot

    Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Apr 9, 2025

    @melvin-bot

    Triggered auto assignment to @inimaga (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Apr 9, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Apr 9, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. melvin-bot commented on Apr 9, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  7. mountiny commented on Apr 9, 2025

    @mountiny
    Contributor

    Probably shared RCA with #59879

  8. jnowakow commented on Apr 9, 2025

    @jnowakow
    Contributor

    Missing check for reimbrusable spend https://github.com/software-mansion-labs/expensify-app-fork/blob/0754949e02532fb50615e801e5db723a2b4c086a/src/libs/ReportPrimaryActionUtils.ts#L78

        const {reimbursableSpend} = getMoneyRequestSpendBreakdown(report);
    
  9. 18 remaining items

  10. changed the title [-]Expense - Missing label on green button after approving track expense[/-] [+][Due for payment 2025-04-18] Expense - Missing label on green button after approving track expense[/+] on Apr 11, 2025
  11. melvin-bot commented on Apr 11, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Apr 11, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.26-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-04-18. 🎊

    For reference, here are some details about the assignees on this issue:

    • @jnowakow does not require payment (Contractor)
  13. melvin-bot commented on Apr 11, 2025

    @melvin-bot

    @luacmartins / @inimaga @miljakljajic @jnowakow The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. melvin-bot commented on Apr 18, 2025

    @melvin-bot

    Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

  15. miljakljajic commented on Apr 22, 2025

    @miljakljajic
    Contributor

    Closing as everyone is an employee/vendor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions