You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-04-18] Expense - Missing label on green button after approving track expense #59878
Version Number: 9.1.25-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):yonghongkok2+080402kh@gmail.com Issue reported by: Applause Internal Team Device used: Mac 15.3 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Create a workspace with "Delay submissions" and "Add approvals" enabled.
Account has self DM.
Go to staging.new.expensify.com
Go to 1:1 DM.
Track an expense.
Click Share it with my accountant.
Select the workspace from the precondition.
Enter merchant and submit it.
Go to workspace chat.
Click Submit.
Click Approve.
Expected Result:
Green button on the expense preview will have label after approving the track expense.
Actual Result:
Green button on the expense preview is missing label after approving the track expense.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-]Expense - Missing label on green button after approving track expense[/-][+][Due for payment 2025-04-18] Expense - Missing label on green button after approving track expense[/+]on Apr 11, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.26-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@luacmartins / @inimaga@miljakljajic@jnowakow The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
Activity
melvin-bot commentedon Apr 9, 2025
Triggered auto assignment to @miljakljajic (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Apr 9, 2025
Triggered auto assignment to @inimaga (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Apr 9, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 9, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Apr 9, 2025
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
mountiny commentedon Apr 9, 2025
Probably shared RCA with #59879
jnowakow commentedon Apr 9, 2025
Missing check for reimbrusable spend https://github.com/software-mansion-labs/expensify-app-fork/blob/0754949e02532fb50615e801e5db723a2b4c086a/src/libs/ReportPrimaryActionUtils.ts#L78
18 remaining items
[-]Expense - Missing label on green button after approving track expense[/-][+][Due for payment 2025-04-18] Expense - Missing label on green button after approving track expense[/+]melvin-bot commentedon Apr 11, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 11, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.26-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-04-18. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 11, 2025
@luacmartins / @inimaga @miljakljajic @jnowakow The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Apr 18, 2025
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
miljakljajic commentedon Apr 22, 2025
Closing as everyone is an employee/vendor.