Skip to content

[Due for payment 2025-04-18] [$250] Approve button is present when expense report has no expense, empty green button is present #59880

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.25-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): jdsoijsomsjd@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • "Delay submissions" (set to Manually) and "Add approvals" are enabled.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Submit an expense.
  4. Click Submit.
  5. Click on the expense preview.
  6. Send a message to the expense report.
  7. Go offline.
  8. Click More > Delete expense.
  9. Delete the expense.
  10. Click Approve.

Expected Result:

In Step 10, Approve button should not be present when there is no more expense.

Actual Result:

In Step 10, Approve button is present when there is no more expense.
After approving the expense, there is a green button with no purpose.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6796823_1744180128699.20250409_124649.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021909929813119397026
  • Upwork Job ID: 1909929813119397026
  • Last Price Increase: 2025-04-09
  • Automatic offers:
    • nkdengineer | Contributor | 106851017
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @abekkala

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 9, 2025
  2. melvin-bot commented on Apr 9, 2025

    @melvin-bot

    Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Apr 9, 2025

    @melvin-bot

    Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Apr 9, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Apr 9, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. mountiny commented on Apr 9, 2025

    @mountiny
    Contributor
  7. rayane-d commented on Apr 9, 2025

    @rayane-d
    Contributor
  8. MariaHCD commented on Apr 9, 2025

    @MariaHCD
    Contributor

    👋🏼 Hey, team. Is this caused by a specific PR? Are we planning to revert or do we have a fix in mind for this?

  9. 38 remaining items

  10. changed the title [-][$250] Approve button is present when expense report has no expense, empty green button is present[/-] [+][Due for payment 2025-04-18] [$250] Approve button is present when expense report has no expense, empty green button is present[/+] on Apr 11, 2025
  11. melvin-bot commented on Apr 11, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Apr 11, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.26-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-04-18. 🎊

    For reference, here are some details about the assignees on this issue:

  13. melvin-bot commented on Apr 11, 2025

    @melvin-bot

    @jjcoffee @abekkala @jjcoffee The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. abekkala commented on Apr 21, 2025

    @abekkala
    Contributor

    PAYMENT SUMMARY

  15. garrettmknight commented on Apr 28, 2025

    @garrettmknight
    Contributor

    $250 approved for @jjcoffee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions