You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-04-18] [$250] Approve button is present when expense report has no expense, empty green button is present #59880
Version Number: 9.1.25-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):jdsoijsomsjd@gmail.com Issue reported by: Applause Internal Team Device used: Mac 15.3 / Chrome App Component: Money Requests
Action Performed:
Precondition:
"Delay submissions" (set to Manually) and "Add approvals" are enabled.
Go to staging.new.expensify.com
Go to workspace chat.
Submit an expense.
Click Submit.
Click on the expense preview.
Send a message to the expense report.
Go offline.
Click More > Delete expense.
Delete the expense.
Click Approve.
Expected Result:
In Step 10, Approve button should not be present when there is no more expense.
Actual Result:
In Step 10, Approve button is present when there is no more expense.
After approving the expense, there is a green button with no purpose.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-][$250] Approve button is present when expense report has no expense, empty green button is present[/-][+][Due for payment 2025-04-18] [$250] Approve button is present when expense report has no expense, empty green button is present[/+]on Apr 11, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.26-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@jjcoffee@abekkala@jjcoffee The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Apr 9, 2025
Triggered auto assignment to @MariaHCD (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Apr 9, 2025
Triggered auto assignment to @abekkala (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Apr 9, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 9, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
mountiny commentedon Apr 9, 2025
@suneox @jnowakow @rayane-d @luacmartins
rayane-d commentedon Apr 9, 2025
cc @mananjadhav
MariaHCD commentedon Apr 9, 2025
👋🏼 Hey, team. Is this caused by a specific PR? Are we planning to revert or do we have a fix in mind for this?
38 remaining items
[-][$250] Approve button is present when expense report has no expense, empty green button is present[/-][+][Due for payment 2025-04-18] [$250] Approve button is present when expense report has no expense, empty green button is present[/+]melvin-bot commentedon Apr 11, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 11, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.26-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-04-18. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 11, 2025
@jjcoffee @abekkala @jjcoffee The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
abekkala commentedon Apr 21, 2025
PAYMENT SUMMARY
garrettmknight commentedon Apr 28, 2025
$250 approved for @jjcoffee