You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-04-18] [Due for payment 2025-04-17] [$250] Empty green button after paying with Expensify and waiting for member to add bank account #59886
Version Number: 9.1.25-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only If this was caught during regression testing, add the test name, ID and link from TestRail: Exp #58783 Email or phone of affected tester (no customers):yonghongkok2+boss2@gmail.com Issue reported by: Applause Internal Team Device used: Mac 15.3 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Admin and employee are in the same workspace.
Workspace is set up with bank account.
Employee does not have personal bank account.
Go to staging.new.expensify.com
[Employee] Submit an expense to the workspace chat.
[Admin] Go to workspace chat with employee.
[Admin] Go to expense report.
[Admin] Click More > Submit.
[Admin] Click Approve.
[Admin} Click Pay with Expensify.
Expected Result:
There will be no green button after paying with Expensify and waiting for employee to add bank account.
Actual Result:
There is an empty green button after paying with Expensify and waiting for employee to add bank account.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-]Empty green button after paying with Expensify and waiting for member to add bank account[/-][+][$250] Empty green button after paying with Expensify and waiting for member to add bank account[/+]on Apr 9, 2025
changed the title [-][Due for payment 2025-04-17] [$250] Empty green button after paying with Expensify and waiting for member to add bank account[/-][+][Due for payment 2025-04-18] [Due for payment 2025-04-17] [$250] Empty green button after paying with Expensify and waiting for member to add bank account[/+]on Apr 11, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.26-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@ZhenjaHorbach@jliexpensify@ZhenjaHorbach The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
This issue came from Simplified Actions on Report Header and Preview feature. Which was later reverted
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
I'm not sure that tests are needed here
Because when we fixed it
Later Simplified Actions on Report Header and Preview feature was reversed due to a large number of issues
So technically this feature doesn't exist yet !
Activity
melvin-bot commentedon Apr 9, 2025
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Apr 9, 2025
Triggered auto assignment to @Gonals (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Apr 9, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 9, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Apr 9, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021909898126160643118
[-]Empty green button after paying with Expensify and waiting for member to add bank account[/-][+][$250] Empty green button after paying with Expensify and waiting for member to add bank account[/+]38 remaining items
[-][Due for payment 2025-04-17] [$250] Empty green button after paying with Expensify and waiting for member to add bank account[/-][+][Due for payment 2025-04-18] [Due for payment 2025-04-17] [$250] Empty green button after paying with Expensify and waiting for member to add bank account[/+]melvin-bot commentedon Apr 11, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.26-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-04-18. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 11, 2025
@ZhenjaHorbach @jliexpensify @ZhenjaHorbach The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
jliexpensify commentedon Apr 15, 2025
Bump @ZhenjaHorbach for the checklist please!
ZhenjaHorbach commentedon Apr 16, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
This issue came from Simplified Actions on Report Header and Preview feature. Which was later reverted
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
I'm not sure that tests are needed here
Because when we fixed it
Later Simplified Actions on Report Header and Preview feature was reversed due to a large number of issues
So technically this feature doesn't exist yet !
jliexpensify commentedon Apr 16, 2025
Fair enough, thanks for completing the checklist!
jliexpensify commentedon Apr 18, 2025
Payment Summary
Upwork job
jliexpensify commentedon Apr 18, 2025
Paid and job closed!