Skip to content

[Due for payment 2025-04-18] [Due for payment 2025-04-17] [$250] Empty green button after paying with Expensify and waiting for member to add bank account #59886

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.25-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp #58783
Email or phone of affected tester (no customers): yonghongkok2+boss2@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Admin and employee are in the same workspace.
  • Workspace is set up with bank account.
  • Employee does not have personal bank account.
  1. Go to staging.new.expensify.com
  2. [Employee] Submit an expense to the workspace chat.
  3. [Admin] Go to workspace chat with employee.
  4. [Admin] Go to expense report.
  5. [Admin] Click More > Submit.
  6. [Admin] Click Approve.
  7. [Admin} Click Pay with Expensify.

Expected Result:

There will be no green button after paying with Expensify and waiting for employee to add bank account.

Actual Result:

There is an empty green button after paying with Expensify and waiting for employee to add bank account.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6796839_1744181681052.20250409_145120.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021909898126160643118
  • Upwork Job ID: 1909898126160643118
  • Last Price Increase: 2025-04-09
  • Automatic offers:
    • ZhenjaHorbach | Reviewer | 106849051
    • daledah | Contributor | 106849057
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @jliexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 9, 2025
  2. melvin-bot commented on Apr 9, 2025

    @melvin-bot

    Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Apr 9, 2025

    @melvin-bot

    Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Apr 9, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Apr 9, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 9, 2025
  7. melvin-bot commented on Apr 9, 2025

    @melvin-bot
  8. changed the title [-]Empty green button after paying with Expensify and waiting for member to add bank account[/-] [+][$250] Empty green button after paying with Expensify and waiting for member to add bank account[/+] on Apr 9, 2025
  9. 38 remaining items

  10. changed the title [-][Due for payment 2025-04-17] [$250] Empty green button after paying with Expensify and waiting for member to add bank account[/-] [+][Due for payment 2025-04-18] [Due for payment 2025-04-17] [$250] Empty green button after paying with Expensify and waiting for member to add bank account[/+] on Apr 11, 2025
  11. melvin-bot commented on Apr 11, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.26-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-04-18. 🎊

    For reference, here are some details about the assignees on this issue:

  12. melvin-bot commented on Apr 11, 2025

    @melvin-bot

    @ZhenjaHorbach @jliexpensify @ZhenjaHorbach The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  13. jliexpensify commented on Apr 15, 2025

    @jliexpensify
    Contributor

    Bump @ZhenjaHorbach for the checklist please!

  14. ZhenjaHorbach commented on Apr 16, 2025

    @ZhenjaHorbach
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      This issue came from Simplified Actions on Report Header and Preview feature. Which was later reverted

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: NA

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    I'm not sure that tests are needed here
    Because when we fixed it
    Later Simplified Actions on Report Header and Preview feature was reversed due to a large number of issues
    So technically this feature doesn't exist yet !

  15. jliexpensify commented on Apr 16, 2025

    @jliexpensify
    Contributor

    Fair enough, thanks for completing the checklist!

  16. jliexpensify commented on Apr 18, 2025

    @jliexpensify
    Contributor

    Payment Summary

    Upwork job

  17. jliexpensify commented on Apr 18, 2025

    @jliexpensify
    Contributor

    Paid and job closed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions