You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-04-18] Expense - "Review" button is still displayed for admin and employee after expense is paid #59912
Version Number: 9.1.25-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):sdmoisdjoidsio@gmail.com Issue reported by: Applause Internal Team Device used: Mac 15.3 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Log in with Gmail accounts.
Admin and employees are in the same workspace.
"Members must categorize all expenses" toggle is enabled in Categories settings.
Go to staging.new.expensify.com
[Employee] Submit an expense without category to the workspace chat.
[Employee] Go to expense report.
[Employee] Click More > Submit.
[Admin] Go to workspace chat with employee.
[Admin] Go to expense report.
[Admin] Click Approve.
[Admin] Click Pay elsewhere.
[Admin & Employee] Go back to main workspace chat.
Expected Result:
"Review" button will not be displayed for admin and employee after expense is paid.
Actual Result:
"Review" button is still displayed for admin and employee after expense is paid.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@jnowakow I can reproduce this. The violation will not be cleared after we have paid the expense. I think we should update the canReview function with adding !isSettled(report)
changed the title [-]Expense - "Review" button is still displayed for admin and employee after expense is paid[/-][+][Due for payment 2025-04-18] Expense - "Review" button is still displayed for admin and employee after expense is paid[/+]on Apr 11, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.26-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@luacmartins@RachCHopkins@jnowakow The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Following question is going to only touch the report previews on reports/transactions that have violations
I've educated myself on the design doc and I see 3 cases here:
We have a workspace connected to the integration and auto-sync is enabled, according to the doc:
In the case of approved, reimbursed, or closed reports with an accounting system connected via auto-sync, admins see: (...) View in the workspace chat preview and Reports (w/ and w/o violations)
So basically we never show review in this case(for admins, but I suppose it also applies to emplyees)
We have a workspace connected to the integration and auto-sync is disabled, according to the doc:
In the case of approved, reimbursed, or closed reports with an accounting system connected via manual sync, the preferred exporter sees (...) Review in the workspace chat preview and Reports (w/ violations)
So we show review even though the report is reimbruised
We have a workspace with no accounting:
This case lacks description in the doc, should we never show the Review, onve the report is reimbruised @luacmartins?
So basically we never show review in this case(for admins, but I suppose it also applies to emplyees)
Correct, but only if the report has been approved or reimbursed or closed.
So we show review even though the report is reimbruised
Also correct.
We have a workspace with no accounting:
This case lacks description in the doc, should we never show the Review, onve the report is reimbruised @luacmartins?
I think in this case we just default to showing the Review button, same as the case above. I'm confirming this one with the team though.
Activity
melvin-bot commentedon Apr 9, 2025
Triggered auto assignment to @RachCHopkins (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Apr 9, 2025
Triggered auto assignment to @dangrous (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Apr 9, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 9, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
jnowakow commentedon Apr 9, 2025
I'm not able to reproduce it:
nkdengineer commentedon Apr 9, 2025
@jnowakow I can reproduce this. The violation will not be cleared after we have paid the expense. I think we should update the
canReviewfunction with adding!isSettled(report)App/src/libs/ReportPreviewActionUtils.ts
Line 83 in 56752a1
15 remaining items
[-]Expense - "Review" button is still displayed for admin and employee after expense is paid[/-][+][Due for payment 2025-04-18] Expense - "Review" button is still displayed for admin and employee after expense is paid[/+]melvin-bot commentedon Apr 11, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 11, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.26-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-04-18. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 11, 2025
@luacmartins @RachCHopkins @jnowakow The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
SzymczakJ commentedon Apr 11, 2025
Following question is going to only touch the report previews on reports/transactions that have violations
I've educated myself on the design doc and I see 3 cases here:
So basically we never show review in this case(for admins, but I suppose it also applies to emplyees)
So we show review even though the report is reimbruised
This case lacks description in the doc, should we never show the Review, onve the report is reimbruised @luacmartins?
luacmartins commentedon Apr 11, 2025
Correct, but only if the report has been approved or reimbursed or closed.
Also correct.
I think in this case we just default to showing the
Reviewbutton, same as the case above. I'm confirming this one with the team though.luacmartins commentedon Apr 11, 2025
@SzymczakJ I talked to @JmillsExpensify 1:1 and we agreed on:
Always show
Reviewif there's a violation up until the point the report has been reimbursed, at which point we just showView. So basically:Auto-sync on
Manual sync
JmillsExpensify commentedon Apr 11, 2025
Great questions btw, thanks for helping us clear this up! I'll update the doc accordingly for clarity.