Skip to content

[Due for payment 2025-04-18] Expense - "Review" button is still displayed for admin and employee after expense is paid #59912

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.25-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): sdmoisdjoidsio@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Log in with Gmail accounts.
  • Admin and employees are in the same workspace.
  • "Members must categorize all expenses" toggle is enabled in Categories settings.
  1. Go to staging.new.expensify.com
  2. [Employee] Submit an expense without category to the workspace chat.
  3. [Employee] Go to expense report.
  4. [Employee] Click More > Submit.
  5. [Admin] Go to workspace chat with employee.
  6. [Admin] Go to expense report.
  7. [Admin] Click Approve.
  8. [Admin] Click Pay elsewhere.
  9. [Admin & Employee] Go back to main workspace chat.

Expected Result:

"Review" button will not be displayed for admin and employee after expense is paid.

Actual Result:

"Review" button is still displayed for admin and employee after expense is paid.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6797005_1744193133926.20250409_175800.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @RachCHopkins

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 9, 2025
  2. melvin-bot commented on Apr 9, 2025

    @melvin-bot

    Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Apr 9, 2025

    @melvin-bot

    Triggered auto assignment to @dangrous (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Apr 9, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Apr 9, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. jnowakow commented on Apr 9, 2025

    @jnowakow
    Contributor

    I'm not able to reproduce it:

    Image
  7. nkdengineer commented on Apr 9, 2025

    @nkdengineer
    Contributor

    @jnowakow I can reproduce this. The violation will not be cleared after we have paid the expense. I think we should update the canReview function with adding !isSettled(report)

    return hasViolations && (isSubmitter || isApprover) && areWorkflowsEnabled;

    Image
  8. 15 remaining items

  9. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Apr 11, 2025
  10. changed the title [-]Expense - "Review" button is still displayed for admin and employee after expense is paid[/-] [+][Due for payment 2025-04-18] Expense - "Review" button is still displayed for admin and employee after expense is paid[/+] on Apr 11, 2025
  11. melvin-bot commented on Apr 11, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Apr 11, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.26-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-04-18. 🎊

    For reference, here are some details about the assignees on this issue:

    • @jnowakow does not require payment (Contractor)
  13. melvin-bot commented on Apr 11, 2025

    @melvin-bot

    @luacmartins @RachCHopkins @jnowakow The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. SzymczakJ commented on Apr 11, 2025

    @SzymczakJ
    Contributor

    Following question is going to only touch the report previews on reports/transactions that have violations

    I've educated myself on the design doc and I see 3 cases here:

    1. We have a workspace connected to the integration and auto-sync is enabled, according to the doc:

    In the case of approved, reimbursed, or closed reports with an accounting system connected via auto-sync, admins see: (...) View in the workspace chat preview and Reports (w/ and w/o violations)

    So basically we never show review in this case(for admins, but I suppose it also applies to emplyees)

    1. We have a workspace connected to the integration and auto-sync is disabled, according to the doc:

    In the case of approved, reimbursed, or closed reports with an accounting system connected via manual sync, the preferred exporter sees (...) Review in the workspace chat preview and Reports (w/ violations)

    So we show review even though the report is reimbruised

    1. We have a workspace with no accounting:

    This case lacks description in the doc, should we never show the Review, onve the report is reimbruised @luacmartins?

  15. luacmartins commented on Apr 11, 2025

    @luacmartins
    Contributor

    So basically we never show review in this case(for admins, but I suppose it also applies to emplyees)

    Correct, but only if the report has been approved or reimbursed or closed.

    So we show review even though the report is reimbruised

    Also correct.

    We have a workspace with no accounting:
    This case lacks description in the doc, should we never show the Review, onve the report is reimbruised @luacmartins?

    I think in this case we just default to showing the Review button, same as the case above. I'm confirming this one with the team though.

  16. luacmartins commented on Apr 11, 2025

    @luacmartins
    Contributor

    @SzymczakJ I talked to @JmillsExpensify 1:1 and we agreed on:

    Always show Review if there's a violation up until the point the report has been reimbursed, at which point we just show View. So basically:

    Auto-sync on

    • Review: If report is open, processing, or approved AND has violations
    • View: All other report states, whether violations or not.

    Manual sync

    • Review: If report is open, processing, or approved AND has violations
    • Export to...: All other report states, whether violations or not.
  17. JmillsExpensify commented on Apr 11, 2025

    @JmillsExpensify
    Contributor

    Great questions btw, thanks for helping us clear this up! I'll update the doc accordingly for clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions