Skip to content

[Due for payment 2025-04-18] [$250] Expense - Review button is disabled when "Prevent self-approvals" is enabled #59928

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.25-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): yonghongkok2+wanda@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Log in with Gmail accounts.
  • Create a new workspace with "Delay submissions" and "Add approvals" enabled.
  • "Members must categorize all expenses" toggle is enabled in Categories settings.
  • "Prevent self-approvals" is enabled in workspace settings > Rules.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Submit an expense without category to the workspace chat.
  4. Click Review button.

Expected Result:

Review button should not be disabled because it opens expense report.

Actual Result:

Review button is disabled when "Prevent self-approvals" is enabled.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021909998695172883503
  • Upwork Job ID: 1909998695172883503
  • Last Price Increase: 2025-04-09
  • Automatic offers:
    • daledah | Contributor | 106853886
Issue OwnerCurrent Issue Owner: @sakluger

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 9, 2025
  2. melvin-bot commented on Apr 9, 2025

    @melvin-bot

    Triggered auto assignment to @marcochavezf (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Apr 9, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. melvin-bot commented on Apr 9, 2025

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. github-actions commented on Apr 9, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. daledah commented on Apr 9, 2025

    @daledah
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Review button is disabled when "Prevent self-approvals" is enabled.

    What is the root cause of that problem?

    We disabled the review button here

    [CONST.REPORT.REPORT_PREVIEW_ACTIONS.REVIEW]: (
    <Button
    text={translate('common.review')}
    onPress={() => openReportFromPreview()}
    isDisabled={shouldDisableSubmitButton}
    icon={Expensicons.DotIndicator}
    iconFill={theme.danger}
    iconHoverFill={theme.dangerHover}
    />
    ),

    What changes do you think we should make in order to solve the problem?

    We should remove this isDisabled props because it opens expense report.

    [CONST.REPORT.REPORT_PREVIEW_ACTIONS.REVIEW]: (
    <Button
    text={translate('common.review')}
    onPress={() => openReportFromPreview()}
    isDisabled={shouldDisableSubmitButton}
    icon={Expensicons.DotIndicator}
    iconFill={theme.danger}
    iconHoverFill={theme.dangerHover}
    />
    ),

    Also need to remove in View button

    [CONST.REPORT.REPORT_PREVIEW_ACTIONS.VIEW]: (
    <Button
    text={translate('common.view')}
    onPress={() => {
    openReportFromPreview();
    }}
    isDisabled={shouldDisableSubmitButton}
    />

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  7. daledah commented on Apr 9, 2025

    @daledah
    Contributor

    @marcochavezf i can help to raise a quick PR if needed

  8. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 9, 2025
  9. 16 remaining items

  10. sakluger commented on Apr 9, 2025

    @sakluger
    Contributor

    I agree that 50% payment is fair since the PR didn't request a review.

    @daledah if you agree, please let us know. We can send a new offer, or if accept the original offer, we can adjust the payout on the same offer. I can still confirm that the job was completed after adjusting the payout amount, so it shouldn't affect your Upwork reputation/rating either way. Let me know what you'd prefer.

  11. daledah commented on Apr 10, 2025

    @daledah
    Contributor

    I agree that 50% payment is fair

    @sakluger I'm good with this, thanks. I accepted the original offer.

  12. sakluger commented on Apr 10, 2025

    @sakluger
    Contributor

    Thanks, all paid!

  13. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Apr 11, 2025
  14. changed the title [-][$250] Expense - Review button is disabled when "Prevent self-approvals" is enabled[/-] [+][Due for payment 2025-04-18] [$250] Expense - Review button is disabled when "Prevent self-approvals" is enabled[/+] on Apr 11, 2025
  15. melvin-bot commented on Apr 11, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.26-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-04-18. 🎊

    For reference, here are some details about the assignees on this issue:

  16. melvin-bot commented on Apr 11, 2025

    @melvin-bot

    @c3024 @sakluger @c3024 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions