You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-04-18] [$250] Expense - Review button is disabled when "Prevent self-approvals" is enabled #59928
Version Number: 9.1.25-1 Reproducible in staging?: Yes Reproducible in production?: No If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):yonghongkok2+wanda@gmail.com Issue reported by: Applause Internal Team Device used: Mac 15.3 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Log in with Gmail accounts.
Create a new workspace with "Delay submissions" and "Add approvals" enabled.
"Members must categorize all expenses" toggle is enabled in Categories settings.
"Prevent self-approvals" is enabled in workspace settings > Rules.
Go to staging.new.expensify.com
Go to workspace chat.
Submit an expense without category to the workspace chat.
Click Review button.
Expected Result:
Review button should not be disabled because it opens expense report.
Actual Result:
Review button is disabled when "Prevent self-approvals" is enabled.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
I agree that 50% payment is fair since the PR didn't request a review.
@daledah if you agree, please let us know. We can send a new offer, or if accept the original offer, we can adjust the payout on the same offer. I can still confirm that the job was completed after adjusting the payout amount, so it shouldn't affect your Upwork reputation/rating either way. Let me know what you'd prefer.
changed the title [-][$250] Expense - Review button is disabled when "Prevent self-approvals" is enabled[/-][+][Due for payment 2025-04-18] [$250] Expense - Review button is disabled when "Prevent self-approvals" is enabled[/+]on Apr 11, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.26-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@c3024@sakluger@c3024 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Apr 9, 2025
Triggered auto assignment to @marcochavezf (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Apr 9, 2025
💬 A slack conversation has been started in #expensify-open-source
melvin-bot commentedon Apr 9, 2025
Triggered auto assignment to @sakluger (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Apr 9, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
daledah commentedon Apr 9, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Review button is disabled when "Prevent self-approvals" is enabled.
What is the root cause of that problem?
We disabled the review button here
App/src/components/ReportActionItem/ReportPreview.tsx
Lines 565 to 574 in 1390c29
What changes do you think we should make in order to solve the problem?
We should remove this
isDisabledprops because it opens expense report.App/src/components/ReportActionItem/ReportPreview.tsx
Lines 565 to 574 in 1390c29
Also need to remove in
ViewbuttonApp/src/components/ReportActionItem/ReportPreview.tsx
Lines 575 to 582 in 1390c29
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
daledah commentedon Apr 9, 2025
@marcochavezf i can help to raise a quick PR if needed
16 remaining items
sakluger commentedon Apr 9, 2025
I agree that 50% payment is fair since the PR didn't request a review.
@daledah if you agree, please let us know. We can send a new offer, or if accept the original offer, we can adjust the payout on the same offer. I can still confirm that the job was completed after adjusting the payout amount, so it shouldn't affect your Upwork reputation/rating either way. Let me know what you'd prefer.
daledah commentedon Apr 10, 2025
@sakluger I'm good with this, thanks. I accepted the original offer.
sakluger commentedon Apr 10, 2025
Thanks, all paid!
[-][$250] Expense - Review button is disabled when "Prevent self-approvals" is enabled[/-][+][Due for payment 2025-04-18] [$250] Expense - Review button is disabled when "Prevent self-approvals" is enabled[/+]melvin-bot commentedon Apr 11, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.26-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-04-18. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 11, 2025
@c3024 @sakluger @c3024 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]