You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Offline mode] Making changes on settings options while offline, leads to infinite loading - Reported by: @Santhosh-Sellavel & @adeel0202 #5994
User should be blocked from uploading a new profile picture or changing the password while offline
If the user is allowed to upload a profile picture while offline there should be a warning message like "You're offline! The picture will finish uploading once internet connection is regained."
Actual Result:
Infinite loading is displayed and there's no warning letting know the user picture will finish the upload once connection is back. For password scenario there's just an infinite loader and no error message about being offline.
Workaround:
If connection is regained, the upload finishes
Platform:
Where is this issue occurring?
Web
iOS
Android
Desktop App
Mobile Web
Version Number: 1.1.8-8
Reproducible in staging?: Yes Reproducible in production?: Yes
changed the title [-]User is able to select the option to upload a profile picture while offline, leads to infinite loading - Reported by: @Santhosh-Sellavel [/-][+]Making changes on settings options while offline, leads to infinite loading - Reported by: @Santhosh-Sellavel [/+]on Oct 22, 2021
Ok. I think we should close this issue, as the feature simply did not exist when it was reported. We intended to build offline mode for a long time, but did not prioritize it until recently - and so I kept this GH open as a placeholder of sorts.
But I think deficiency existed innately and shouldn't be paid for that reason (e.g. there were hundreds/thousands of offline mode things that could be "reported" but it's just attributed to the fact that offline functionality didn't exist).
Let me know if you disagree and we can discuss this further.
@michaelhaxhiu, the bug I reported here was not related to offline mode. I reported the bug that if you close the app when your profile photo is still uploading and open the app again then you can see an infinite loader on your avatar. @roryabraham in his comment here said that the bug I reported and this offline-related bug both will have the same solution which is why that ticket was closed. I think I'm eligible for the reporting bonus.
Activity
MelvinBot commentedon Oct 22, 2021
Triggered auto assignment to @AndrewGable (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.[-]User is able to select the option to upload a profile picture while offline, leads to infinite loading - Reported by: @Santhosh-Sellavel [/-][+]Making changes on settings options while offline, leads to infinite loading - Reported by: @Santhosh-Sellavel [/+]MelvinBot commentedon Oct 25, 2021
@AndrewGable Whoops! This issue is 2 days overdue. Let's get this updated quick!
MelvinBot commentedon Oct 25, 2021
Triggered auto assignment to @michaelhaxhiu (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.70 remaining items
michaelhaxhiu commentedon May 12, 2022
not overdue
michaelhaxhiu commentedon May 12, 2022
Ok. I think we should close this issue, as the feature simply did not exist when it was reported. We intended to build offline mode for a long time, but did not prioritize it until recently - and so I kept this GH open as a placeholder of sorts.
But I think deficiency existed innately and shouldn't be paid for that reason (e.g. there were hundreds/thousands of offline mode things that could be "reported" but it's just attributed to the fact that offline functionality didn't exist).
Let me know if you disagree and we can discuss this further.
adeel0202 commentedon May 13, 2022
@michaelhaxhiu, the bug I reported here was not related to offline mode. I reported the bug that if you close the app when your profile photo is still uploading and open the app again then you can see an infinite loader on your avatar. @roryabraham in his comment here said that the bug I reported and this offline-related bug both will have the same solution which is why that ticket was closed. I think I'm eligible for the reporting bonus.
michaelhaxhiu commentedon May 13, 2022
@adeel0202 thanks for the additional context, i didn't have a chance to re-read that thread until now and agree.
We'll pay you and @Santhosh-Sellavel the reporting bonus, and close this out.
michaelhaxhiu commentedon May 13, 2022
Can you both apply for this job on upwork, please:
https://www.upwork.com/jobs/~0107f0fd48c51cf271
adeel0202 commentedon May 13, 2022
Thanks @michaelhaxhiu. I have applied.
michaelhaxhiu commentedon May 13, 2022
Re-opening, as this hasn't been paid yet.
michaelhaxhiu commentedon May 17, 2022
paid and closing.