Skip to content

[Offline mode] Making changes on settings options while offline, leads to infinite loading - Reported by: @Santhosh-Sellavel & @adeel0202 #5994

Closed

Description

@isagoico

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Profile

  1. Kill the internet connection
  2. Navigate to profile settings
  3. Click on upload a profile picture
  4. Select any image

Change password

  1. Kill the internet connection
  2. Navigate to Change password
  3. Enter correct information in the fields
  4. Press save

Expected Result:

2 options could be expected behaviour:

  1. User should be blocked from uploading a new profile picture or changing the password while offline
  2. If the user is allowed to upload a profile picture while offline there should be a warning message like "You're offline! The picture will finish uploading once internet connection is regained."

Actual Result:

Infinite loading is displayed and there's no warning letting know the user picture will finish the upload once connection is back. For password scenario there's just an infinite loader and no error message about being offline.

Workaround:

If connection is regained, the upload finishes

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.8-8

Reproducible in staging?: Yes
Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

This could be applied to workspace picture too

Recording.232.mp4

Upwork job link: https://www.upwork.com/jobs/~012e3c46ca310d27fc
Issue reported by: @Santhosh-Sellavel (also @adeel0202, see #5994 (comment))
Slack conversation: #5 on https://expensify.slack.com/archives/C01GTK53T8Q/p1634765738025300

View all open jobs on GitHub

Activity

  1. MelvinBot commented on Oct 22, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  2. changed the title [-]User is able to select the option to upload a profile picture while offline, leads to infinite loading - Reported by: @Santhosh-Sellavel [/-] [+]Making changes on settings options while offline, leads to infinite loading - Reported by: @Santhosh-Sellavel [/+] on Oct 22, 2021
  3. MelvinBot commented on Oct 25, 2021

    @MelvinBot
    Contributor

    @AndrewGable Whoops! This issue is 2 days overdue. Let's get this updated quick!

  4. removed their assignment
    on Oct 25, 2021
  5. MelvinBot commented on Oct 25, 2021

    @MelvinBot
    Contributor

    Triggered auto assignment to @michaelhaxhiu (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  6. 70 remaining items

  7. michaelhaxhiu commented on May 12, 2022

    @michaelhaxhiu
    Contributor

    not overdue

  8. michaelhaxhiu commented on May 12, 2022

    @michaelhaxhiu
    Contributor

    Ok. I think we should close this issue, as the feature simply did not exist when it was reported. We intended to build offline mode for a long time, but did not prioritize it until recently - and so I kept this GH open as a placeholder of sorts.

    But I think deficiency existed innately and shouldn't be paid for that reason (e.g. there were hundreds/thousands of offline mode things that could be "reported" but it's just attributed to the fact that offline functionality didn't exist).

    Let me know if you disagree and we can discuss this further.

  9. adeel0202 commented on May 13, 2022

    @adeel0202
    Contributor

    @michaelhaxhiu, the bug I reported here was not related to offline mode. I reported the bug that if you close the app when your profile photo is still uploading and open the app again then you can see an infinite loader on your avatar. @roryabraham in his comment here said that the bug I reported and this offline-related bug both will have the same solution which is why that ticket was closed. I think I'm eligible for the reporting bonus.

  10. michaelhaxhiu commented on May 13, 2022

    @michaelhaxhiu
    Contributor

    @adeel0202 thanks for the additional context, i didn't have a chance to re-read that thread until now and agree.

    We'll pay you and @Santhosh-Sellavel the reporting bonus, and close this out.

  11. michaelhaxhiu commented on May 13, 2022

    @michaelhaxhiu
    Contributor

    Can you both apply for this job on upwork, please:

    https://www.upwork.com/jobs/~0107f0fd48c51cf271

  12. adeel0202 commented on May 13, 2022

    @adeel0202
    Contributor

    Thanks @michaelhaxhiu. I have applied.

  13. michaelhaxhiu commented on May 13, 2022

    @michaelhaxhiu
    Contributor

    Re-opening, as this hasn't been paid yet.

  14. michaelhaxhiu commented on May 17, 2022

    @michaelhaxhiu
    Contributor

    paid and closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

EngineeringExternalAdded to denote the issue can be worked on by a contributorMonthlyKSv2PlanningChanges still in the thought process

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions