You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Review duplicates - Nothing happens after clicking Confirm when second expense is selected #59970
Version Number: 9.1.26-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):jsdjosjojisodjosdj@gmail.com Issue reported by: Applause Internal Team Device used: Mac 15.3 / Chrome App Component: Money Requests
Action Performed:
Go to staging.new.expensify.com
Go to workspace chat.
Submit two expenses with the same amount and merchant.
Go to transaction thread of the second expense.
Click Review duplicates.
Click Keep on this on the second expense in the list (important).
Click Confirm.
Expected Result:
After clicking Confirm button, RHP will dismiss.
Actual Result:
Nothing happens after clicking Confirm button when the second expense is selected.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Is it possible to pass to the MergeDuplicates optimistic transaction thread report id? This way the app would know what thread report to expect and can handle correct navigation.
It doesn't accept one right now, but seems like an easy change.
Activity
melvin-bot commentedon Apr 10, 2025
Triggered auto assignment to @mollfpr (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Apr 10, 2025
Triggered auto assignment to @twisterdotcom (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Apr 10, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 10, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
thelullabyy commentedon Apr 10, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-04-10 04:03:01 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
childReportIDisundefined:App/src/pages/TransactionDuplicate/Confirmation.tsx
Line 56 in 912b436
In case of this bug, the
childReportIDisundefined. It is known issue:App/src/components/ReportActionItem/MoneyRequestAction.tsx
Lines 96 to 103 in 912b436
What changes do you think we should make in order to solve the problem?
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
mollfpr commentedon Apr 10, 2025
@thelullabyy What PR causing the regression?
6 remaining items
VickyStash commentedon Apr 10, 2025
We're going to revert the offending PR.
melvin-bot commentedon Apr 10, 2025
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
rlinoz commentedon Apr 10, 2025
It doesn't accept one right now, but seems like an easy change.
VickyStash commentedon Apr 10, 2025
I guess we will need to update it not for the
MergeDuplicatesrequest only. At least for the HoldRequest as well.luacmartins commentedon Apr 10, 2025
This doesn't seem to be an API blocker. So I removed the label.
jasperhuangg commentedon Apr 10, 2025
Retest was confirmed pass #59549 (comment)
VickyStash commentedon May 12, 2025
This issue was a regression from the PR, which was reverted.
Can we close it?