You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Workspace expenses - Hybrid - Deeplink 'Finish setting up your workspace' redirects to mWeb. #60094
Version Number: v9.1.27-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only If this was caught during regression testing, add the test name, ID and link from TestRail:https://expensify.testrail.io/index.php?/tests/view/5922113 Email or phone of affected tester (no customers):youseronvoardin@onvoardin.com Issue reported by: Applause Internal Team Device used: Samsung A15, Android 14 | iPhone SE 3rd generation (2022), iOS 18.4 App Component: Other
Action Performed:
Open Hybrid app
Sign up with a email without +
Select 'Track and budget expenses'
Enter any name
Tap on FAB > Create a expense > Manual > Submit it to youself
Tap on 'Categorize it' > Upgrade > Got it, thanks > Select any category > Create the expense.
Tap on 'Finish setting up your workspace' deeplink.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-]Workspace expenses - Hybrid - Deeplink 'Finish setting up your workspace' redirects to mWeb.[/-][+][$250] Workspace expenses - Hybrid - Deeplink 'Finish setting up your workspace' redirects to mWeb.[/+]on Apr 11, 2025
As discussed in the slack thread, this is probably not a blocker because the link leads to production so this only happens in staging but it should be handled more gracefully, I think we had a logic to resolve this better
@mountiny We're only navigating through the App if the URL has the same origin as the environment. In this case, the environment is staging, and the link is production. Do we want to update this logic to remove hasSameOrigin here?
Or define a new check that true for native and false on other platforms. With this check all our app links will not open the browser in the native app and will open a new tab on Web if the original is not the same.
// There can be messages from Concierge with links to specific NewDot reports. Those URLs look like this:
// https://www.expensify.com.dev/newdotreport?reportID=3429600449838908 and they have a target="_blank" attribute. This is so that when a user is on OldDot,
// clicking on the link will open the chat in NewDot. However, when a user is in NewDot and clicks on the concierge link, the link needs to be handled differently.
// Normally, the link would be sent to Link.openOldDotLink() and opened in a new tab, and that's jarring to the user. Since the intention is to link to a specific NewDot chat,
// the reportID is extracted from the URL and then opened as an internal link, taking the user straight to the chat in the same tab.
Activity
melvin-bot commentedon Apr 11, 2025
Triggered auto assignment to @madmax330 (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Apr 11, 2025
Triggered auto assignment to @abekkala (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Apr 11, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 11, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
[-]Workspace expenses - Hybrid - Deeplink 'Finish setting up your workspace' redirects to mWeb.[/-][+][$250] Workspace expenses - Hybrid - Deeplink 'Finish setting up your workspace' redirects to mWeb.[/+]5 remaining items
mountiny commentedon Apr 14, 2025
As discussed in the slack thread, this is probably not a blocker because the link leads to production so this only happens in staging but it should be handled more gracefully, I think we had a logic to resolve this better
QichenZhu commentedon Apr 14, 2025
Should this be internal since the link comes from the backend?
mountiny commentedon Apr 14, 2025
I dont think we will change the link, app should handle this well its the same link with just
stagingin front of it.Seems like in the thread in Slack, QA can confirm this used to work ok in the previous staging builds
QichenZhu commentedon Apr 15, 2025
@acdtunes thanks for the proposal. The root cause analysis is not accurate for two reasons:
parseHybridAppUrl()isn’t called during the test steps, so it can't be the cause.nkdengineer commentedon Apr 16, 2025
@mountiny We're only navigating through the App if the URL has the same origin as the environment. In this case, the environment is staging, and the link is production. Do we want to update this logic to remove
hasSameOriginhere?Or define a new check that
truefor native andfalseon other platforms. With this check all our app links will not open the browser in the native app and will open a new tab on Web if the original is not the same.then update this condition to
App/src/libs/actions/Link.ts
Lines 177 to 183 in 470b48b
QichenZhu commentedon Apr 17, 2025
For reference, here is how we handle links with a specific pattern:
App/src/libs/actions/Link.ts
Lines 163 to 168 in 717b77a
mountiny commentedon Apr 17, 2025
Thank you, since this woks in production I dont think we have to do anything right now