You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-05-28] [$250] Split - Missing user avatars above amount in expense preview when expense is split offline #60102
Version Number: 9.1.27-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):applausetester+sdsoidsj@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.3 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Log in with Expensifail account.
Go to staging.new.expensify.com
Open 1:1 DM.
Go offline.
Click + > Split expense > Manual.
Split a manual expense.
Note that there is no user avatars above the amount in the expense preview.
Go online.
Note that user avatars appear above the amount in the expense preview after returning online.
Expected Result:
In Step 6, the user avatars will appear above the amount in the expense preview when expense is split offline.
Actual Result:
In Step 6, the user avatars do not appear above the amount in the expense preview when expense is split offline.
The avatars only appear after returning online (Step 8).
What changes do you think we should make in order to solve the problem?
Introduce a new source param in buildOptimisticMoneyRequestEntities and buildOptimisticIOUReportAction. Pass the source param as CONST.IOU.TYPE.SPLIT here
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
Update splitBill test to verify the participantAccountIDs is assigned in create IOU action
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Split - Missing user avatars above amount in expense preview when expense is split offline[/-][+][$250] Split - Missing user avatars above amount in expense preview when expense is split offline[/+]on Apr 15, 2025
changed the title [-][$250] Split - Missing user avatars above amount in expense preview when expense is split offline[/-][+][Due for payment 2025-05-28] [$250] Split - Missing user avatars above amount in expense preview when expense is split offline[/+]on May 21, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.47-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@Ollyws@alexpensify@Ollyws The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Apr 11, 2025
Triggered auto assignment to @alexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nkdengineer commentedon Apr 11, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
The user avatars do not appear above the amount in the expense preview when expense is split offline.
What is the root cause of that problem?
In offline,
participantAccountIDsdoesn't exist in the original message of thecreateIOU action.App/src/components/ReportActionItem/TransactionPreview/TransactionPreviewContent.tsx
Line 151 in d0c12b6
We only add the
participantAccountIDsif thetypeis splitApp/src/libs/ReportUtils.ts
Lines 5806 to 5811 in d0c12b6
What changes do you think we should make in order to solve the problem?
sourceparam inbuildOptimisticMoneyRequestEntitiesandbuildOptimisticIOUReportAction. Pass the source param asCONST.IOU.TYPE.SPLIThereApp/src/libs/actions/IOU.ts
Lines 5804 to 5810 in d0c12b6
participantAccountIDstooriginalMessageif thesourceisCONST.IOU.TYPE.SPLITApp/src/libs/ReportUtils.ts
Lines 5806 to 5811 in d0c12b6
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
Update
splitBilltest to verify theparticipantAccountIDsis assigned increateIOU actionWhat alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
melvin-bot commentedon Apr 14, 2025
@alexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
[-]Split - Missing user avatars above amount in expense preview when expense is split offline[/-][+][$250] Split - Missing user avatars above amount in expense preview when expense is split offline[/+]melvin-bot commentedon Apr 15, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021911938186450957902
melvin-bot commentedon Apr 15, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (
External)alexpensify commentedon Apr 15, 2025
@Ollyws, when you get a chance, can you please review whether this proposal will fix the issue? Thanks!
30 remaining items
[-][$250] Split - Missing user avatars above amount in expense preview when expense is split offline[/-][+][Due for payment 2025-05-28] [$250] Split - Missing user avatars above amount in expense preview when expense is split offline[/+]melvin-bot commentedon May 21, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 21, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.47-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-05-28. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 21, 2025
@Ollyws @alexpensify @Ollyws The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
alexpensify commentedon May 29, 2025
I'll work on the payment process tomorrow.
alexpensify commentedon May 29, 2025
Payment Summary
Contributor: @FitseTLT paid $250 via Upwork
Contributor+: @Ollyws due $250 via NewDot-- please submit a request
Ollyws commentedon May 29, 2025
Requested on ND.
garrettmknight commentedon Jun 3, 2025
$250 approved for @Ollyws