Skip to content

[Due for payment 2025-05-28] [$250] Split - Missing user avatars above amount in expense preview when expense is split offline #60102

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.27-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+sdsoidsj@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Log in with Expensifail account.
  1. Go to staging.new.expensify.com
  2. Open 1:1 DM.
  3. Go offline.
  4. Click + > Split expense > Manual.
  5. Split a manual expense.
  6. Note that there is no user avatars above the amount in the expense preview.
  7. Go online.
  8. Note that user avatars appear above the amount in the expense preview after returning online.

Expected Result:

In Step 6, the user avatars will appear above the amount in the expense preview when expense is split offline.

Actual Result:

In Step 6, the user avatars do not appear above the amount in the expense preview when expense is split offline.
The avatars only appear after returning online (Step 8).

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Image
Bug6799255_1744360601603.20250411_163131.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021911938186450957902
  • Upwork Job ID: 1911938186450957902
  • Last Price Increase: 2025-04-29
  • Automatic offers:
    • FitseTLT | Contributor | 107110250
Issue OwnerCurrent Issue Owner: @alexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 11, 2025
  2. melvin-bot commented on Apr 11, 2025

    @melvin-bot

    Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. nkdengineer commented on Apr 11, 2025

    @nkdengineer
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The user avatars do not appear above the amount in the expense preview when expense is split offline.

    What is the root cause of that problem?

    In offline, participantAccountIDs doesn't exist in the original message of the create IOU action.

    const participantAccountIDs = isMoneyRequestAction(action) && isBillSplit ? getOriginalMessage(action)?.participantAccountIDs ?? [] : [managerID, ownerAccountID];

    We only add the participantAccountIDs if the type is split

    App/src/libs/ReportUtils.ts

    Lines 5806 to 5811 in d0c12b6

    if (type === CONST.IOU.REPORT_ACTION_TYPE.SPLIT) {
    delete originalMessage.IOUReportID;
    // Split expense made from a policy expense chat only have the payee's accountID as the participant because the payer could be any policy admin
    if (isOwnPolicyExpenseChat) {
    originalMessage.participantAccountIDs = currentUserAccountID ? [currentUserAccountID] : [];
    } else {

    What changes do you think we should make in order to solve the problem?

    1. Introduce a new source param in buildOptimisticMoneyRequestEntities and buildOptimisticIOUReportAction. Pass the source param as CONST.IOU.TYPE.SPLIT here

    App/src/libs/actions/IOU.ts

    Lines 5804 to 5810 in d0c12b6

    const [oneOnOneCreatedActionForChat, oneOnOneCreatedActionForIOU, oneOnOneIOUAction, optimisticTransactionThread, optimisticCreatedActionForTransactionThread] =
    buildOptimisticMoneyRequestEntities({
    iouReport: oneOnOneIOUReport,
    type: CONST.IOU.REPORT_ACTION_TYPE.CREATE,
    amount: splitAmount,
    currency,
    comment,

    1. Also add participantAccountIDs to originalMessage if the source is CONST.IOU.TYPE.SPLIT
    type === CONST.IOU.REPORT_ACTION_TYPE.SPLIT || source === `CONST.IOU.TYPE.SPLIT`
    

    App/src/libs/ReportUtils.ts

    Lines 5806 to 5811 in d0c12b6

    if (type === CONST.IOU.REPORT_ACTION_TYPE.SPLIT) {
    delete originalMessage.IOUReportID;
    // Split expense made from a policy expense chat only have the payee's accountID as the participant because the payer could be any policy admin
    if (isOwnPolicyExpenseChat) {
    originalMessage.participantAccountIDs = currentUserAccountID ? [currentUserAccountID] : [];
    } else {

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    Update splitBill test to verify the participantAccountIDs is assigned in create IOU action

    What alternative solutions did you explore? (Optional)

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. melvin-bot commented on Apr 14, 2025

    @melvin-bot

    @alexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 15, 2025
  6. changed the title [-]Split - Missing user avatars above amount in expense preview when expense is split offline[/-] [+][$250] Split - Missing user avatars above amount in expense preview when expense is split offline[/+] on Apr 15, 2025
  7. melvin-bot commented on Apr 15, 2025

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 15, 2025
  9. melvin-bot commented on Apr 15, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

  10. alexpensify commented on Apr 15, 2025

    @alexpensify
    Contributor

    @Ollyws, when you get a chance, can you please review whether this proposal will fix the issue? Thanks!

  11. 30 remaining items

  12. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on May 21, 2025
  13. changed the title [-][$250] Split - Missing user avatars above amount in expense preview when expense is split offline[/-] [+][Due for payment 2025-05-28] [$250] Split - Missing user avatars above amount in expense preview when expense is split offline[/+] on May 21, 2025
  14. melvin-bot commented on May 21, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on May 21, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.47-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-05-28. 🎊

    For reference, here are some details about the assignees on this issue:

  16. melvin-bot commented on May 21, 2025

    @melvin-bot

    @Ollyws @alexpensify @Ollyws The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  17. alexpensify commented on May 29, 2025

    @alexpensify
    Contributor

    I'll work on the payment process tomorrow.

  18. alexpensify commented on May 29, 2025

    @alexpensify
    Contributor

    Payment Summary

    Contributor: @FitseTLT paid $250 via Upwork
    Contributor+: @Ollyws due $250 via NewDot-- please submit a request

  19. Ollyws commented on May 29, 2025

    @Ollyws
    Contributor

    Requested on ND.

  20. garrettmknight commented on Jun 3, 2025

    @garrettmknight
    Contributor

    $250 approved for @Ollyws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions