Repository navigation
Closed
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionEngineeringExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewHas a PR in reviewWeeklyKSv2KSv2
Description
This PR introduced the following issues.
Needs work
- Add remove from report flow
Fixed
- [Due for payment 2025-05-27] Expense - Empty message row after moving report in offline mode #60251
- Update IOU action when moving reports #61221 (comment)
- [Due for payment 2025-04-25] Expense - "Moved this expense to" message is duplicated when submitting track expense to WS. #60225
- [Due for payment 2025-04-28] Review duplicates - Confirm button is not functional after moving report on confirmation page #60254
- [Due for payment 2025-04-28] [$250] Expense - Report field is accessible by receiver in p2p expense and it opens blank page #60238
- [Due for payment 2025-04-28] Expense - Report field shows submitted report but the expense is created in a new report #60229
- [Due for payment 2025-04-28] Expense - Report field in paid expense shows that another report is selected #60232
- [Due for payment 2025-04-28] Expense - Expense is created in report from other workspace when a new workspace is selected #60234
- [Due for payment 2025-04-28] Expense - Report page is blank when submitting expense to workspace with no report #60228
- [$250] Travel - "View trip details" button is not below Report field #60299
- [Change Report] Expense - Report name in Report field shows negative amount in offline mode #60247
- IOU-Report field shows owes amount briefly before updating to IOU #60233
- Distance - Distance and Rate fields become "pending" after returning from waypoint editor #60297
- Invoice- Invoice report title is "user owes amount", but Report field shows Invoice YYYY-MM-DD #60274
- Expense - Infinite loading when WS admin tries to change employee´s expense to another report #60295
- Some random name displayed on the confirmation page when creating an expense #60388
- Expense - When changing expense to another report, preview with "0,00" remains on chat. #60252 (unable to reproduce)
- [$250] Reports - After moving an expense the amount is still shown in money request preview #60271 (unable to reproduce)
- Revert changes in this PR [CP Staging] Disable moved actions #60328
Issue Owner
Current Issue Owner: @Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021948148958721134868
- Upwork Job ID: 1948148958721134868
- Last Price Increase: 2025-07-23
Issue Owner
Current Issue Owner: @adelekennedyMetadata
Metadata
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionEngineeringExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewHas a PR in reviewWeeklyKSv2KSv2
Type
Projects
- StatusShow more project fieldsDone
Activity
waterim commentedon Apr 15, 2025
Posting my update!
luacmartins commentedon Apr 15, 2025
waterim commentedon Apr 15, 2025
@luacmartins Updated it not to include submitted reports for submission delays on, and include submitted reports when its off
As it looks like more intutive
luacmartins commentedon Apr 15, 2025
hmm I'm not sure if that's what we want. @JmillsExpensify @trjExpensify could you please check? Should we be able to add a transaction to a submitted report is delayed submission is on?
trjExpensify commentedon Apr 15, 2025
I'm looking at the steps in the issue and I'm inclined to say no. In the creation flow the expense shouldn't be added to an existing processing report on delayed submit.
148 remaining items
luacmartins commentedon Oct 6, 2025
@adelekennedy let's process payment for this one. Let me know if you need any help with this issue, since there were many moving parts here
adelekennedy commentedon Oct 7, 2025
sorry about that! Okay walking through payments I will definitely need confirmation here:
@rayane-d reviewed:
#60318
#60688
#60857
and is owed a total of $750 for all three
@allgandalf
#61249
#64259 (reverted - $125)
#67048
Total $625
@shubham1206agra
#61743
#64024
#64259 (reverted - $125)
Total $625
luacmartins commentedon Oct 7, 2025
I came up with the same list of PRs as you @adelekennedy. I think we can apply the 50% penalty only once like you did, since this was a complex feature (instead of multiple 50% penalties given the multiple reverts and several regressions per issue). So I agree with the payment summary above!
adelekennedy commentedon Oct 7, 2025
Phew! Amazing and it looks like all three are on NewDot payments
Payment Summary
Contributor+: @rayane-d due $750 via NewDot
Contributor+: @allgandalf due $625 via NewDot
Contributor+: @shubham1206agra due $625 via NewDot
twisterdotcom commentedon Oct 9, 2025
@allgandalf paid and approved. Can we close?
rayane-d commentedon Oct 14, 2025
Requested $500 in ND instead of $750 because I've already got $250 for PR #60688. See #60288 (comment) and #60288 (comment)
JmillsExpensify commentedon Oct 21, 2025
$625 approved for @shubham1206agra
nyomanjyotisa commentedon Jul 31, 2026
The unreport implementation for this issue in PR #67048 introduced the regression reported in #94533. The sibling duplicate-violation cleanup was optimistic-only, so stale data could restore the warning after an offline move and reconnect.
PR #95994 adds the missing success and failure handling and preserves any remaining duplicate references.