Skip to content

[Due for payment 2025-08-11] [$250] Follow up for "Feature: Implement ChangeTransactionsReport" #60288

Closed

Description

@luacmartins

This PR introduced the following issues.

Needs work

  • Add remove from report flow

Fixed

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021948148958721134868
  • Upwork Job ID: 1948148958721134868
  • Last Price Increase: 2025-07-23
Issue OwnerCurrent Issue Owner: @adelekennedy

Activity

  1. self-assigned this
    on Apr 15, 2025
  2. waterim commented on Apr 15, 2025

    @waterim
    Contributor

    Posting my update!

  3. luacmartins commented on Apr 15, 2025

    @luacmartins
    ContributorAuthor

    #60229 - correct behaviour???
    I think it's correct that the expense is on a new report, but I think we should display the name of the new report the expense will be put in, not the old submitted report in this case

  4. waterim commented on Apr 15, 2025

    @waterim
    Contributor

    @luacmartins Updated it not to include submitted reports for submission delays on, and include submitted reports when its off
    As it looks like more intutive

  5. luacmartins commented on Apr 15, 2025

    @luacmartins
    ContributorAuthor

    hmm I'm not sure if that's what we want. @JmillsExpensify @trjExpensify could you please check? Should we be able to add a transaction to a submitted report is delayed submission is on?

  6. trjExpensify commented on Apr 15, 2025

    @trjExpensify
    Contributor

    I'm looking at the steps in the issue and I'm inclined to say no. In the creation flow the expense shouldn't be added to an existing processing report on delayed submit.

    Image
  7. 148 remaining items

  8. luacmartins commented on Oct 6, 2025

    @luacmartins
    ContributorAuthor

    @adelekennedy let's process payment for this one. Let me know if you need any help with this issue, since there were many moving parts here

  9. adelekennedy commented on Oct 7, 2025

    @adelekennedy
    Contributor

    sorry about that! Okay walking through payments I will definitely need confirmation here:

    @rayane-d reviewed:
    #60318
    #60688
    #60857

    and is owed a total of $750 for all three

    @allgandalf
    #61249
    #64259 (reverted - $125)
    #67048

    Total $625

    @shubham1206agra
    #61743
    #64024
    #64259 (reverted - $125)

    Total $625

  10. luacmartins commented on Oct 7, 2025

    @luacmartins
    ContributorAuthor

    I came up with the same list of PRs as you @adelekennedy. I think we can apply the 50% penalty only once like you did, since this was a complex feature (instead of multiple 50% penalties given the multiple reverts and several regressions per issue). So I agree with the payment summary above!

  11. adelekennedy commented on Oct 7, 2025

    @adelekennedy
    Contributor

    Phew! Amazing and it looks like all three are on NewDot payments

    Payment Summary

    Contributor+: @rayane-d due $750 via NewDot
    Contributor+: @allgandalf due $625 via NewDot
    Contributor+: @shubham1206agra due $625 via NewDot

  12. twisterdotcom commented on Oct 9, 2025

    @twisterdotcom
    Contributor

    @allgandalf paid and approved. Can we close?

  13. moved this from MEDIUM or LOW to Done in [#whatsnext] #migrateon Oct 9, 2025
  14. rayane-d commented on Oct 14, 2025

    @rayane-d
    Contributor

    Requested $500 in ND instead of $750 because I've already got $250 for PR #60688. See #60288 (comment) and #60288 (comment)

  15. JmillsExpensify commented on Oct 21, 2025

    @JmillsExpensify
    Contributor

    $625 approved for @shubham1206agra

  16. nyomanjyotisa commented on Jul 31, 2026

    @nyomanjyotisa
    Member

    The unreport implementation for this issue in PR #67048 introduced the regression reported in #94533. The sibling duplicate-violation cleanup was optimistic-only, so stale data could restore the warning after an offline move and reconnect.

    PR #95994 adds the missing success and failure handling and preserves any remaining duplicate references.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionEngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions