Skip to content

[Due for payment 2025-06-02] [$250] Showing incorrect expense reports search query #60389

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?: need reproduction
Reproducible in production?: need reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @joekaufmanexpensify
Slack conversation (hyperlinked to channel name): expensify - convert

Action Performed:

  1. Login to an account with a lot of report history.
  2. Go to Reports > Expense reports.

Expected Result:

Expense reports are sorted by date in descending order, by default. Meaning you see most recent reports first. Actual query is "inputQuery":"type:expense status:all sortBy:date sortOrder:desc groupBy:reports"

Actual Result:

Expense reports are not shown in this order in the frontend. The list seems to skip around years a bit.

Workaround:

unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop
Platforms Tested: On which of our officially supported platforms was this issue tested:
  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Image

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021912986422304272884
  • Upwork Job ID: 1912986422304272884
  • Last Price Increase: 2025-05-15
  • Automatic offers:
    • brunovjk | Reviewer | 107410354
Issue OwnerCurrent Issue Owner: @sakluger

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    retest-weeklyApply this label if you want this issue tested on a Weekly basis by Applause
    on Apr 17, 2025
  2. melvin-bot commented on Apr 17, 2025

    @melvin-bot

    Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. MelvinBot commented on Apr 17, 2025

    @MelvinBot
    Contributor

    This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

  4. sakluger commented on Apr 17, 2025

    @sakluger
    Contributor

    I asked a clarifying question in the original thread.

  5. sakluger commented on Apr 17, 2025

    @sakluger
    Contributor

    I was able to reproduce. The trick is to scroll down quickly. I see old reports from 2022, then a half second later, 2023 reports load.

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    retest-weeklyApply this label if you want this issue tested on a Weekly basis by Applause
    on Apr 17, 2025
  7. changed the title [-]Showing incorrect expense reports search query[/-] [+][$250] Showing incorrect expense reports search query[/+] on Apr 17, 2025
  8. melvin-bot commented on Apr 17, 2025

    @melvin-bot
  9. 78 remaining items

  10. melvin-bot commented on May 22, 2025

    @melvin-bot

    📣 @brunovjk 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job

  11. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on May 26, 2025
  12. changed the title [-][$250] Showing incorrect expense reports search query[/-] [+][Due for payment 2025-06-02] [$250] Showing incorrect expense reports search query[/+] on May 26, 2025
  13. melvin-bot commented on May 26, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on May 26, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.51-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-06-02. 🎊

    For reference, here are some details about the assignees on this issue:

  15. melvin-bot commented on May 26, 2025

    @melvin-bot

    @brunovjk @sakluger @brunovjk The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  16. brunovjk commented on Jun 2, 2025

    @brunovjk
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: No PR directly introduced the bug, the part that was changed in the file remained with the same logic since its creation.

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Test:

    1. Login to an account with a lot of report history.
    2. Go to Reports > Expense reports.
    3. Check if expense reports are shown in correct order.
      i. sorted by date with descending order (newest are first)

    Do we agree 👍 or 👎

  17. sakluger commented on Jun 2, 2025

    @sakluger
    Contributor

    Summarizing payment on this issue:

    Contributor: @sosek108 - No payment required, contractor
    Contributor+: @brunovjk $250, paid via Upwork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions