Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.1.30-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @JmillsExpensify
Slack conversation (hyperlinked to channel name): expensify-bugs
Action Performed:
- Navigate to Settings
- Click Contact method
- Click add
- Enter a new email address
- Ask to verify the old email address
- Verify old address
- Verify new address
Expected Result:
The flow should be validating the old email address and then validating the new email address
Actual Result:
But we are validating the old email address after adding the new contact method email address
- Navigate to Settings
- Click Contact method
- Click add
- Verify the existing/old email address via magic code
- Enter a new email address
- Very the new address via magic code
Workaround:
unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- Windows: Chrome
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021914350876425023060
- Upwork Job ID: 1914350876425023060
- Last Price Increase: 2025-05-05
- Automatic offers:
- suneox | Reviewer | 107226990
- cretadn22 | Contributor | 109786564
Issue Owner
Current Issue Owner: @Issue Owner
Current Issue Owner: @heyjennahayMetadata
Metadata
Labels
Type
Projects
- StatusShow more project fieldsDone
Activity
melvin-bot commentedon Apr 21, 2025
Triggered auto assignment to @lschurr (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.[-]Reverse the order of steps when adding the contact method[/-][+][$250] Reverse the order of steps when adding the contact method[/+]melvin-bot commentedon Apr 21, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021914350876425023060
melvin-bot commentedon Apr 21, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (
External)govind-kumarr commentedon Apr 21, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Currently if we want to add a new contact method.
What is the root cause of that problem?
Current flow of letting user input a new contact method and then verifying primary contact method is the root cause of problem. I will correct this flow to
What changes do you think we should make in order to solve the problem?
To solve this problem we will need to change the flow of things currently working. We will need to mainly change the components to trigger primary contact method verification first and then start the new contact method add process.
https://github.com/Expensify/App/blob/main/src/pages/settings/Profile/Contacts/ContactMethodsPage.tsx
https://github.com/Expensify/App/blob/main/src/pages/settings/Profile/Contacts/NewContactMethodPage.tsx
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
To prevent this reintroducing this problem we will need to check the flow again with different new contact methods.
What alternative solutions did you explore? (Optional)
I believe the problem is quite straightforward, so exploring alternatives might not be necessary.
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
melvin-bot commentedon Apr 21, 2025
📣 @govind-kumarr! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
govind-kumarr commentedon Apr 21, 2025
Contributor details
Your Expensify account email: gk4051668@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~0130521ecca230687e
melvin-bot commentedon Apr 21, 2025
✅ Contributor details stored successfully. Thank you for contributing to Expensify!
nkgupta-coder commentedon Apr 23, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
We need to reverse the order of steps when adding a new contact method.
Currently, the flow works as follows:
This flow is unnecessarily complex and should be streamlined.
What is the root cause of that problem?
The verification modal is currently being triggered when the user clicks the "Add" button because we're setting
setIsValidateCodeActionModalVisible(true)in thehandleValidateMagicCodefunction. This creates an extra step in the verification process that's confusing users.What changes do you think we should make in order to solve the problem?
We need to modify the
NewContactMethodPage.tsxfile to:isAccountValidatedinstead ofisUserValidated:This will trigger the verification modal when the user clicks on the "Add Contact Method" button, simplifying the flow by opening the verification modal immediately after the primary contact is verified.
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
To prevent reintroducing this problem, we should test the following scenarios:
What alternative solutions did you explore? (Optional)
The issue is straightforward with a clear solution path. Alternative approaches weren't necessary given the well-defined problem and direct solution.
216 remaining items
melvin-bot commentedon Jan 27, 2026
Triggered auto assignment to @heyjennahay (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.lschurr commentedon Jan 27, 2026
@heyjennahay I'm focused on the KYC team chores. Can you handle payment for me on this one? Thank you!!
heyjennahay commentedon Jan 28, 2026
@suneox did you mean to hide tests 2-8 here or should all 8 be created?
suneox commentedon Jan 28, 2026
@heyjennahay I've updated the regression test to simplify the expected result.
heyjennahay commentedon Jan 28, 2026
Ok so these hidden cases are just for historical reference and I can ignore them?
suneox commentedon Jan 28, 2026
Yes, please ignore the another test case.
heyjennahay commentedon Jan 28, 2026
Payment summary:
@suneox paid $250 via Upwork
@cretadn22 paid $250 via Upwork
Confirming both contracts have been closed as has the job.
Thanks everyone!
trjExpensify commentedon Jan 31, 2026
approved $250 for @suneox.