Skip to content

[Due for payment 2025-05-08] [$250] Onboarding - Chat can be opened on onboarding stage using Keyboard shortcuts #60605

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.1.31-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: -
Email or phone of affected tester (no customers): gibethlehem@gmail.com
Issue reported by: Applause Internal Team
Device used: macOS/chrome
App Component: Other

Action Performed:

  1. Navigate to app
  2. Sign up with a new gmail account.
  3. On the onboarding Flow Press on Shift + CMD(Ctrl) + K
  4. Search for any chat

Expected Result:

Unable to access chat using Keyboard shortcuts on onboarding stage

Actual Result:

able to access chat using Keyboard shortcuts on onboarding stage

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021915115171011360029
  • Upwork Job ID: 1915115171011360029
  • Last Price Increase: 2025-04-23
  • Automatic offers:
    • allgandalf | Reviewer | 107060100
    • nkdengineer | Contributor | 107060101
Issue OwnerCurrent Issue Owner: @laurenreidexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 22, 2025
  2. melvin-bot commented on Apr 22, 2025

    @melvin-bot

    Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. nkdengineer commented on Apr 22, 2025

    @nkdengineer
    Contributor

    🚨 Edited by proposal-police: This proposal was edited at 2025-04-22 04:06:15 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    able to access chat using Keyboard shortcuts on onboarding stage

    What is the root cause of that problem?

    We don't have the logic to check if the it's the onboarding flow when open new chat page

    Modal.close(Session.callFunctionIfActionIsAllowed(() => Navigation.navigate(ROUTES.NEW)));

    What changes do you think we should make in order to solve the problem?

    Add the logic to check onboarding flow same as search page

    const unsubscribeChatShortcut = KeyboardShortcut.subscribe(
                chatShortcutConfig.shortcutKey,
                () => {
                    const state = navigationRef.getRootState();
                        const currentFocusedRoute = findFocusedRoute(state);
                    if (isOnboardingFlowName(currentFocusedRoute?.name)) {
                        return;
                    }
                    Modal.close(Session.callFunctionIfActionIsAllowed(() => Navigation.navigate(ROUTES.NEW)));
                },
                chatShortcutConfig.descriptionKey,
                chatShortcutConfig.modifiers,
                true,
            );
    
    

    We also need to check other shortcuts if needed to make sure there's no page is open during onboarding flow. And we can create the util function to prevent duplicated code

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    None

    What alternative solutions did you explore? (Optional)

    NA

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. laurenreidexpensify commented on Apr 23, 2025

    @laurenreidexpensify
    Contributor

    I don't think this is a particularly impactful bug, but will add it to bugs in case someone can fix it

  5. changed the title [-]Onboarding - Chat can be opened on onboarding stage using Keyboard shortcuts[/-] [+][$250] Onboarding - Chat can be opened on onboarding stage using Keyboard shortcuts[/+] on Apr 23, 2025
  6. melvin-bot commented on Apr 23, 2025

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 23, 2025
  8. melvin-bot commented on Apr 23, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)

  9. allgandalf commented on Apr 24, 2025

    @allgandalf
    Contributor

    @nkdengineer 's proposal makes sense to me, lets go with their proposal

    🎀👀🎀 C+ reviewed

  10. 21 remaining items

  11. melvin-bot commented on May 1, 2025

    @melvin-bot

    @allgandalf @laurenreidexpensify @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  12. laurenreidexpensify commented on May 6, 2025

    @laurenreidexpensify
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal Template
    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    Do we agree 👍 or 👎

  13. laurenreidexpensify commented on May 6, 2025

    @laurenreidexpensify
    Contributor

    @allgandalf pls complete the checklist thanks

  14. laurenreidexpensify commented on May 8, 2025

    @laurenreidexpensify
    Contributor
  15. allgandalf commented on May 8, 2025

    @allgandalf
    Contributor

    sorry this got shifted to daily today in my K2, so missed the last ping, it's late for me now, I'll update this issue tomorrow

  16. allgandalf commented on May 12, 2025

    @allgandalf
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other: onboarding modal was not present, so no source.

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: There is no offending PR, the onboarding was not present when the shortcut was implemented

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    Test:

    1. Sign up with a new gmail account.
    2. On the onboarding Flow Press on Shift + CMD(Ctrl) + K

    Verify that user is unable to access chat using Keyboard shortcuts on onboarding stage

    Do we agree 👍 or 👎

  17. melvin-bot commented on May 12, 2025

    @melvin-bot

    @laurenreidexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  18. allgandalf commented on May 13, 2025

    @allgandalf
    Contributor

    bump for payment @laurenreidexpensify

  19. laurenreidexpensify commented on May 13, 2025

    @laurenreidexpensify
    Contributor

    Payment Summary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions