You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-05-08] [$250] Onboarding - Chat can be opened on onboarding stage using Keyboard shortcuts #60605
Version Number: v9.1.31-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: - Email or phone of affected tester (no customers):gibethlehem@gmail.com Issue reported by: Applause Internal Team Device used: macOS/chrome App Component: Other
Action Performed:
Navigate to app
Sign up with a new gmail account.
On the onboarding Flow Press on Shift + CMD(Ctrl) + K
Search for any chat
Expected Result:
Unable to access chat using Keyboard shortcuts on onboarding stage
Actual Result:
able to access chat using Keyboard shortcuts on onboarding stage
We also need to check other shortcuts if needed to make sure there's no page is open during onboarding flow. And we can create the util function to prevent duplicated code
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Onboarding - Chat can be opened on onboarding stage using Keyboard shortcuts[/-][+][$250] Onboarding - Chat can be opened on onboarding stage using Keyboard shortcuts[/+]on Apr 23, 2025
@allgandalf@laurenreidexpensify@allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other: onboarding modal was not present, so no source.
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: There is no offending PR, the onboarding was not present when the shortcut was implemented
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Sign up with a new gmail account.
On the onboarding Flow Press on Shift + CMD(Ctrl) + K
Verify that user is unable to access chat using Keyboard shortcuts on onboarding stage
Activity
melvin-bot commentedon Apr 22, 2025
Triggered auto assignment to @laurenreidexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nkdengineer commentedon Apr 22, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-04-22 04:06:15 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
able to access chat using Keyboard shortcuts on onboarding stage
What is the root cause of that problem?
We don't have the logic to check if the it's the onboarding flow when open new chat page
App/src/libs/Navigation/AppNavigator/AuthScreens.tsx
Line 401 in a2b6087
What changes do you think we should make in order to solve the problem?
Add the logic to check onboarding flow same as search page
We also need to check other shortcuts if needed to make sure there's no page is open during onboarding flow. And we can create the util function to prevent duplicated code
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
laurenreidexpensify commentedon Apr 23, 2025
I don't think this is a particularly impactful bug, but will add it to bugs in case someone can fix it
[-]Onboarding - Chat can be opened on onboarding stage using Keyboard shortcuts[/-][+][$250] Onboarding - Chat can be opened on onboarding stage using Keyboard shortcuts[/+]melvin-bot commentedon Apr 23, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021915115171011360029
melvin-bot commentedon Apr 23, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (
External)allgandalf commentedon Apr 24, 2025
@nkdengineer 's proposal makes sense to me, lets go with their proposal
🎀👀🎀 C+ reviewed
21 remaining items
melvin-bot commentedon May 1, 2025
@allgandalf @laurenreidexpensify @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
laurenreidexpensify commentedon May 6, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
laurenreidexpensify commentedon May 6, 2025
@allgandalf pls complete the checklist thanks
laurenreidexpensify commentedon May 8, 2025
@allgandalf bump
allgandalf commentedon May 8, 2025
sorry this got shifted to daily today in my K2, so missed the last ping, it's late for me now, I'll update this issue tomorrow
allgandalf commentedon May 12, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: There is no offending PR, the onboarding was not present when the shortcut was implemented
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Verify that user is unable to access chat using Keyboard shortcuts on onboarding stage
Do we agree 👍 or 👎
melvin-bot commentedon May 12, 2025
@laurenreidexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
allgandalf commentedon May 13, 2025
bump for payment @laurenreidexpensify
laurenreidexpensify commentedon May 13, 2025
Payment Summary