You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-05-13] [$250] iOS - Expense Reports - No suggestion list when typing emoji or user mention in expense report #60747
Version Number: 9.1.32-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):applausetester+220402kh@applause.expensifail.com Issue reported by: Applause Internal Team Device used: iPhone 15 Pro Max / iOS 18.4 App Component: Search
Action Performed:
Precondition:
Log in with Expensifail account.
Have at least an expense in the workspace chat.
Launch Expensify app.
Go to Reports.
Go to Expense Reports.
Tap on any expense report.
Type :sm
Clear the field.
Mention a user.
Expected Result:
There will be suggestion list when typing emoji and mentioning user.
Actual Result:
There is no suggestion list when typing emoji and mentioning user.
changed the title [-]iOS - Expense Reports - No suggestion list when typing emoji or user mention in expense report[/-][+][$250] iOS - Expense Reports - No suggestion list when typing emoji or user mention in expense report[/+]on Apr 24, 2025
changed the title [-][$250] iOS - Expense Reports - No suggestion list when typing emoji or user mention in expense report[/-][+][Due for payment 2025-05-13] [$250] iOS - Expense Reports - No suggestion list when typing emoji or user mention in expense report[/+]on May 6, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.39-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@fedirjh@OfstadC@fedirjh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Apr 23, 2025
Triggered auto assignment to @OfstadC (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.mkzie2 commentedon Apr 24, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-04-24 09:50:30 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
There is no suggestion list when typing emoji and mentioning user.
What is the root cause of that problem?
We did not add
<PortalHost name="suggestions" />toMoneyRequestReportViewlike we did inReportScreen:App/src/pages/home/ReportScreen.tsx
Line 813 in e63dda3
What changes do you think we should make in order to solve the problem?
Add it if
shouldDisplayReportFooter.App/src/components/MoneyRequestReportView/MoneyRequestReportView.tsx
Lines 201 to 202 in 07c448c
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
We can write a wrapper to add the
<PortalHost />there like what we did withReactionListWrapperso we can avoid similar problem in the future:App/src/pages/home/ReactionListWrapper.tsx
Line 6 in ffb8bb5
[-]iOS - Expense Reports - No suggestion list when typing emoji or user mention in expense report[/-][+][$250] iOS - Expense Reports - No suggestion list when typing emoji or user mention in expense report[/+]melvin-bot commentedon Apr 24, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021915464201856339029
melvin-bot commentedon Apr 24, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (
External)fedirjh commentedon Apr 26, 2025
@mkzie2's proposal looks good to me.
🎀 👀 🎀 C+ reviewed
melvin-bot commentedon Apr 26, 2025
Triggered auto assignment to @arosiclair, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
5 remaining items
[-][$250] iOS - Expense Reports - No suggestion list when typing emoji or user mention in expense report[/-][+][Due for payment 2025-05-13] [$250] iOS - Expense Reports - No suggestion list when typing emoji or user mention in expense report[/+]melvin-bot commentedon May 6, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 6, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.39-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-05-13. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 6, 2025
@fedirjh @OfstadC @fedirjh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
OfstadC commentedon May 13, 2025
@fedirjh please complete the BZ checklist so we can issue payment 😃
fedirjh commentedon May 13, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: [Better Expense Reports] Add MoneyRequestReportView #58360 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/501145
Regression Test Proposal
Precondition:
Test:
@to mention a user:smito insert emojisDo we agree 👍 or 👎
OfstadC commentedon May 14, 2025
Payment Summary
laurenreidexpensify commentedon Aug 6, 2025
$250 approved in New Expensify for @fedirjh