Skip to content

[Due for payment 2025-05-13] [$250] iOS - Expense Reports - No suggestion list when typing emoji or user mention in expense report #60747

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.32-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+220402kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.4
App Component: Search

Action Performed:

Precondition:

  • Log in with Expensifail account.
  • Have at least an expense in the workspace chat.
  1. Launch Expensify app.
  2. Go to Reports.
  3. Go to Expense Reports.
  4. Tap on any expense report.
  5. Type :sm
  6. Clear the field.
  7. Mention a user.

Expected Result:

There will be suggestion list when typing emoji and mentioning user.

Actual Result:

There is no suggestion list when typing emoji and mentioning user.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6811040_1745441933140.ScreenRecording_04-24-2025_04-55-11_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021915464201856339029
  • Upwork Job ID: 1915464201856339029
  • Last Price Increase: 2025-04-24
  • Automatic offers:
    • mkzie2 | Contributor | 107089933
Issue OwnerCurrent Issue Owner: @OfstadC

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 23, 2025
  2. melvin-bot commented on Apr 23, 2025

    @melvin-bot

    Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. mkzie2 commented on Apr 24, 2025

    @mkzie2
    Contributor

    🚨 Edited by proposal-police: This proposal was edited at 2025-04-24 09:50:30 UTC.

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    There is no suggestion list when typing emoji and mentioning user.

    What is the root cause of that problem?

    We did not add <PortalHost name="suggestions" /> to MoneyRequestReportView like we did in ReportScreen:

    <PortalHost name="suggestions" />

    What changes do you think we should make in order to solve the problem?

    Add it if shouldDisplayReportFooter.

    {shouldDisplayReportFooter ? (
    <ReportFooter

    {shouldDisplayReportFooter ? (
        <>
            <ReportFooter />
            <PortalHost name="suggestions" />
        </>
    ) : null}

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    NA

    What alternative solutions did you explore? (Optional)

    We can write a wrapper to add the <PortalHost /> there like what we did with ReactionListWrapper so we can avoid similar problem in the future:

    function ReactionListWrapper({children}: {children: React.ReactNode}) {

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 24, 2025
  5. changed the title [-]iOS - Expense Reports - No suggestion list when typing emoji or user mention in expense report[/-] [+][$250] iOS - Expense Reports - No suggestion list when typing emoji or user mention in expense report[/+] on Apr 24, 2025
  6. melvin-bot commented on Apr 24, 2025

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 24, 2025
  8. melvin-bot commented on Apr 24, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

  9. fedirjh commented on Apr 26, 2025

    @fedirjh
    Contributor

    @mkzie2's proposal looks good to me.

    🎀 👀 🎀 C+ reviewed

  10. melvin-bot commented on Apr 26, 2025

    @melvin-bot

    Triggered auto assignment to @arosiclair, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  11. 5 remaining items

  12. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on May 6, 2025
  13. changed the title [-][$250] iOS - Expense Reports - No suggestion list when typing emoji or user mention in expense report[/-] [+][Due for payment 2025-05-13] [$250] iOS - Expense Reports - No suggestion list when typing emoji or user mention in expense report[/+] on May 6, 2025
  14. melvin-bot commented on May 6, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on May 6, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.39-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-05-13. 🎊

    For reference, here are some details about the assignees on this issue:

  16. melvin-bot commented on May 6, 2025

    @melvin-bot

    @fedirjh @OfstadC @fedirjh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  17. OfstadC commented on May 13, 2025

    @OfstadC
    Contributor

    @fedirjh please complete the BZ checklist so we can issue payment 😃

  18. fedirjh commented on May 13, 2025

    @fedirjh
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: [Better Expense Reports] Add MoneyRequestReportView #58360 (comment)

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue: https://github.com/Expensify/Expensify/issues/501145

    Regression Test Proposal

    Precondition:

    • Have tableReportView beta enabled

    Test:

    1. Submit at least two expenses to a workspace
    2. Go to Reports → Expense Reports
    3. Open the workspace chat
    4. Type@ to mention a user
    5. Verify mention suggestion list shows
    6. Type :smi to insert emojis
    7. Verify emoji suggestion list shows

    Do we agree 👍 or 👎

  19. OfstadC commented on May 14, 2025

    @OfstadC
    Contributor

    Payment Summary

  20. laurenreidexpensify commented on Aug 6, 2025

    @laurenreidexpensify
    Contributor

    $250 approved in New Expensify for @fedirjh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions