Skip to content

[Due for payment 2025-05-14] [$250] Expense - Message is not highlighted after returning from thread via header subtitle link #60768

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.32-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+cnmnmc2@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Log in with Expensifail account.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Submit an expense.
  4. Go to expense report.
  5. Send a message.
  6. Right click on the message > Reply in thread.
  7. Click on the link under header subtitle.

Expected Result:

The message should be highlighted after returning from thread via header subtitle link.

Actual Result:

The message is not highlighted after returning from thread via header subtitle link.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6811112_1745446853109.20250424_061612.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021918492381793855544
  • Upwork Job ID: 1918492381793855544
  • Last Price Increase: 2025-05-03
  • Automatic offers:
    • ikevin127 | Reviewer | 107178477
    • mkzie2 | Contributor | 107178478
Issue OwnerCurrent Issue Owner: @dylanexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 23, 2025
  2. melvin-bot commented on Apr 23, 2025

    @melvin-bot

    Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. mkzie2 commented on Apr 24, 2025

    @mkzie2
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The message is not highlighted after returning from thread via header subtitle link.

    What is the root cause of that problem?

    We do not pass linkedReportActionID to indicate the current highlighted message like we did with regular ReportActionsList

    const route = useRoute<PlatformStackRouteProp<ReportsSplitNavigatorParamList, typeof SCREENS.REPORT>>();

    const linkedReportActionID = route?.params?.reportActionID;

    What changes do you think we should make in order to solve the problem?

    In MoneyRequestReportActionsList, get linkedReportActionID and pass to ReportActionsListItemRenderer just like what we did with ReportActionsList

    What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

    NA

    What alternative solutions did you explore? (Optional)

    None

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  4. stephanieelliott commented on Apr 29, 2025

    @stephanieelliott
    Contributor

    Hm, I'm not sure I understanding what the issue is -- I think this is expected behavior? I would expect that highlighting text would not persist after clicking another link

  5. mkzie2 commented on Apr 29, 2025

    @mkzie2
    Contributor

    @stephanieelliott "Highlight" here refers to the active message. For example when you go back from a thread report, it should focus/highlight the parent message where the thread was started from:

    Screen.Recording.2025-04-29.at.15.16.17.mov

    In the issue OP, this highlighting mechanism did not work in Search screen.

  6. melvin-bot commented on May 2, 2025

    @melvin-bot

    @stephanieelliott Whoops! This issue is 2 days overdue. Let's get this updated quick!

  7. stephanieelliott commented on May 3, 2025

    @stephanieelliott
    Contributor

    Got it, makes more sense now -- thanks for explaining that @mkzie2!

  8. 26 remaining items

  9. changed the title [-][$250] Expense - Message is not highlighted after returning from thread via header subtitle link[/-] [+][Due for payment 2025-05-14] [$250] Expense - Message is not highlighted after returning from thread via header subtitle link[/+] on May 7, 2025
  10. melvin-bot commented on May 7, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on May 7, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.41-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-05-14. 🎊

    For reference, here are some details about the assignees on this issue:

  12. melvin-bot commented on May 7, 2025

    @melvin-bot

    @ikevin127 @dylanexpensify @ikevin127 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  13. ikevin127 commented on May 8, 2025

    @ikevin127
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/58360/files#r2078852875.

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition: Account must have tableReportView beta is enabled.

    1. Go to workspace chat.
    2. Create at least two expenses to a workspace.
    3. Go to expense report.
    4. Send a message.
    5. Right click on the message > Reply in thread.
    6. Click on the link under header subtitle.
    7. Verify the message in step 5 is highlighted.

    Do we agree 👍 or 👎.

  14. mvtglobally commented on May 10, 2025

    @mvtglobally

    Issue not reproducible during KI retests. (First week)

  15. dylanexpensify commented on May 14, 2025

    @dylanexpensify
    Contributor

    Payment summary:

    Contributor: @mkzie2 $250 via Upwork
    Contributor+: @ikevin127 $250 via Upwork

    Please apply/request!

  16. ikevin127 commented on May 14, 2025

    @ikevin127
    Contributor

    @dylanexpensify 🟢 Offer accepted, awaiting payment.

  17. dylanexpensify commented on May 15, 2025

    @dylanexpensify
    Contributor

    done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions