You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-05-14] [$250] Expense - Message is not highlighted after returning from thread via header subtitle link #60768
Version Number: 9.1.32-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only If this was caught during regression testing, add the test name, ID and link from TestRail: Exp Email or phone of affected tester (no customers):applausetester+cnmnmc2@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.3 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Log in with Expensifail account.
Go to staging.new.expensify.com
Go to workspace chat.
Submit an expense.
Go to expense report.
Send a message.
Right click on the message > Reply in thread.
Click on the link under header subtitle.
Expected Result:
The message should be highlighted after returning from thread via header subtitle link.
Actual Result:
The message is not highlighted after returning from thread via header subtitle link.
What changes do you think we should make in order to solve the problem?
In MoneyRequestReportActionsList, get linkedReportActionID and pass to ReportActionsListItemRenderer just like what we did with ReportActionsList
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
None
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Hm, I'm not sure I understanding what the issue is -- I think this is expected behavior? I would expect that highlighting text would not persist after clicking another link
@stephanieelliott "Highlight" here refers to the active message. For example when you go back from a thread report, it should focus/highlight the parent message where the thread was started from:
Screen.Recording.2025-04-29.at.15.16.17.mov
In the issue OP, this highlighting mechanism did not work in Search screen.
changed the title [-][$250] Expense - Message is not highlighted after returning from thread via header subtitle link[/-][+][Due for payment 2025-05-14] [$250] Expense - Message is not highlighted after returning from thread via header subtitle link[/+]on May 7, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.41-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@ikevin127@dylanexpensify@ikevin127 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition: Account must have tableReportView beta is enabled.
Activity
melvin-bot commentedon Apr 23, 2025
Triggered auto assignment to @stephanieelliott (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.mkzie2 commentedon Apr 24, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
The message is not highlighted after returning from thread via header subtitle link.
What is the root cause of that problem?
We do not pass
linkedReportActionIDto indicate the current highlighted message like we did with regularReportActionsListApp/src/pages/home/report/ReportActionsList.tsx
Line 163 in 43fec36
App/src/pages/home/report/ReportActionsList.tsx
Line 187 in 43fec36
What changes do you think we should make in order to solve the problem?
In
MoneyRequestReportActionsList, getlinkedReportActionIDand pass toReportActionsListItemRendererjust like what we did withReportActionsListWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
None
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
stephanieelliott commentedon Apr 29, 2025
Hm, I'm not sure I understanding what the issue is -- I think this is expected behavior? I would expect that highlighting text would not persist after clicking another link
mkzie2 commentedon Apr 29, 2025
@stephanieelliott "Highlight" here refers to the active message. For example when you go back from a thread report, it should focus/highlight the parent message where the thread was started from:
Screen.Recording.2025-04-29.at.15.16.17.mov
In the issue OP, this highlighting mechanism did not work in Search screen.
melvin-bot commentedon May 2, 2025
@stephanieelliott Whoops! This issue is 2 days overdue. Let's get this updated quick!
stephanieelliott commentedon May 3, 2025
Got it, makes more sense now -- thanks for explaining that @mkzie2!
26 remaining items
[-][$250] Expense - Message is not highlighted after returning from thread via header subtitle link[/-][+][Due for payment 2025-05-14] [$250] Expense - Message is not highlighted after returning from thread via header subtitle link[/+]melvin-bot commentedon May 7, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 7, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.41-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-05-14. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 7, 2025
@ikevin127 @dylanexpensify @ikevin127 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
ikevin127 commentedon May 8, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/58360/files#r2078852875.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition: Account must have
tableReportViewbeta is enabled.Do we agree 👍 or 👎.
mvtglobally commentedon May 10, 2025
Issue not reproducible during KI retests. (First week)
dylanexpensify commentedon May 14, 2025
Payment summary:
Contributor: @mkzie2 $250 via Upwork
Contributor+: @ikevin127 $250 via Upwork
Please apply/request!
ikevin127 commentedon May 14, 2025
@dylanexpensify 🟢 Offer accepted, awaiting payment.
dylanexpensify commentedon May 15, 2025
done