You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Expense - "Approve 0,00" is displayed when submitting a track expense to a Workspace. #60778
Version Number: 9.1.32-0 Reproducible in staging?: Yes Reproducible in production?: Unable to check, new behaviour If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both If this was caught during regression testing, add the test name, ID and link from TestRail:#60431 Email or phone of affected tester (no customers):ibellicotest+619@gmail.com Issue reported by: Applause Internal Team Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome App Component: Money Requests
Action Performed:
Prerequisite: Have a workspace created with delayed submissions and approvals enabled.
Open the staging.new.expensify.com website.
Tap on FAB and select "Create Expense"
Create a manual expense and submit it to Self DM.
Once redirected to chat, tap on "Share with my accountant" on system message below the expense preview.
Select a workspace, add a merchant and submit the expense.
Tap on "Submit" on expense preview.
Note that "Approve 0,00" is displayed on preview after the last action.
Open the expense report.
Note that "Approve 0,00" is displayed on the green button on top of the report.
Expected Result:
Approve button should display the correct amount of the expense when submitting a track expense to a workspace.
Actual Result:
"Approve 0,00" is displayed on expense preview and on the report, after submitting a track expense to a workspace chat.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
I've fixed this issue for the Better Expense Report View, but it hasn't been changed in current ReportPreview.
Since the logic for this is already merged, this is a really small change, we need to replace getSettlementAmount with getTotalAmountForIOUReportPreviewButton here:
Mhm, @JakubKorytko we're going to want to CP to staging a fix for this though as it's a deploy blocker and impacting real usage with reports that have card transactions (that are also non-reimbursable).
I think it's best we put up a separate PR. CC: @mountiny
Activity
melvin-bot commentedon Apr 24, 2025
Triggered auto assignment to @techievivek (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Apr 24, 2025
Triggered auto assignment to @dylanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Apr 24, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 24, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
JakubKorytko commentedon Apr 24, 2025
I've fixed this issue for the Better Expense Report View, but it hasn't been changed in current
ReportPreview.Since the logic for this is already merged, this is a really small change, we need to replace
getSettlementAmountwithgetTotalAmountForIOUReportPreviewButtonhere:App/src/components/ReportActionItem/ReportPreview.tsx
Line 626 in 413f7c0
@jnowakow will add this change to his PR to avoid creating a PR with 1 or 2 lines changed.
trjExpensify commentedon Apr 24, 2025
Mhm, @JakubKorytko we're going to want to CP to staging a fix for this though as it's a deploy blocker and impacting real usage with reports that have card transactions (that are also non-reimbursable).
I think it's best we put up a separate PR. CC: @mountiny
2 remaining items
dylanexpensify commentedon Apr 24, 2025
@JakubKorytko ETA on when we'll have the PR ready for review?
JakubKorytko commentedon Apr 24, 2025
Opened it for a review RN.
trjExpensify commentedon Apr 24, 2025
PR merged, awaiting a CP.
melvin-bot commentedon Apr 24, 2025
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
izarutskaya commentedon Apr 25, 2025
Not reproduced in mWeb
Redminote 10s android 13
Screenrecorder-2025-04-25-12-52-20-994.2.mp4
App
1000115978.mp4
allgandalf commentedon Apr 25, 2025
Lets close this one
mountiny commentedon Apr 25, 2025
Fixed