Skip to content

Expense - "Approve 0,00" is displayed when submitting a track expense to a Workspace. #60778

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.32-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check, new behaviour
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: #60431
Email or phone of affected tester (no customers): ibellicotest+619@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome
App Component: Money Requests

Action Performed:

Prerequisite: Have a workspace created with delayed submissions and approvals enabled.

  1. Open the staging.new.expensify.com website.
  2. Tap on FAB and select "Create Expense"
  3. Create a manual expense and submit it to Self DM.
  4. Once redirected to chat, tap on "Share with my accountant" on system message below the expense preview.
  5. Select a workspace, add a merchant and submit the expense.
  6. Tap on "Submit" on expense preview.
  7. Note that "Approve 0,00" is displayed on preview after the last action.
  8. Open the expense report.
  9. Note that "Approve 0,00" is displayed on the green button on top of the report.

Expected Result:

Approve button should display the correct amount of the expense when submitting a track expense to a workspace.

Actual Result:

"Approve 0,00" is displayed on expense preview and on the report, after submitting a track expense to a workspace chat.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 24, 2025
  2. melvin-bot commented on Apr 24, 2025

    @melvin-bot

    Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Apr 24, 2025

    @melvin-bot

    Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Apr 24, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Apr 24, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. JakubKorytko commented on Apr 24, 2025

    @JakubKorytko
    Member

    I've fixed this issue for the Better Expense Report View, but it hasn't been changed in current ReportPreview.
    Since the logic for this is already merged, this is a really small change, we need to replace getSettlementAmount with getTotalAmountForIOUReportPreviewButton here:

    formattedAmount={getSettlementAmount() ?? ''}

    @jnowakow will add this change to his PR to avoid creating a PR with 1 or 2 lines changed.

  7. trjExpensify commented on Apr 24, 2025

    @trjExpensify
    Contributor

    Mhm, @JakubKorytko we're going to want to CP to staging a fix for this though as it's a deploy blocker and impacting real usage with reports that have card transactions (that are also non-reimbursable).

    Image

    I think it's best we put up a separate PR. CC: @mountiny

  8. self-assigned this
    on Apr 24, 2025
  9. 2 remaining items

  10. dylanexpensify commented on Apr 24, 2025

    @dylanexpensify
    Contributor

    @JakubKorytko ETA on when we'll have the PR ready for review?

  11. JakubKorytko commented on Apr 24, 2025

    @JakubKorytko
    Member

    Opened it for a review RN.

  12. trjExpensify commented on Apr 24, 2025

    @trjExpensify
    Contributor

    PR merged, awaiting a CP.

  13. melvin-bot commented on Apr 24, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  14. izarutskaya commented on Apr 25, 2025

    @izarutskaya

    Not reproduced in mWeb
    Redminote 10s android 13

    Screenrecorder-2025-04-25-12-52-20-994.2.mp4

    App

    1000115978.mp4
  15. allgandalf commented on Apr 25, 2025

    @allgandalf
    Contributor

    Lets close this one

  16. mountiny commented on Apr 25, 2025

    @mountiny
    Contributor

    Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions