Repository navigation
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: V9.1.32-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: N
Email or phone of affected tester (no customers): Slottwo1 2@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13
App Component: Money Requests
Action Performed:
- Go to https://staging.new.expensify.com/home
- Login with a new gmail account
- Create a track expense with description Eg:
#8 - Note in confirmation page the behaviour of description
- Open the expense
- Note the behaviour of description
- Create a manual expense with description Eg:
#7 - Note in confirmation page the behaviour of description
- Open the expense
- Note the behaviour of description
- Tap fab and Create workspace
- Open workspace chat
- Create a manual expense with description Eg:
#7 - Note in confirmation page the behaviour of description
- Open the expense
- Note the behaviour of description
Expected Result:
Description with mention highlighted must be consistent for track/IOU/expense.
Actual Result:
In track expense, description with mention is not highlighted. In 1:1 chat, in preview mention is highlighted in created expense. In workspace chat, in confirmation page, highlighted in description(including preview) but on opening created expense, only in preview description with mention is highlighted.
Workaround:
Unknown
Platforms:
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
1.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021916953073958255661
- Upwork Job ID: 1916953073958255661
- Last Price Increase: 2025-04-28
- Automatic offers:
- truph01 | Contributor | 107106303
Issue Owner
Current Issue Owner: @ChristinadobrzynMetadata
Metadata
Assignees
Labels
Type
Projects
- StatusShow more project fieldsDone
Activity
melvin-bot commentedon Apr 24, 2025
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.truph01 commentedon Apr 24, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-04-24 11:00:01 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
In track expense, description with mention is not highlighted. In 1:1 chat, in preview mention is highlighted in created expense. In workspace chat, in confirmation page, highlighted in description(including preview) but on opening created expense, only in preview description with mention is highlighted.
What is the root cause of that problem?
In the following component:
App/src/components/MoneyRequestConfirmationListFooter.tsx
Line 351 in d629de0
the
exactlyMatch: trueflag is not used, which leads to mentions not being matched precisely and therefore not consistently highlighted.Additionally, in the logic that determines whether to exclude markdown styling:
App/src/pages/iou/request/step/IOURequestStepDescription.tsx
Line 175 in d629de0
The condition:
may incorrectly return true for 1:1 DMs, causing markdown styles (including mention highlighting) to be applied in those cases.
What changes do you think we should make in order to solve the problem?
We should add the
exactlyMatch: trueoption to the mention rendering logic in:App/src/components/MoneyRequestConfirmationListFooter.tsx
Line 351 in d629de0
This will ensure mentions are matched and highlighted precisely and consistently.
Additionally, we should update the
isReportInGroupPolicylogic in:App/src/pages/iou/request/step/IOURequestStepDescription.tsx
Line 175 in d629de0
to more accurately detect group policies and avoid false positives for 1:1 DMs.
Proposed update:
Besides only disabling
mentionReportifisReportInGroupPolicyisfalse, we can always disablementionReport.What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
melvin-bot commentedon Apr 28, 2025
@Christinadobrzyn Whoops! This issue is 2 days overdue. Let's get this updated quick!
Christinadobrzyn commentedon Apr 28, 2025
This can be reproduced in the provided steps - i think this can be external.
melvin-bot commentedon Apr 28, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021916953073958255661
[-]Expense - Description with mention highlighted in not consistent for track/IOU/expense.[/-][+][$250] Expense - Description with mention highlighted in not consistent for track/IOU/expense.[/+]melvin-bot commentedon Apr 28, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (
External)19 remaining items
[-][$250] Expense - Description with mention highlighted in not consistent for track/IOU/expense.[/-][+][Due for payment 2025-05-13] [$250] Expense - Description with mention highlighted in not consistent for track/IOU/expense.[/+]melvin-bot commentedon May 6, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 6, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.39-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-05-13. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 6, 2025
@c3024 @Christinadobrzyn @c3024 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Christinadobrzyn commentedon May 12, 2025
@c3024 Do we need a regression test?
c3024 commentedon May 13, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: This is an edge case and no PR can be held responsible.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not started because the regression was not critical.
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/500794
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
Christinadobrzyn commentedon May 13, 2025
Payment summary here - #60807 (comment)
Regression test here - #60807 (comment)
Please make sure to request payment @c3024!
JmillsExpensify commentedon May 29, 2025
$250 approved for @c3024