You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-06-09] [Due for payment 2025-05-28] [Due for payment 2025-05-27] [$125] Help Modal - Help modal is shown when reducing the size of the window #61016
Version Number: v9.1.33-1 Reproducible in staging?: Yes Reproducible in production?: No If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: - Email or phone of affected tester (no customers):gibethlehem@gmail.com Issue reported by: Applause Internal Team Device used: Windows / Chrome App Component: Other
What changes do you think we should make in order to solve the problem?
We shouldn't trigger the animation if the help modal is already hidden and has not been changed to show. And in this case, we only change sidePanelTranslateX and sidePanelOffset
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
UI issue
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
Here, we run animation whenever sidePanelWidth is changed based on following logic. And in useEffect setIsSidePanelTransitionEnded is set to false. Because of this we see modal for fraction of time.
What changes do you think we should make in order to solve the problem?
To fix the issue, we can only set setIsSidePanelTransitionEnded to false if !prevShouldHideSidePanel && !shouldHideSidePanel so help modal here not shown in following conditions. By doing this, all other logic remain same.
useEffect(()=>{if(!prevShouldHideSidePanel&&!shouldHideSidePanel){setIsSidePanelTransitionEnded(false);}
.....// All existing logic},[shouldHideSidePanel,shouldApplySidePanelOffset,sidePanelWidth]);
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
UI bug
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Help Modal - Help modal is shown when reducing the size of the window[/-][+][$250] Help Modal - Help modal is shown when reducing the size of the window[/+]on May 9, 2025
changed the title [-][Due for payment 2025-05-28] [Due for payment 2025-05-27] [$125] Help Modal - Help modal is shown when reducing the size of the window[/-][+][Due for payment 2025-06-09] [Due for payment 2025-05-28] [Due for payment 2025-05-27] [$125] Help Modal - Help modal is shown when reducing the size of the window[/+]on Jun 2, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.54-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@suneox@adelekennedy@suneox The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A Caused by a missed edge case in the implementation
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Activity
melvin-bot commentedon Apr 29, 2025
Triggered auto assignment to @adelekennedy (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nkdengineer commentedon Apr 29, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Help modal is shown briefly when size is reduced
What is the root cause of that problem?
When we reduce from large screen to small screen the
sidePanelWidthis changed from fixed width to windowWidthApp/src/hooks/useSidePanel.ts
Line 64 in 1d48288
then the animation here is triggered which causes the help modal appear briefly
App/src/hooks/useSidePanel.ts
Lines 74 to 93 in 1d48288
What changes do you think we should make in order to solve the problem?
We shouldn't trigger the animation if the help modal is already hidden and has not been changed to show. And in this case, we only change
sidePanelTranslateXandsidePanelOffsetApp/src/hooks/useSidePanel.ts
Lines 74 to 93 in 1d48288
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
UI issue
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
ishakakkad commentedon Apr 29, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Help modal is shown when reducing the size of the window
What is the root cause of that problem?
We show help model based on following condition.
App/src/components/SidePanel/index.tsx
Lines 8 to 10 in 1d48288
Here, we run animation whenever
sidePanelWidthis changed based on following logic. And in useEffectsetIsSidePanelTransitionEndedis set to false. Because of this we see modal for fraction of time.App/src/hooks/useSidePanel.ts
Lines 74 to 89 in 1d48288
App/src/hooks/useSidePanel.ts
Line 64 in 1d48288
What changes do you think we should make in order to solve the problem?
To fix the issue, we can only set
setIsSidePanelTransitionEndedto false if!prevShouldHideSidePanel && !shouldHideSidePanelso help modal here not shown in following conditions. By doing this, all other logic remain same.What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
UI bug
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
melvin-bot commentedon May 2, 2025
@adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon May 6, 2025
@adelekennedy 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
melvin-bot commentedon May 8, 2025
@adelekennedy 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!
adelekennedy commentedon May 9, 2025
A polish imo but worth it
[-]Help Modal - Help modal is shown when reducing the size of the window[/-][+][$250] Help Modal - Help modal is shown when reducing the size of the window[/+]melvin-bot commentedon May 9, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021920951599807096068
37 remaining items
[-][Due for payment 2025-05-28] [Due for payment 2025-05-27] [$125] Help Modal - Help modal is shown when reducing the size of the window[/-][+][Due for payment 2025-06-09] [Due for payment 2025-05-28] [Due for payment 2025-05-27] [$125] Help Modal - Help modal is shown when reducing the size of the window[/+]melvin-bot commentedon Jun 2, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.54-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-06-09. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jun 2, 2025
@suneox @adelekennedy @suneox The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
suneox commentedon Jun 9, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A Caused by a missed edge case in the implementation
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
N/A: It isn't an impactful bug
adelekennedy commentedon Jun 9, 2025
Payment Summary
Contributor: @nkdengineer paid $250 via Upwork
Contributor+: @suneox paid $250 via Upwork
melvin-bot commentedon Jul 1, 2025
Triggered auto assignment to @tgolen, see https://stackoverflow.com/c/expensify/questions/7972 for more details.