You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-05-14] Scan - After scanning completed, mark as cash button is not shown. #61019
Version Number: V9.1.33-3 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only If this was caught during regression testing, add the test name, ID and link from TestRail:https://expensify.testrail.io/index.php?/tests/view/6011247 Email or phone of affected tester (no customers): Slottwo1 f088fd@gmail.com Issue reported by: Applause Internal Team Device used: Redminote 10s android 13 App Component: Money Requests
changed the title [-]Scan - After scanning completed, mark as cash button is not shown.[/-][+][Due for payment 2025-05-14] Scan - After scanning completed, mark as cash button is not shown.[/+]on May 7, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.40-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@ikevin127@trjExpensify@ikevin127 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
I don't think we need regression tests here as they were added as part of the Simplified actions on report header issue.
Activity
melvin-bot commentedon Apr 29, 2025
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.trjExpensify commentedon Apr 29, 2025
@luacmartins is this perhaps known that the Mark as cash button is missing with the new simplified action buttons?
luacmartins commentedon Apr 29, 2025
It is not. We do have a check for it here, but I think we need to bump the priority on it so it shows above submit. cc @jnowakow
luacmartins commentedon Apr 29, 2025
Working on a draft here
luacmartins commentedon May 6, 2025
PR merged
1 remaining item
[-]Scan - After scanning completed, mark as cash button is not shown.[/-][+][Due for payment 2025-05-14] Scan - After scanning completed, mark as cash button is not shown.[/+]melvin-bot commentedon May 7, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 7, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.40-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-05-14. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 7, 2025
@ikevin127 @trjExpensify @ikevin127 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
ikevin127 commentedon May 8, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/58084/files#r2078862334.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
I don't think we need regression tests here as they were added as part of the
Simplified actions on report headerissue.Do we agree 👍 or 👎.
melvin-bot commentedon May 14, 2025
Payment Summary
Upwork Job
BugZero Checklist (@trjExpensify)
trjExpensify commentedon May 14, 2025
Payment summary as follows:
Offer sent.
ikevin127 commentedon May 14, 2025
@trjExpensify Offer accepted, thank you!
trjExpensify commentedon May 15, 2025
Excellent. Paid, closing!