Skip to content

[Due for payment 2025-05-14] Scan - After scanning completed, mark as cash button is not shown. #61019

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: V9.1.33-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6011247
Email or phone of affected tester (no customers): Slottwo1 f088fd@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13
App Component: Money Requests

Action Performed:

  1. Launch app
  2. Login as applausetester+pendingreceipt@applause.expensifail.com
  3. Open do not delete workspace chat
  4. Create a scan expense with below attached receipt
  5. Wait till scanning complete
  6. Note mark as cash button is not visible
  7. Submit, approve & pay the expense
  8. Note mark as cash button is not shown

Expected Result:

After scanning completed, mark as cash button must be shown.

Actual Result:

After scanning completed, mark as cash button is not shown.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

Image

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @trjExpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 29, 2025
  2. melvin-bot commented on Apr 29, 2025

    @melvin-bot

    Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. trjExpensify commented on Apr 29, 2025

    @trjExpensify
    Contributor

    @luacmartins is this perhaps known that the Mark as cash button is missing with the new simplified action buttons?

  4. luacmartins commented on Apr 29, 2025

    @luacmartins
    Contributor

    It is not. We do have a check for it here, but I think we need to bump the priority on it so it shows above submit. cc @jnowakow

  5. luacmartins commented on Apr 29, 2025

    @luacmartins
    Contributor

    Working on a draft here

  6. self-assigned this
    on Apr 29, 2025
  7. luacmartins commented on May 6, 2025

    @luacmartins
    Contributor

    PR merged

  8. 1 remaining item

  9. changed the title [-]Scan - After scanning completed, mark as cash button is not shown.[/-] [+][Due for payment 2025-05-14] Scan - After scanning completed, mark as cash button is not shown.[/+] on May 7, 2025
  10. melvin-bot commented on May 7, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on May 7, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.40-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-05-14. 🎊

    For reference, here are some details about the assignees on this issue:

    • @ikevin127 requires payment (Needs manual offer from BZ)
  12. melvin-bot commented on May 7, 2025

    @melvin-bot

    @ikevin127 @trjExpensify @ikevin127 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  13. ikevin127 commented on May 8, 2025

    @ikevin127
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/58084/files#r2078862334.

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    I don't think we need regression tests here as they were added as part of the Simplified actions on report header issue.

    Do we agree 👍 or 👎.

  14. melvin-bot commented on May 14, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    • ROLE: @ikevin127 paid $(AMOUNT) via Upwork (LINK)

    BugZero Checklist (@trjExpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  15. trjExpensify commented on May 14, 2025

    @trjExpensify
    Contributor

    Payment summary as follows:

    Offer sent.

  16. ikevin127 commented on May 14, 2025

    @ikevin127
    Contributor

    @trjExpensify Offer accepted, thank you!

  17. trjExpensify commented on May 15, 2025

    @trjExpensify
    Contributor

    Excellent. Paid, closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions