You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD App#63642] [Due for payment 2025-06-16] [Due for payment 2025-06-13] [$250] Tooltip - Scan tooltip is pointing to the edge of Scan button when Per diem is enabled #61084
Version Number: 9.1.33-5 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):djosdsjodsjsod@gmail.com Issue reported by: Applause - Internal Team
Action Performed:
Go to staging.new.expensify.com
Create a new Gmail account
Complete the onboarding with any user intent
Open FAB
Note that Scan tooltip is pointing to the middle of Scan button
Create a new workspace
Go to workspace settings > More features
Enable Per diems
Go to Per diems
Click Import spreadsheet
Upload a file, map the columns and click Import
Open FAB
Expected Result:
Scan tooltip will be pointing to the middle of Scan button
Actual Result:
Scan tooltip is pointing to the edge of Scan button when Per diem is enabled
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Platforms Tested:
On which of our officially supported platforms was this issue tested:
Android: App
Android: mWeb Chrome
iOS: App
iOS: mWeb Safari
iOS: mWeb Chrome
Windows: Chrome
MacOS: Chrome / Safari
MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidenceBug6816506_1745938191008.20250429_224135.mp4
🚨 Edited by proposal-police: This proposal was edited at 2025-04-29 15:34:15 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Tooltip - Scan tooltip is pointing to the edge of Scan button when Per diem is enabled
What is the root cause of that problem?
We always show the tooltip on the center of the page, but when per-diem feature is enabled scan button shift to left a bit. Because of that tooltip show at the edge of button.
What changes do you think we should make in order to solve the problem?
We can check if the per-diem is enabled like here then add shiftHorizontal property like below. We can move shouldShowPerDiemOption logic into common utility function.
Or we can pass shouldShowPerDiemOption from here as props
<EducationalTooltipshouldRender={shouldShowProductTrainingTooltip}renderTooltipContent={renderProductTrainingTooltip}shouldHideOnNavigateanchorAlignment={{horizontal: CONST.MODAL.ANCHOR_ORIGIN_HORIZONTAL.CENTER,vertical: CONST.MODAL.ANCHOR_ORIGIN_VERTICAL.TOP,}}wrapperStyle={styles.productTrainingTooltipWrapper}shiftVertical={-elementTop}shiftHorizontal={shouldShowPerDiemOption ? -40 : 0}// value can be changed during developement and we can move this value to some const file><Viewstyle={[styles.flex1,styles.alignItemsCenter,styles.justifyContentCenter]}>{!(isDraggingOver??isDraggingOverWrapper)&&(isMobile() ? mobileCameraView() : desktopUploadView())}</View></EducationalTooltip>
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA UI bug
What alternative solutions did you explore? (Optional)
constWrapper=({children})=>{// Below condition will be changed during developmentreturnshouldShowProductTrainingTooltip&&isActive&&isScanPage
? <EducationalTooltip...>{children}</EducationalTooltip>
: <TooltipshouldRender={!shouldShowLabelWhenInactive&&!isActive}text={title}>{children}</Tooltip>;}
Of course we need to pass required property from here like isScanPage and others if needed
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
🚨 Edited by proposal-police: This proposal was edited at 2025-05-06 03:23:01 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
When the Per Diem option is enabled, the Scan tooltip pointer is not centered on the Scan button but rather points to the edge of the button. This misalignment can be confusing for users, as the tooltip pointer should always be centered over the Scan button.
What is the root cause of that problem?
The tooltip is currently anchored to the entire container that appears after selecting a tab, rather than to the Scan tab item itself. As a result, changes to the Scan button's position do not affect the tooltip pointer, leading to misalignment.
What changes do you think we should make in order to solve the problem?
The tooltip anchor should be moved from the IOURequestStepScan container to the TabSelectorItem for the Scan tab, ensuring it stays aligned with the button despite layout changes.
changed the title [-]Tooltip - Scan tooltip is pointing to the edge of Scan button when Per diem is enabled[/-][+][$250] Tooltip - Scan tooltip is pointing to the edge of Scan button when Per diem is enabled[/+]on Apr 30, 2025
changed the title [-][Hold] [Due for payment 2025-06-16] [Due for payment 2025-06-13] [$250] Tooltip - Scan tooltip is pointing to the edge of Scan button when Per diem is enabled[/-][+][HOLD App#63642] [Due for payment 2025-06-16] [Due for payment 2025-06-13] [$250] Tooltip - Scan tooltip is pointing to the edge of Scan button when Per diem is enabled[/+]on Jul 3, 2025
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
It's more of a new feature
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
I'm not sure if tests are needed here
Since these are UI changes
Activity
melvin-bot commentedon Apr 29, 2025
Triggered auto assignment to @NicMendonca (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.ishakakkad commentedon Apr 29, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-04-29 15:34:15 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Tooltip - Scan tooltip is pointing to the edge of Scan button when Per diem is enabled
What is the root cause of that problem?
We always show the tooltip on the center of the page, but when per-diem feature is enabled scan button shift to left a bit. Because of that tooltip show at the edge of button.
App/src/pages/iou/request/step/IOURequestStepScan/index.tsx
Lines 909 to 923 in f950eb9
What changes do you think we should make in order to solve the problem?
We can check if the per-diem is enabled like here then add shiftHorizontal property like below. We can move
shouldShowPerDiemOptionlogic into common utility function.Or we can pass
shouldShowPerDiemOptionfrom here as propsWhat specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA UI bug
What alternative solutions did you explore? (Optional)
Another solution is to move EducationTooltip here
Add following logic here
Of course we need to pass required property from here like
isScanPageand others if neededReminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
nabi-ebrahimi commentedon Apr 29, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-05-06 03:23:01 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
When the Per Diem option is enabled, the Scan tooltip pointer is not centered on the Scan button but rather points to the edge of the button. This misalignment can be confusing for users, as the tooltip pointer should always be centered over the Scan button.
What is the root cause of that problem?
The tooltip is currently anchored to the entire container that appears after selecting a tab, rather than to the Scan tab item itself. As a result, changes to the Scan button's position do not affect the tooltip pointer, leading to misalignment.
What changes do you think we should make in order to solve the problem?
The tooltip anchor should be moved from the
IOURequestStepScancontainer to theTabSelectorItemfor the Scan tab, ensuring it stays aligned with the button despite layout changes.We can do this by moving the tooltip logic from:
IOURequestStepScan
To:
TabSelectorItem
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
What alternative solutions did you explore? (Optional)
[-]Tooltip - Scan tooltip is pointing to the edge of Scan button when Per diem is enabled[/-][+][$250] Tooltip - Scan tooltip is pointing to the edge of Scan button when Per diem is enabled[/+]melvin-bot commentedon Apr 30, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021917610623544539888
melvin-bot commentedon Apr 30, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (
External)ZhenjaHorbach commentedon Apr 30, 2025
Thanks for your proposals
I will check tomorrow morning !
dangrous commentedon May 1, 2025
can grab internal review on this when it's ready
58 remaining items
melvin-bot commentedon Jun 24, 2025
@NicMendonca Huh... This is 4 days overdue. Who can take care of this?
melvin-bot commentedon Jun 26, 2025
@NicMendonca Still overdue 6 days?! Let's take care of this!
melvin-bot commentedon Jun 30, 2025
@NicMendonca 10 days overdue. Is anyone even seeing these? Hello?
melvin-bot commentedon Jun 30, 2025
@NicMendonca 10 days overdue. I'm getting more depressed than Marvin.
dangrous commentedon Jun 30, 2025
Is this still on Hold or should I remove that from the title?
ZhenjaHorbach commentedon Jul 2, 2025
The PR for this issue is in prod already
So I think we can close this soon and then remove Hold here !
melvin-bot commentedon Jul 2, 2025
@NicMendonca 12 days overdue now... This issue's end is nigh!
[-][Hold] [Due for payment 2025-06-16] [Due for payment 2025-06-13] [$250] Tooltip - Scan tooltip is pointing to the edge of Scan button when Per diem is enabled[/-][+][HOLD App#63642] [Due for payment 2025-06-16] [Due for payment 2025-06-13] [$250] Tooltip - Scan tooltip is pointing to the edge of Scan button when Per diem is enabled[/+]ZhenjaHorbach commentedon Jul 4, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
It's more of a new feature
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
I'm not sure if tests are needed here
Since these are UI changes
NicMendonca commentedon Jul 4, 2025
Payment summary
Contributor+: @ZhenjaHorbach - $250 via NewDot
Contributor: @ishakakkad - $250 via Upwork (done ✅ )
ZhenjaHorbach commentedon Jul 4, 2025
Requested in ND !
garrettmknight commentedon Jul 21, 2025
$250 approved for @ZhenjaHorbach