Skip to content

[Due for payment 2025-05-28] [$250] Expense - When report is unsubmitted, Hold option is only seen in expense preview and not report #61164

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.38-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Workspace Setup - Hold option is displayed for approver
Email or phone of affected tester (no customers): applausetester+kh300410@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Log in with Expensifail accounts.
  • Admin and member are in the same workspace.
  • Delay submissions is enabled
  1. Go to staging.new.expensify.com
  2. [Member] Go to workspace chat.
  3. [Member} Create an expense in the workspace chat but do not click Submit button on the expense preview.
  4. [Admin] Go to workspace chat with member.
  5. [Admin] Go to expense report.
  6. [Admin] Open More menu.
  7. [Admin] Open report header.
  8. [Admin] Go back to main workspace chat.
  9. [Admin] Right click on the expense preview.
  10. [Admin] Note that Hold option is only present in expense preview context menu in the main chat.

Expected Result:

When the report is not submitted,

  • In Step 6, 7 and 10, Hold option should be consistent in the expense preview and expense report.
  • It should be present (or absent) in both the expense preview context menu and expense report.

Actual Result:

When the report is not submitted,

  • In Step 6 and 7, Hold option is not seen in the expense report (report header and More menu).
  • In Step 10, Hold option is only seen in the expense preview context menu.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021917597492314624170
  • Upwork Job ID: 1917597492314624170
  • Last Price Increase: 2025-04-30
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @NicMendonca

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 30, 2025
  2. melvin-bot commented on Apr 30, 2025

    @melvin-bot

    Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 30, 2025
  4. changed the title [-]Expense - When report is unsubmitted, Hold option is only seen in expense preview and not report[/-] [+][$250] Expense - When report is unsubmitted, Hold option is only seen in expense preview and not report[/+] on Apr 30, 2025
  5. melvin-bot commented on Apr 30, 2025

    @melvin-bot
  6. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 30, 2025
  7. melvin-bot commented on Apr 30, 2025

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

  8. ZhenjaHorbach commented on Apr 30, 2025

    @ZhenjaHorbach
    Contributor

    @Themoonalsofall

    Thanks for your proposal
    I will check tomorrow morning !

  9. self-assigned this
    on May 1, 2025
  10. dangrous commented on May 1, 2025

    @dangrous
    Contributor

    can grab internal review on this when it's ready

  11. ZhenjaHorbach commented on May 1, 2025

    @ZhenjaHorbach
    Contributor

    @Themoonalsofall
    Thanks for your proposal
    But i'm not sure that is a right way to fix this issue
    I think we need to update the condition so that it has the same behavior as on the ReportDetailsPage screen that was used in the old UI

  12. 23 remaining items

  13. melvin-bot commented on May 21, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.47-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-05-28. 🎊

    For reference, here are some details about the assignees on this issue:

    • @ZhenjaHorbach requires payment through NewDot Manual Requests
    • @Themoonalsofall requires payment (Needs manual offer from BZ)
  14. melvin-bot commented on May 21, 2025

    @melvin-bot

    @ZhenjaHorbach @NicMendonca @ZhenjaHorbach The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. ZhenjaHorbach commented on May 27, 2025

    @ZhenjaHorbach
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/58084/files#r2109786875

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: NA

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Precondition:

    • Admin and member are in the same workspace.
    • Delay submissions is enabled

    Test:

    1. Go to staging.new.expensify.com
    2. [Member] Go to workspace chat.
    3. [Member} Create an expense in the workspace chat but do not click Submit button on the expense preview.
    4. [Admin] Go to workspace chat with member.
    5. [Admin] Go to expense report.
    6. [Admin] Open More menu.
    7. [Admin] Open report header.
    8. [Admin] Go back to main workspace chat.
    9. [Admin] Right click on the expense preview.
    10. [Admin] Note that Hold option is only present in expense preview context menu in the main chat.
    11. Verify that when the report is not submitted, It should be present (or absent) in both the expense preview context menu and expense report.

    Do we agree 👍 or 👎

  16. melvin-bot commented on May 28, 2025

    @melvin-bot

    Payment Summary

    Upwork Job

    • Reviewer: @ZhenjaHorbach owed $250 via NewDot
    • ROLE: @Themoonalsofall paid $(AMOUNT) via Upwork (LINK)

    BugZero Checklist (@NicMendonca)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1917597492314624170/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  17. NicMendonca commented on May 28, 2025

    @NicMendonca
    Contributor

    @Themoonalsofall sent you an offer!

  18. NicMendonca commented on May 29, 2025

    @NicMendonca
    Contributor

    Payment summary

    Contributor: @Themoonalsofall paid $250 via Upwork (done ✅ )
    Contributor+: @ZhenjaHorbach paid $250 via NewDot

  19. ZhenjaHorbach commented on Jun 19, 2025

    @ZhenjaHorbach
    Contributor

    Requested in ND

  20. garrettmknight commented on Jun 26, 2025

    @garrettmknight
    Contributor

    $250 approved for @ZhenjaHorbach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions