You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-05-28] [$250] Expense - When report is unsubmitted, Hold option is only seen in expense preview and not report #61164
Version Number: 9.1.38-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: Workspace Setup - Hold option is displayed for approver Email or phone of affected tester (no customers):applausetester+kh300410@applause.expensifail.com Issue reported by: Applause Internal Team Device used: Mac 15.3 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Log in with Expensifail accounts.
Admin and member are in the same workspace.
Delay submissions is enabled
Go to staging.new.expensify.com
[Member] Go to workspace chat.
[Member} Create an expense in the workspace chat but do not click Submit button on the expense preview.
[Admin] Go to workspace chat with member.
[Admin] Go to expense report.
[Admin] Open More menu.
[Admin] Open report header.
[Admin] Go back to main workspace chat.
[Admin] Right click on the expense preview.
[Admin] Note that Hold option is only present in expense preview context menu in the main chat.
Expected Result:
When the report is not submitted,
In Step 6, 7 and 10, Hold option should be consistent in the expense preview and expense report.
It should be present (or absent) in both the expense preview context menu and expense report.
Actual Result:
When the report is not submitted,
In Step 6 and 7, Hold option is not seen in the expense report (report header and More menu).
In Step 10, Hold option is only seen in the expense preview context menu.
changed the title [-]Expense - When report is unsubmitted, Hold option is only seen in expense preview and not report[/-][+][$250] Expense - When report is unsubmitted, Hold option is only seen in expense preview and not report[/+]on Apr 30, 2025
@Themoonalsofall
Thanks for your proposal
But i'm not sure that is a right way to fix this issue
I think we need to update the condition so that it has the same behavior as on the ReportDetailsPage screen that was used in the old UI
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.47-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@ZhenjaHorbach@NicMendonca@ZhenjaHorbach The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Admin and member are in the same workspace.
Delay submissions is enabled
Test:
Go to staging.new.expensify.com
[Member] Go to workspace chat.
[Member} Create an expense in the workspace chat but do not click Submit button on the expense preview.
[Admin] Go to workspace chat with member.
[Admin] Go to expense report.
[Admin] Open More menu.
[Admin] Open report header.
[Admin] Go back to main workspace chat.
[Admin] Right click on the expense preview.
[Admin] Note that Hold option is only present in expense preview context menu in the main chat.
Verify that when the report is not submitted, It should be present (or absent) in both the expense preview context menu and expense report.
Activity
melvin-bot commentedon Apr 30, 2025
Triggered auto assignment to @NicMendonca (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.[-]Expense - When report is unsubmitted, Hold option is only seen in expense preview and not report[/-][+][$250] Expense - When report is unsubmitted, Hold option is only seen in expense preview and not report[/+]melvin-bot commentedon Apr 30, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021917597492314624170
melvin-bot commentedon Apr 30, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (
External)ZhenjaHorbach commentedon Apr 30, 2025
@Themoonalsofall
Thanks for your proposal
I will check tomorrow morning !
dangrous commentedon May 1, 2025
can grab internal review on this when it's ready
ZhenjaHorbach commentedon May 1, 2025
@Themoonalsofall
Thanks for your proposal
But i'm not sure that is a right way to fix this issue
I think we need to update the condition so that it has the same behavior as on the ReportDetailsPage screen that was used in the old UI
23 remaining items
melvin-bot commentedon May 21, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.47-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-05-28. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 21, 2025
@ZhenjaHorbach @NicMendonca @ZhenjaHorbach The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
ZhenjaHorbach commentedon May 27, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/58084/files#r2109786875
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
melvin-bot commentedon May 28, 2025
Payment Summary
Upwork Job
BugZero Checklist (@NicMendonca)
NicMendonca commentedon May 28, 2025
@Themoonalsofall sent you an offer!
NicMendonca commentedon May 29, 2025
Payment summary
Contributor: @Themoonalsofall paid $250 via Upwork (done ✅ )
Contributor+: @ZhenjaHorbach paid $250 via NewDot
ZhenjaHorbach commentedon Jun 19, 2025
Requested in ND
garrettmknight commentedon Jun 26, 2025
$250 approved for @ZhenjaHorbach