You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-06-02] [$150] Android - Chat - While entering :+1 after emoji in edit comment cursor shown at beginning. #61292
Version Number: V9.1.39-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail:https://expensify.testrail.io/index.php?/tests/view/6034550 Email or phone of affected tester (no customers): Slottwo1 dasd1@gmail.com Issue reported by: Applause Internal Team Device used: Redminote note 10s android 13 App Component: Chat Report View
Action Performed:
Launch app
Open a chat
Send a message
Long press the sent message and select edit comment
Tap emoji picker and select an emoji
Enter :+1
Tap emoji picker and change skin tone
Tap backdrop to close emoji modal
Expected Result:
While entering :+1 after emoji in edit comment cursor must not be shown at beginning.
Actual Result:
While entering :+1 after emoji in edit comment cursor shown at beginning.
Please re-state the problem that we are trying to solve in this issue.
After closing the emoji picker, the cursor moves back.
What is the root cause of that problem?
The test step has unnecessary steps, such as changing the skin tone. This issue happens after we select an emoji once from the emoji picker, type anything, and then open emoji picker again and then close without selecting an emoji.
For example, if we input and select 😄 from the emoji picker Hi 😄 asd|, when we reopen and then close the emoji picker, the cursor will move to the front of the emoji Hi 😄 |asd.
When closing the emoji picker, we refocus the composer and pass a emojiPickerSelectionRef as the selection.
changed the title [-]Android - Chat - While entering :+1 after emoji in edit comment cursor shown at beginning.[/-][+][$250] Android - Chat - While entering :+1 after emoji in edit comment cursor shown at beginning.[/+]on May 9, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.51-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@mananjadhav@dylanexpensify@mananjadhav The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Couldn't pinpoint a specific PR.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
@dylanexpensify Because it is related cursor I think it makes sense to add a regression test.
Activity
melvin-bot commentedon May 2, 2025
Triggered auto assignment to @dylanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon May 5, 2025
@dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
dylanexpensify commentedon May 6, 2025
reproing tomorrow!
bernhardoj commentedon May 9, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
After closing the emoji picker, the cursor moves back.
What is the root cause of that problem?
The test step has unnecessary steps, such as changing the skin tone. This issue happens after we select an emoji once from the emoji picker, type anything, and then open emoji picker again and then close without selecting an emoji.
For example, if we input and select 😄 from the emoji picker
Hi 😄 asd|, when we reopen and then close the emoji picker, the cursor will move to the front of the emojiHi 😄 |asd.When closing the emoji picker, we refocus the composer and pass a
emojiPickerSelectionRefas the selection.App/src/pages/home/report/ReportActionItemMessageEdit.tsx
Lines 176 to 180 in a3446b8
It's set when selecting an emoji from the picker.
App/src/pages/home/report/ReportActionItemMessageEdit.tsx
Lines 290 to 305 in a3446b8
However, we never clear the ref, that's why when refocus happens, the selection moves back to the front of the previously picked emoji.
What changes do you think we should make in order to solve the problem?
Clear the ref after refocus.
App/src/pages/home/report/ReportActionItemMessageEdit.tsx
Lines 176 to 180 in a3446b8
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
N/A
[-]Android - Chat - While entering :+1 after emoji in edit comment cursor shown at beginning.[/-][+][$250] Android - Chat - While entering :+1 after emoji in edit comment cursor shown at beginning.[/+]melvin-bot commentedon May 9, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021920784691456319514
27 remaining items
melvin-bot commentedon May 26, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 26, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.51-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-06-02. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 26, 2025
@mananjadhav @dylanexpensify @mananjadhav The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Jun 2, 2025
Payment Summary
Upwork Job
BugZero Checklist (@dylanexpensify)
mananjadhav commentedon Jun 3, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Couldn't pinpoint a specific PR.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
@dylanexpensify Because it is related cursor I think it makes sense to add a regression test.
Regression Test Proposal
Do we agree 👍 or 👎
dylanexpensify commentedon Jun 4, 2025
Payment summary:
Contributor: @bernhardoj $150 via NewDot
Contributor+: @mananjadhav $150 via NewDot
Please apply/request!
mananjadhav commentedon Jun 4, 2025
@dylanexpensify The payout is $150.
dylanexpensify commentedon Jun 4, 2025
TY Sir!!
bernhardoj commentedon Jun 4, 2025
Requested in ND.
JmillsExpensify commentedon Jun 9, 2025
$150 approved for @bernhardoj
garrettmknight commentedon Jun 13, 2025
$150 approved for @mananjadhav