You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-05-27] [$250] Expense - Tapping change workspace directs to hmm not here page #61342
Version Number: 9.1.39-2 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): applausetester nsquare@applause.expensifail.com Issue reported by: Applause - Internal Team
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
Also remove !report.unheldTotal check if needed (once expected behavior is super clear here.)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
uses the condition !report.total && !report.unheldTotal to determine whether to show the "not here" page.
This condition was introduced to address this issue.
However, if an expense scan or any other money request results in a total amount of 0, this condition incorrectly triggers the "Hmm, not here" page—even though there are valid transactions in the report.
What changes do you think we should make in order to solve the problem?
Replace the condition !report.total && !report.unheldTotal with a check on the actual number of transactions using transactions.length === 0.
The transactions array can be obtained from the useReportWithTransactionsAndViolations hook:
if (!isMoneyRequestReport(report) || isMoneyRequestReportPendingDeletion(report)) {
With this change, the behavior would be as follows:
If the report contains only a scanned expense (with a total of 0), the user is still allowed to change the workspace.
If the report has no transactions at all, the user can still change the workspace.
If the expense report was deleted due to the associated expense being removed (as described in issue #58459), then the report itself will also be removed. This means the bug described in that issue is no longer reproducible.
This solution handles edge cases more gracefully while preserving expected user flows.
changed the title [-]Expense - Tapping change workspace directs to hmm not here page[/-][+][$250] Expense - Tapping change workspace directs to hmm not here page[/+]on May 6, 2025
changed the title [-][$250] Expense - Tapping change workspace directs to hmm not here page[/-][+][Due for payment 2025-05-27] [$250] Expense - Tapping change workspace directs to hmm not here page[/+]on May 20, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.46-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@QichenZhu@OfstadC@QichenZhu The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon May 2, 2025
Triggered auto assignment to @OfstadC (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.samranahm commentedon May 2, 2025
@lanitochka17 seams like the attached video is not related to this bug.
Also I am unable to reproduce the bug based on OP.
Screen.Recording.2025-05-02.at.10.51.05.PM.mov
ChavdaSachin commentedon May 2, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
Tapping change workspace directs to hmm not here page
What is the root cause of that problem?
We render
NotFoundPagehere, if report total is a falsie value here.App/src/pages/ReportChangeWorkspacePage.tsx
Line 69 in b1b95a3
What changes do you think we should make in order to solve the problem?
We should remove the check
!report.totalhere, allowing to change report workspace even though there's no expense yet.App/src/pages/ReportChangeWorkspacePage.tsx
Line 69 in b1b95a3
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
NA
What alternative solutions did you explore? (Optional)
Also remove
!report.unheldTotalcheck if needed (once expected behavior is super clear here.)Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
truph01 commentedon May 3, 2025
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
App/src/pages/ReportChangeWorkspacePage.tsx
Line 69 in 74b93b9
uses the condition
!report.total && !report.unheldTotalto determine whether to show the "not here" page.0, this condition incorrectly triggers the "Hmm, not here" page—even though there are valid transactions in the report.What changes do you think we should make in order to solve the problem?
!report.total && !report.unheldTotalwith a check on the actual number of transactions usingtransactions.length === 0.transactionsarray can be obtained from theuseReportWithTransactionsAndViolationshook:What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)
App/src/pages/ReportChangeWorkspacePage.tsx
Line 69 in 74b93b9
to:
This solution handles edge cases more gracefully while preserving expected user flows.
melvin-bot commentedon May 6, 2025
@OfstadC Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
[-]Expense - Tapping change workspace directs to hmm not here page[/-][+][$250] Expense - Tapping change workspace directs to hmm not here page[/+]melvin-bot commentedon May 6, 2025
Job added to Upwork: https://www.upwork.com/jobs/~021919856990960117725
melvin-bot commentedon May 6, 2025
Triggered auto assignment to Contributor-plus team member for initial proposal review - @QichenZhu (
External)24 remaining items
truph01 commentedon May 15, 2025
@QichenZhu PR is ready
[-][$250] Expense - Tapping change workspace directs to hmm not here page[/-][+][Due for payment 2025-05-27] [$250] Expense - Tapping change workspace directs to hmm not here page[/+]melvin-bot commentedon May 20, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 20, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.46-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-05-27. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 20, 2025
@QichenZhu @OfstadC @QichenZhu The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
QichenZhu commentedon May 26, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/58534/files#r2107092879
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/505035
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
OfstadC commentedon May 27, 2025
Payment Summary