You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-05-22] [Better Expense Report View] - Expense with multiple violations does not show Review Required when held #61473
Version Number: 9.1.40-0 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail:#60819 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Device used: Windows 10 / Chrome, Samsung Galaxy A12 / Android 13 App Component: Chat Report View
Action Performed:
Log in to staging.expensify.com
Create an expense with multiple violations (Duplicate, amount over the limit, no receipt, no categories)
Put the created expense on Hold
Go to Expense Preview
Expected Result:
"Review Required" RBR is displayed on expense with multiple violations
Actual Result:
"Expense is put on hold" is displayed when an expense with multiple violations is put on hold
Note: We should also consider the priority of iou.missingAmount and iou.missingMerchant to sort
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
changed the title [-]Expense - Expense with multiple violations does not show Review Required when held[/-][+][Better Expense Report View] - Expense with multiple violations does not show Review Required when held[/+]on May 6, 2025
changed the title [-][Better Expense Report View] - Expense with multiple violations does not show Review Required when held[/-][+][Due for payment 2025-05-22] [Better Expense Report View] - Expense with multiple violations does not show Review Required when held[/+]on May 15, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.45-21 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@DylanDylann@trjExpensify@DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon May 6, 2025
Triggered auto assignment to @miljakljajic (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nkdengineer commentedon May 6, 2025
🚨 Edited by proposal-police: This proposal was edited at 2025-05-06 11:15:36 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
"Expense is put on hold" is displayed when an expense with multiple violations is put on hold
What is the root cause of that problem?
We are prioritizing showing 'iou.expenseWasPutOnHold' here
App/src/libs/TransactionPreviewUtils.ts
Lines 177 to 179 in eda8408
What changes do you think we should make in order to solve the problem?
We should move this code to the below here
App/src/libs/TransactionPreviewUtils.ts
Lines 185 to 195 in eda8408
Note: We should also consider the priority of iou.missingAmount and iou.missingMerchant to sort
What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
None
What alternative solutions did you explore? (Optional)
NA
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.
[-]Expense - Expense with multiple violations does not show Review Required when held[/-][+][Better Expense Report View] - Expense with multiple violations does not show Review Required when held[/+]trjExpensify commentedon May 6, 2025
Bug fix from this PR, @JakubKorytko is going to handle.
2 remaining items
trjExpensify commentedon May 13, 2025
Awaiting a deploy.
[-][Better Expense Report View] - Expense with multiple violations does not show Review Required when held[/-][+][Due for payment 2025-05-22] [Better Expense Report View] - Expense with multiple violations does not show Review Required when held[/+]melvin-bot commentedon May 15, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 15, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.45-21 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-05-22. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 15, 2025
@DylanDylann @trjExpensify @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
trjExpensify commentedon May 15, 2025
I think we can close this now then. 👍